html export should optionally include feedback

Bug #784313 reported by Craig Eves
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Ruslan Kabalin

Bug Description

Tried exporting a view with feedback as html and the result didnt include the feedback.

Using Mahara 1.3 and 1.4 - Windows, Postgres , Firefox browser.

Changed in mahara:
status: New → Triaged
milestone: none → 1.4.0
importance: Undecided → Medium
milestone: 1.4.0 → none
Revision history for this message
Hugh Davenport (hugh-davenport) wrote :

This creates a related question about functionality

- Should copying a view copy the feedback as well?

Cheers,

Hugh

Changed in mahara:
assignee: nobody → Hugh Davenport (hugh-catalyst)
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

If best, there should be the option to include the feedback or to leave it out.

1) You want the feedback included in a copy of the page when you want to keep it somewhere where you don't change it or where you want to make a copy for your teacher who keeps the page.

2) You don't want feedback when you want to make a clean / fresh copy or even use the page as a template for others to use.

Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

I don't think copying a view should copy feedback, it just seems too easy for the feedback lose all context. Think of the expectations of the feedback author. It's already kind of bad that the view owner can change the view after the feedback has been added. But when feedback you've written can be copied over to a view owned by a totally different person, and you're still marked as the feedback author on the other person's view, I think that's crossing a line.

Revision history for this message
Craig Eves (craig-flexible) wrote :

I can see your point - would making the feedback anonymous be an option.

The situation this is required for is for students portfolio work that has been submitted and feedback provided by a learning provider to be judged by external parties.

The external parties do not want to be setup on myportfolio but want online access to the work and want to see feedback on the portfolio.

Changed in mahara:
importance: Medium → Wishlist
summary: - html export doesn't include feedback
+ html export should optionally include feedback
tags: added: htmlexport
Revision history for this message
Richard Mansfield (richard-mansfield) wrote :

Craig, I should have been clearer, I think exporting feedback along with views in an html export is a good idea. That's pretty well read-only, and the exported website would only show the commenter's name.

But I don't think feedback should be copied along with a view, from one user to another within a single Mahara installation.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

I think it would be good to copy feedback in a page into somebody else's portfolio for the reason that Craig has outlined above. However, Richard, you are right when you say it may not be good. So far, the ownership of the page is transferred to the other person and then of course all things get different. But what about the option to copy a page as "read-only" which will only be copied for safe-keeping, e.g. by a teacher who can then present it to moderators. That would also prevent a page to have another name as author like at the moment (When I copy "My Portfolio", it reads "My Portfolio by Kristina" and would change into "My Portfolio by Paula") which is a serious problem in the case of safe-keeping.

I don't agree that the feedback should be anonymized because a moderator may want to see what a teacher has said in contrast to what students have said. The anonymization raises a whole lot of other questions.

So in a way, when the student submits a page for feedback, the teacher can make a copy of that page after he gave feedback and freeze it not allowing any further editing. He gives back the original to the student who can continue editing it. If he submits it again, the teacher can make another copy that he freezes.

Changed in mahara:
assignee: Hugh Davenport (hugh-catalyst) → nobody
Changed in mahara:
assignee: nobody → Ruslan Kabalin (ruslan-kabalin)
status: Triaged → In Progress
Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

The option to include the user feedback to html export has been added: https://reviews.mahara.org/#q,status:open+project:mahara+branch:master+topic:html_export_feedback,n,z

Currently it includes all feedback related to particular view and displays it on the single page below the view.

Revision history for this message
Ruslan Kabalin (rkabalin) wrote :

Related bug #731062

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/284
Committed: http://gitorious.org/mahara/mahara/commit/d0f825a71a73c18f42654e1033068e69360a69ef
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit d0f825a71a73c18f42654e1033068e69360a69ef
Author: Ruslan Kabalin <email address hidden>
Date: Fri Jun 3 11:00:22 2011 +0100

    Add an option to include feedback to html export (bug #784313)

    All the feedback comments will be displayed on the single exported page, no
    pagination or limits. Star rating is preserved.

    Change-Id: I1d8c175ec2cb1b7c328c6b1835b95e95f2786dc5
    Signed-off-by: Ruslan Kabalin <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/524
Committed: http://gitorious.org/mahara/mahara/commit/8fbf3b443844fb7802ec14c1ebabf31cb2e84156
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 8fbf3b443844fb7802ec14c1ebabf31cb2e84156
Author: Ruslan Kabalin <email address hidden>
Date: Thu Jul 7 17:06:35 2011 +0100

    Fix html export tumbnail replacement filter compatibility issues (bug #784313)

    This patch updates the filter the way it could handle all possible ampersand
    notations. It effectively replaces patch 858f1b9a with more approprate
    approach suggested by Richard.

    Change-Id: I084fb04b5d1cad22006e390509ea610e2aec3e78
    Signed-off-by: Richard Mansfield <email address hidden>
    Signed-off-by: Ruslan Kabalin <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Changed in mahara:
milestone: none → 1.5.0
tags: added: newfeature
Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqdlAAoJECXBtiziiXdcxeoH/iQi1ljFCaDUrA07cq6IAZga
p3Tw7VRtZBy6Cl5NwOFg1b4/DsqFIM9fQPb+WpJqUAcTVP6B44QElOCtb0ldeZCw
cgWlkkSj1jk/gpCdKhCZ2MMHkRjMao5ZpUyF4vSO26tIiYcvPIhRoF6uWu0Z40xe
1wee4ZKGEEvO13bujMyuu4nEQSd9TK5VWPn+PbIKFEyJgCY19Zw62fWBXoanPbWj
LDuO9AnaQOPyVEx2qtoH8M5LFra2zq+dZ9Ac7oAiLffcWJAB9MqL8o2zbQHpOuVi
Ynrh6BIyUYaqdt1BhALrJ6/MQ0h7mDKGy8CVg0z4e2VHyxecYwc84kwzrItH7I0=
=mdeb
-----END PGP SIGNATURE-----

Revision history for this message
Melissa Draper (melissa) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrRzAAoJECXBtiziiXdcggYH/39bWTAPjHe9fUi3ve11K6iW
/R7j+mSc51e/47Cx0Z1Xv1HkDY0ymFLyRU/4CgErzWLWtrlSVhDx/r3gf8aHj+A+
ICmHRmTTCRBij5sKZVZbzZDN/t9drPvJ1u1dWcagGR2DiXoxAa9Kd2LUXKScRvS6
DqhQWj42JiOoo1R1FGFLa8dpPwlzwuLKyQQ6gvdDutva0E3RqktUUBy8w6ieMG6E
UM/K4sdgx7AAhfBxg91349DOjKeHE/69Vb1gbJXE9UtY/xwe+3sgBtAM7aN4e5US
PhBcGckRLkgxpwLwDzTNGuDHFp51OjIdqXaoRAxXx3tgOonY2bs/eqg42RJBcR4=
=dLjM
-----END PGP SIGNATURE-----

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.