Quick Note opens notebook when "open new page" is unselected

[dotancohen]

When using the Quick Note feature and unselecting the "open new page" checkbox, the notebook where the note was saved is opened. If the user didn't want to open the new page, he certainly didn't want to open the notebook!

To test this, save a Quick Note from the Zim tray icon with no notebooks open.

[Jaap Karssenberg (jaap.karssenberg)]

What version are you currently using? I believe this is fixed already in 0.52.

[dotancohen (dotancohen)]

Happens reliably in 0.52. I'm using the KDE desktop, if that matters.

✈demios:~$ zim -D
INFO: This is zim 0.52
DEBUG: Python version is sys.version_info(major=2, minor=7, micro=1, releaselevel='final', serial=0)
DEBUG: Platform is posix
DEBUG: Zim revision is:
        branch: pyzim-trunk
        revision: 391 <email address hidden>
        date: 2011-04-28 20:09:07 +0200

DEBUG: Not running from a source dir
DEBUG: Set XDG_DATA_HOME to /home/dotancohen/.local/share
DEBUG: Set XDG_DATA_DIRS to [<Dir: /usr/share>, <Dir: /usr/share>, <Dir: /usr/local/share>]
DEBUG: Set XDG_CONFIG_HOME to /home/dotancohen/.config
DEBUG: Set XDG_CONFIG_DIRS to [<Dir: /etc/xdg>]
DEBUG: Set XDG_CACHE_HOME to /home/dotancohen/.cache
DEBUG: Running command: gui

[Jaap Karssenberg (jaap.karssenberg)]

On Tue, May 31, 2011 at 5:02 PM, dotancohen <email address hidden>wrote:

> Happens reliably in 0.52. I'm using the KDE desktop, if that matters.
>

OK, let's be more precise. If the notebook is not yet open it is opened and
appears. However it is running somewhere in the background it is not popped
to the front.

Does that match your observation ?

-- Jaap

[dotancohen (dotancohen)]

> OK, let's be more precise. If the notebook is not yet open it is opened and
> appears. However it is running somewhere in the background it is not popped
> to the front.

Not quite.

0) The Quick Note dialogue is set to save in notebook Foo, page Bar. Zim is configured to use the system tray plugin. Zim is not running in the background.
1) Open Zim from the DE main menu, Open notebook SomeNotebook (where SomeNotebook != Foo).
2) Click the X button in the window chrome to close the SomeNotebook notebook.
3) Right click the system tray icon, select Quick Note.
4) Enter a note. Be sure the "open new page" checkbox is unchecked.
5) Click OK.

What happens:
The notebook Foo opens.

What the user expects to happen:
The user expects that nothing will open, because the "open new page" checkbox is unchecked.

[Jaap Karssenberg (jaap.karssenberg)]

On Tue, May 31, 2011 at 8:53 PM, dotancohen <email address hidden>wrote:

> 0) The Quick Note dialogue is set to save in notebook Foo, page Bar. Zim is
> configured to use the system tray plugin. Zim is not running in the
> background.
> 1) Open Zim from the DE main menu, Open notebook SomeNotebook (where
> SomeNotebook != Foo).
> 2) Click the X button in the window chrome to close the SomeNotebook
> notebook.
> 3) Right click the system tray icon, select Quick Note.
> 4) Enter a note. Be sure the "open new page" checkbox is unchecked.
> 5) Click OK.
>
> What happens:
> The notebook Foo opens.
>

I'm sorry but that is not what happens on my system. I tried it again and
absolutely positive the window stays hidden. I also double checked the code
and it clearly says:

            if self.open_page.get_active():
                ui.present(path) # also works with proxy

So the ui will not be presented if the open_page checkbox is not set.

As far as I can tell from the revision history it did so before but this has
already been fixed with release 0.50 .

Could you double check the version of zim that is being run in the tray icon
process ? Or kill it and run the full thing in debug output ?

-- Jaap

[Jiří Janoušek (fenryxo)]

I can reproduce with Zim r404.

[dotancohen (dotancohen)]

Yes, I've double and triple checked, it's 0.52. Here is a screencast:
http://dotancohen.com/images/zim.avi

I suppose that you cannot read Hebrew, but you'll need to make do with only two phrases: The notebook that I open is called "לינוקס" and the notebook that I save the note to is called "הערות ימיומיות".

[Jaap Karssenberg (jaap.karssenberg)]

On Tue, May 31, 2011 at 9:42 PM, Jaap Karssenberg <
<email address hidden>> wrote:

> On Tue, May 31, 2011 at 8:53 PM, dotancohen <email address hidden>wrote:
>
>> 0) The Quick Note dialogue is set to save in notebook Foo, page Bar. Zim
>> is configured to use the system tray plugin. Zim is not running in the
>> background.
>> 1) Open Zim from the DE main menu, Open notebook SomeNotebook (where
>> SomeNotebook != Foo).
>> 2) Click the X button in the window chrome to close the SomeNotebook
>> notebook.
>> 3) Right click the system tray icon, select Quick Note.
>> 4) Enter a note. Be sure the "open new page" checkbox is unchecked.
>> 5) Click OK.
>>
>> What happens:
>> The notebook Foo opens.
>>
>
> I'm sorry but that is not what happens on my system. I tried it again and
> absolutely positive the window stays hidden. I also double checked the code
> and it clearly says
>

Wait, seems I misread your description. You are using 2 notebook, so the
notebook "Foo" is not open and open because it is called for the first time.
This is exactly the behavior I noted in comment #3.

-- Jaap

P.S. can't see that screencast, not sure if it is my browser plugins or the
website..

[dotancohen (dotancohen)]

Jaָap, tִry dֹownlֹoַading the video and opening it with VLC.

[Jaap Karssenberg (jaap.karssenberg)]

Video is no longer available (404) - maybe attach in launchpad to have it available more permanently or is it to big ?

-- Jaap

[dotancohen (dotancohen)]

I just deleted that video about two days ago! It is big.

My environment is KDE, maybe that is related? Can another KDE user check?

I just tested again with the instructions in comment #4, and sure enough I can reproduce the bug.

[Launchpad Janitor (janitor)]

[Expired for Zim because there has been no activity for 60 days.]

[dotancohen (dotancohen)]

I can still reproduce this issue in the latest Zim.

[KSSG (kssg)]

I can also still reproduce this bug with the latest bzr version as of today. (r580)

[sojusnik (sojusnik)]

The same goes for me on Ubuntu 12.10 with Gnome Shell, Zim 0.59.

Command to summon a quick note:

zim --plugin quicknote input=clipboard

When notebook is open, then it stays in background after adding a quick note. When everything is closed, then the last page of my default notebook is opened.

[sojusnik (sojusnik)]

Additional information: I use only one notebook and no system tray. In a word, after adding a quick note, my notebook is always opened with the last used page, when Zim was not running before (closed with Strg+W and Strg+Q). If it runs, then it stays in the background after adding a quick note.