pep8 issues in the tools directory

[Rick Harris]

Looks like the python files under the tools directory aren't being checked for pep8 compliance. We should probably add tools/*.py to the pep8 check and fix the current failures:

Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
install_venv.py:33:13: E225 missing whitespace around operator
install_venv.py:34:80: E501 line too long (81 characters)
install_venv.py:36:1: E302 expected 2 blank lines, found 1
install_venv.py:37:3: E111 indentation is not a multiple of four
install_venv.py:41:27: E231 missing whitespace after ','
install_venv.py:73:57: W291 trailing whitespace

[Justin Shepherd (jshepher)]

Updated run_tests.sh to include tools/* for pep8 tests.

[Justin Shepherd (jshepher)]

Once the above update was in place, i am showing ~30000 pep8 violations in tools/*.

I fixed ~12000 pep8 violations in tools/ajaxterm/qweb.py.

There are still a bunch of line-to-long errors, and errors about using 'in' instead of '{}.has_key' in tools/ajaxterm/qweb.py.

[Vish Ishaya (vishvananda)]

Unfortunately ajaxterm is not our code, so I'm not sure if it is a good idea to do pep8 cleanup on it.

On May 15, 2011, at 9:52 PM, Justin Shepherd wrote:

> Once the above update was in place, i am showing ~30000 pep8 violations
> in tools/*.
>
> I fixed ~12000 pep8 violations in tools/ajaxterm/qweb.py.
>
> There are still a bunch of line-to-long errors, and errors about using
> 'in' instead of '{}.has_key' in tools/ajaxterm/qweb.py.
>
> ** Changed in: nova
> Assignee: (unassigned) => Justin Shepherd (jshepher)
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/781429
>
> Title:
> pep8 issues in the tools directory
>
> Status in OpenStack Compute (Nova):
> New
>
> Bug description:
> Looks like the python files under the tools directory aren't being
> checked for pep8 compliance. We should probably add tools/*.py to the
> pep8 check and fix the current failures:
>
> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
> install_venv.py:33:13: E225 missing whitespace around operator
> install_venv.py:34:80: E501 line too long (81 characters)
> install_venv.py:36:1: E302 expected 2 blank lines, found 1
> install_venv.py:37:3: E111 indentation is not a multiple of four
> install_venv.py:41:27: E231 missing whitespace after ','
> install_venv.py:73:57: W291 trailing whitespace

[Justin Shepherd (jshepher)]

So i redid the srcfiles line in run_tests.sh, now it is importing the following files for pep8 tests:

tools/esx/guest_tool.py
tools/euca-get-ajax-console
tools/install_venv.py

-----

fixing all pep8 violations in tools/install_venv.py, then will propose for merge.

[Vish Ishaya (vishvananda)]

Fix committed is for when the merge hits trunk.
On May 16, 2011, at 9:18 AM, Justin Shepherd wrote:

> ** Changed in: nova
> Status: Incomplete => Fix Committed
>
> --
> You received this bug notification because you are a member of Nova Bug
> Team, which is subscribed to OpenStack Compute (nova).
> https://bugs.launchpad.net/bugs/781429
>
> Title:
> pep8 issues in the tools directory
>
> Status in OpenStack Compute (Nova):
> Fix Committed
>
> Bug description:
> Looks like the python files under the tools directory aren't being
> checked for pep8 compliance. We should probably add tools/*.py to the
> pep8 check and fix the current failures:
>
> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
> install_venv.py:33:13: E225 missing whitespace around operator
> install_venv.py:34:80: E501 line too long (81 characters)
> install_venv.py:36:1: E302 expected 2 blank lines, found 1
> install_venv.py:37:3: E111 indentation is not a multiple of four
> install_venv.py:41:27: E231 missing whitespace after ','
> install_venv.py:73:57: W291 trailing whitespace

[Justin Shepherd (jshepher)]

sorry.. I thought that was fix released
On May 16, 2011, at 11:36 AM, Vish Ishaya wrote:

> Fix committed is for when the merge hits trunk.
> On May 16, 2011, at 9:18 AM, Justin Shepherd wrote:
>
>> ** Changed in: nova
>> Status: Incomplete => Fix Committed
>>
>> --
>> You received this bug notification because you are a member of Nova Bug
>> Team, which is subscribed to OpenStack Compute (nova).
>> https://bugs.launchpad.net/bugs/781429
>>
>> Title:
>> pep8 issues in the tools directory
>>
>> Status in OpenStack Compute (Nova):
>> Fix Committed
>>
>> Bug description:
>> Looks like the python files under the tools directory aren't being
>> checked for pep8 compliance. We should probably add tools/*.py to the
>> pep8 check and fix the current failures:
>>
>> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
>> install_venv.py:33:13: E225 missing whitespace around operator
>> install_venv.py:34:80: E501 line too long (81 characters)
>> install_venv.py:36:1: E302 expected 2 blank lines, found 1
>> install_venv.py:37:3: E111 indentation is not a multiple of four
>> install_venv.py:41:27: E231 missing whitespace after ','
>> install_venv.py:73:57: W291 trailing whitespace
>
>
> ** Changed in: nova
> Status: Fix Committed => In Progress
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/781429
>
> Title:
> pep8 issues in the tools directory
>
> Status in OpenStack Compute (Nova):
> In Progress
>
> Bug description:
> Looks like the python files under the tools directory aren't being
> checked for pep8 compliance. We should probably add tools/*.py to the
> pep8 check and fix the current failures:
>
> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
> install_venv.py:33:13: E225 missing whitespace around operator
> install_venv.py:34:80: E501 line too long (81 characters)
> install_venv.py:36:1: E302 expected 2 blank lines, found 1
> install_venv.py:37:3: E111 indentation is not a multiple of four
> install_venv.py:41:27: E231 missing whitespace after ','
> install_venv.py:73:57: W291 trailing whitespace

Confidentiality Notice: This e-mail message (including any attached or
embedded documents) is intended for the exclusive and confidential use of the
individual or entity to which this message is addressed, and unless otherwise
expressly indicated, is confidential and privileged information of Rackspace.
Any dissemination, distribution or copying of the enclosed material is prohibited.
If you receive this transmission in error, please notify us immediately by e-mail
at <email address hidden>, and delete the original message.
Your cooperation is appreciated.

[Vish Ishaya (vishvananda)]

No problem, it isn't completely obvious how they should be used, so we've adopted the following guidelines:
Fixed Committed is for when the fix hits trunk (this is done automatically by the automatic merge)
Fixed Released is for when the the fix is part of an official release (this is set by the release manager)

So essentially you should just have to mark the bug In Progress, link the branch, and propose the branch for merging.

Vish

On May 16, 2011, at 9:47 AM, Justin Shepherd wrote:

> sorry.. I thought that was fix released
> On May 16, 2011, at 11:36 AM, Vish Ishaya wrote:
>
>> Fix committed is for when the merge hits trunk.
>> On May 16, 2011, at 9:18 AM, Justin Shepherd wrote:
>>
>>> ** Changed in: nova
>>> Status: Incomplete => Fix Committed
>>>
>>> --
>>> You received this bug notification because you are a member of Nova Bug
>>> Team, which is subscribed to OpenStack Compute (nova).
>>> https://bugs.launchpad.net/bugs/781429
>>>
>>> Title:
>>> pep8 issues in the tools directory
>>>
>>> Status in OpenStack Compute (Nova):
>>> Fix Committed
>>>
>>> Bug description:
>>> Looks like the python files under the tools directory aren't being
>>> checked for pep8 compliance. We should probably add tools/*.py to the
>>> pep8 check and fix the current failures:
>>>
>>> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
>>> install_venv.py:33:13: E225 missing whitespace around operator
>>> install_venv.py:34:80: E501 line too long (81 characters)
>>> install_venv.py:36:1: E302 expected 2 blank lines, found 1
>>> install_venv.py:37:3: E111 indentation is not a multiple of four
>>> install_venv.py:41:27: E231 missing whitespace after ','
>>> install_venv.py:73:57: W291 trailing whitespace
>>
>>
>> ** Changed in: nova
>> Status: Fix Committed => In Progress
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/781429
>>
>> Title:
>> pep8 issues in the tools directory
>>
>> Status in OpenStack Compute (Nova):
>> In Progress
>>
>> Bug description:
>> Looks like the python files under the tools directory aren't being
>> checked for pep8 compliance. We should probably add tools/*.py to the
>> pep8 check and fix the current failures:
>>
>> Rick-Harriss-MacBook-Pro:tools rick$ pep8 install_venv.py
>> install_venv.py:33:13: E225 missing whitespace around operator
>> install_venv.py:34:80: E501 line too long (81 characters)
>> install_venv.py:36:1: E302 expected 2 blank lines, found 1
>> install_venv.py:37:3: E111 indentation is not a multiple of four
>> install_venv.py:41:27: E231 missing whitespace after ','
>> install_venv.py:73:57: W291 trailing whitespace
>
>
> Confidentiality Notice: This e-mail message (including any attached or
> embedded documents) is intended for the exclusive and confidential use of the
> individual or entity to which this message is addressed, and unless otherwise
> expressly indicated, is confidential and privileged information of Rackspace.
> Any dissemination, distribution or copying of the enclosed material is prohibited.
> If you receive this transmission in error, please notify us immediately by e-mail
> at <email address hidden>...

[Thierry Carrez (ttx)]

Details at: http://wiki.openstack.org/BugsLifecycle

You should also use: bzr commit -m "your comment" --fixes lp:781429
so that the bug is automatically FixCommitted when the fix hits trunk.