Highlighted tags become non-highlighted after search

[vovkkk]

Steps to reproduce:
1. Choose one or a few tags
2. Type something in search box
3.1 Clear search box
or
3.2 Choose new tags and clear search box
Result: Tags are not highlighted.

Expected: Current tag(s) is/are always highlighted.

Version: 0.2.09-daily~r57~natty1

[filipe (hikibi)]

That's an old one, it's basically the same as the one where while the library is building, although you can select tags, they don't get highlighted.
It's due to the fact that the widget identifies the tags by their positions, instead of their names, and the positions change either when the library is updated or there is a search...
I haven't fixed that one yet partly because I'm lazy, partly because fixing it could significantly slow TagPlayer down during library builds.
Still, I can't postpone it forever so I'll work on it.

Again, thanks for the bug report!

[filipe (hikibi)]

Ok, I have done this but as I feared the interface's responsiveness suffers (quite significantly for large libraries).
I'll keep this change, but if the performance hit is too much of a nuisance in usability, file it as a separate bug and I'll try to think of another solution.

[vovkkk (vovkkk)]

I've test it on about 1000 songs, and that's okay.
Tomorrow I'll test it on about 6000 songs (yeah, not so much, but that's all I have), we'll see.

But I face with another issue: a song is switched to another one when I clear search box — it happens always.
And it happens sometimes when I begin typing in search box.
Tags remain highlighted though.
There is nothing in terminal.

[filipe (hikibi)]

While fixing the first bug I exposed the other... it's fixed now