pyClamd 0.1.1 doesn't work with Python 2.6

[Brendan Long]

Binary package hint: python-pyclamd

The version of pyClamd included in Ubuntu 10.04 uses old-style Python exceptions (raise ExceptionType, string), but Python 2.6 won't allow that:

Python 2.6.5 (r265:79063, Apr 16 2010, 13:57:41)
[GCC 4.4.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyclamd
>>> pyclamd.init_unix_socket("/var/run/clamav/clamd.ctl")
>>> pyclamd.scan_file("cats")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/pymodules/python2.6/pyclamd.py", line 286, in scan_file
    raise ScanError, virusname
TypeError: exceptions must be old-style classes or derived from BaseException, not str

It works fine in version 2.2 (latest). As it stands now, the module is completely unusable.

[Stefano Rivera (stefanor)]

This was fixed in 0.1.1-2, which is in maverick. I suppose it's probably worth preparing a fix for Lucid.

Would you prepare instructions on testing the bug? I.e. minimal instructions for triggering it, expected and unexpected (broken) responses.

https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

[Brendan Long (korin43)]

To test, install python-pyclamd and clamav-daemon:

$ sudo aptitude install python-pyclamd clamav-daemon

Update the virus definition database (to make sure you have one):

$ sudo -u clamav freshclam

Then do anything that would make it raise an exception:

$ python
>>> import pyclamd
>>> pyclamd.init_unix_socket("/var/run/clamav/clamd.ctl")
>>> pyclamd.scan_file("file_that_doesnt_exist")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/pymodules/python2.6/pyclamd.py", line 350, in scan_file
    raise ScanError(reason)
pyclamd.ScanError: lstat() failed: No such file or directory.

The above output is correct (raising a ScanError). On 1.1, you get this instead:

>>> import pyclamd
>>> pyclamd.init_unix_socket("/var/run/clamav/clamd.ctl")
>>> pyclamd.scan_file("file_that_doesnt_exist")
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/pymodules/python2.6/pyclamd.py", line 286, in scan_file
    raise ScanError, virusname
TypeError: exceptions must be old-style classes or derived from BaseException, not str

[Stefano Rivera (stefanor)]

Hi, sorry I haven't got to this in a couple of weeks, it's been an open tab forever.
I'll try and get to it soon, but this is also an issue that is easy to fix and suitable
for newcomers in Ubuntu development.

If anyone needs any help with fixing it, talk to me (https://launchpad.net/~stefanor) about it.

[Stefano Rivera (stefanor)]

Right, got to it. Uploaded to lucid-proposed, pending SRU team review.

[Martin Pitt (pitti)]

Accepted pyclamd into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Brendan Long (korin43)]

Looks good to me. The script I posted above, and my actual program both work now. Thanks for the help.

[Jean-Baptiste Lallement (jibel)]

Thanks for testing. Marking as verification-done

[Launchpad Janitor (janitor)]

This bug was fixed in the package pyclamd - 0.1.1-1ubuntu0.1

---------------
pyclamd (0.1.1-1ubuntu0.1) lucid-proposed; urgency=low

  * Change exceptions from strings to classes, for python 2.6 compatibility.
    Patch from 0.1.1-2. (LP: #771955)
 -- Stefano Rivera <email address hidden> Fri, 20 May 2011 18:45:41 +0200