deprecated DBUS interfaces are not marked as deprecated
Bug #770269 reported by
Harald Sitter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Single Sign On Client |
Fix Released
|
Medium
|
Natalia Bidart | ||
ubuntu-sso-client (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart |
Bug Description
Binary package hint: ubuntu-sso-client
<apachelogger> nessita: the dbus stuff in /credentials is deprecated?
<nessita> apachelogger: yes sir [...]
Test:
me@avatar:~/tmp$ qdbus com.ubuntu.sso /credentials org.freedesktop
me@avatar:~/tmp$
Expected:
org.freedesktop
Resources:
http://
Related branches
lp:~nataliabidart/ubuntu-sso-client/add-more-deprecation-messages
- Eric Casteleijn (community): Approve
- Shane Fagan (community): Approve
-
Diff: 46 lines (+11/-2)2 files modifiedrun-tests (+2/-1)
ubuntu_sso/main/linux.py (+9/-1)
Changed in ubuntu-sso-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-sso-client: | |
milestone: | none → 1.3.1 |
Changed in ubuntu-sso-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
As per alecu's digging into python-dbus, we can't add annotations to our dbus APIs.
The documentation at https:/ /wiki.ubuntu. com/SingleSignO n/UbuntuSsoClie nt explicitly states that the /credentials service is deprecated. sso/__init_ _.py):
Also, the source code for the DBus constants shows this deprecations (from ubuntu_
20 DBUS_PATH = "/sso" # deprecated!
21 DBUS_CRED_PATH = "/credentials" # deprecated!
I will propose a branch to add more deprecation comments/docstring to the source code, but for now there is not much else we can do at DBus level.