Deleting brick while active hangs up the menu

[Daniele Lacamera]

Deleting brick while active shows up an error message, but after that it hangs up the menu and vb has to be killed. :(

[Abbakus (abbakus)]

Fixed on r246.

Calling "self.error("...")" inside an event handler seems to hang VB. Solved using "self.show_error("...")" (in my opinion it's better to show a GUI message instead of a console one).

[Francesco Apollonio (lorddex)]

modified in r254

[Abbakus (abbakus)]

Modified again. Who did add threads_enter/leave around show_error? And why?!
Removed threads_enter/leave on rev. 264
                gtk.gdk.threads_enter()
                try:
                        self.show_error(text)
                finally:
                        gtk.gdk.threads_leave()

Here threads_enter/leave hangs GUI every time an error is showed while works correctly without.

[Francesco Apollonio (lorddex)]

2011/5/4 Abbakus <email address hidden>:
> Modified again. Who did add threads_enter/leave around show_error? And why?!
> Removed threads_enter/leave on rev. 264
>                gtk.gdk.threads_enter()
>                try:
>                        self.show_error(text)
>                finally:
>                        gtk.gdk.threads_leave()
>
> Here threads_enter/leave hangs GUI every time an error is showed while
> works correctly without.

using show_error instead of error or error without this code block
doesn't work well.
Why do you re-comment this code block? Have you noticed again the
freeze on brick delete or another related bug?

Francesco

[Abbakus (abbakus)]

Well, once upon a time was uncommented. :-) Then I commented. Then you
decommented. Now I commented again (give up, I will win :-D )

->Commented works perfectly for me.
->Uncommented hangs systematically for me (for example when I enable
KVM checkbox on preferences window. I don't have KVM so a message pops
out to alert me).

Having two gtk.gdk.threads_enter() nested hangs for sure I think (the
first gtk.gdk.threads_enter()/leave() is around gtk.main() ).

2011/5/4, Francesco Apollonio <email address hidden>:
> 2011/5/4 Abbakus <email address hidden>:
>> Modified again. Who did add threads_enter/leave around show_error? And
>> why?!
>> Removed threads_enter/leave on rev. 264
>>                gtk.gdk.threads_enter()
>>                try:
>>                        self.show_error(text)
>>                finally:
>>                        gtk.gdk.threads_leave()
>>
>> Here threads_enter/leave hangs GUI every time an error is showed while
>> works correctly without.
>
> using show_error instead of error or error without this code block
> doesn't work well.
> Why do you re-comment this code block? Have you noticed again the
> freeze on brick delete or another related bug?
>
> Francesco
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/764739
>
> Title:
> Deleting brick while active hangs up the menu
>
> Status in Virtualbricks:
> Fix Committed
>
> Bug description:
> Deleting brick while active shows up an error message, but after that
> it hangs up the menu and vb has to be killed. :(
>

--
                       Simone