OpenStack Compute (nova)

VMwareAPIConnection class should inherit ComputeDriver class

Bug #758810 reported by Sateesh on 2011-04-12

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	OpenStack Compute (nova)	Fix Released	High	Vish Ishaya	OpenStack Compute (nova) 2011.2 "cactus"

Bug Description

Due to the fixes committed to nova trunk for the bugs 661214 and 661260 VMwareAPIConnection class should be modified to inherit from driver.ComputeDriver class in a similar manner to the changes done to XenAPIConnection class.

Just before the bug fixes for 661214 & 661260 went in the branch vmware-vsphere-support has gone in which has resulted in this inconsistency.

Fix would be to incorporate the changes (inherit the connection class from driver.ComputeDriver) to VMwareAPIConnection class as well in nova/virt/vmwareapi_conn.py. Without these changes vmwareapi module cannot be loaded and nova can't support VMware ESX/vSphere hypervisor.

Related branches

lp:~vishvananda/nova/lp758810

Merged into lp:~hudson-openstack/nova/trunk at revision 983

Devin Carlen (community): Approve on 2011-04-12

Jay Pipes (community): Approve on 2011-04-12

termie (community): Approve on 2011-04-12

Revision history for this message

Sateesh (sateesh-chodapuneedi) wrote on 2011-04-12:

The class VMwareAPIConnection now inherits driver.ComputeDriver class Edit (14.9 KiB, text/x-python)

Patch for bug #758810.
Resolved the breakage of VMware connection class.

Revision history for this message

Sateesh (sateesh-chodapuneedi) wrote on 2011-04-12:

Patch for bug #758810 Edit (1.5 KiB, text/plain)

Patch for bug #758810

Revision history for this message

Sateesh (sateesh-chodapuneedi) wrote on 2011-04-12:

Patch for bug #758810 Edit (1.1 KiB, text/plain)

Patch for bug #758810
The patch file shows the diffs from trunk version 980 for file nova/virt/vmwareapi_conn.py

Revision history for this message

Thierry Carrez (ttx) wrote on 2011-04-12:

@Sateesh: how functional is VMware support without this fix ? Completely broken ?

Changed in nova:
importance:	Undecided → High
status:	New → Confirmed

Thierry Carrez (ttx) on 2011-04-12

Changed in nova:
milestone:	none → cactus-rc

Vish Ishaya (vishvananda) on 2011-04-12

Changed in nova:
assignee:	nobody → Vish Ishaya (vishvananda)

Revision history for this message

Sateesh (sateesh-chodapuneedi) wrote on 2011-04-12:

@Thierry: Yes, without this fix for this bug the VMware support is braken. The nova-compute service wouldn't be able to talk to VMware ESX server.
I will create a branch for the fix and will propose it for merge into trunk.

OpenStack Infra (hudson-openstack) on 2011-04-12

Changed in nova:
status:	Confirmed → Fix Committed

Revision history for this message

Vish Ishaya (vishvananda) wrote on 2011-04-12: Re: [Bug 758810] Re: VMwareAPIConnection class should inherit ComputeDriver class

Sateesh. I already did
On Apr 12, 2011 4:55 PM, "Sateesh" <email address hidden> wrote:
> @Thierry: Yes, without this fix for this bug the VMware support is braken.
The nova-compute service wouldn't be able to talk to VMware ESX server.
> I will create a branch for the fix and will propose it for merge into
trunk.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/758810
>
> Title:
> VMwareAPIConnection class should inherit ComputeDriver class
>
> Status in OpenStack Compute (Nova):
> Confirmed
>
> Bug description:
> Due to the fixes committed to nova trunk for the bugs 661214 and
> 661260 VMwareAPIConnection class should be modified to inherit from
> driver.ComputeDriver class in a similar manner to the changes done to
> XenAPIConnection class.
>
> Just before the bug fixes for 661214 & 661260 went in the branch
> vmware-vsphere-support has gone in which has resulted in this
> inconsistency.
>
> Fix would be to incorporate the changes (inherit the connection class
> from driver.ComputeDriver) to VMwareAPIConnection class as well in
> nova/virt/vmwareapi_conn.py. Without these changes vmwareapi module
> cannot be loaded and nova can't support VMware ESX/vSphere hypervisor.