SRU: remove /.hidden file

[Luka Renko]

Binary package hint: kubuntu-default-settings

Kubuntu Edgy has introduced new "feature": by default, all directories in / are hidden, beside /home and /media. Main reason was to hide stuff that would typically not be needed by typical user. This was implemented as part of media:/ simplifications (media:/ was major issue in dapper).

More details:
https://wiki.ubuntu.com/KubuntuKDEMedia
https://wiki.ubuntu.com/KubuntuHiddenFiles

During the beta cycles, there was no complaints that this might be an issue (or people were willing to accept this "simplification"), but after the release of Edgy, when most of existing Kubuntu user base has upgraded, we were faced by several bugs (bug 68719, bug 67582, bug 67314) and several heated discussions on IRC and Ubuntu mailing list:
https://lists.ubuntu.com/archives/kubuntu-users/2006-October/010173.html
https://lists.ubuntu.com/archives/kubuntu-users/2006-October/010191.html
https://lists.ubuntu.com/archives/kubuntu-users/2006-November/010842.html
https://lists.ubuntu.com/archives/kubuntu-users/2006-November/010852.html
https://lists.ubuntu.com/archives/kubuntu-users/2006-November/010498.html
https://lists.ubuntu.com/archives/ubuntu-devel/2006-October/021460.html

Note: this also impacts GNOME users with kubuntu-desktop installed as GNOME file dialogs/browser also respect .hidden file.

Since we had Celeste Lyn Paul from KDE Usability on UDS MtView, this feature was reviewed again and it was decided that hiding files in / is really not so good idea, as it may confuse current Linux users as well as complicate support for new Linux users. For example when users are asked by bug triage/support/irc to provide some file from /etc or /var/log and they cannot browse there with Konqueror or regular file open dialog (to attach the file).
This is why it was decided that the "feature" should be dropped for Feisty (and is already in Feisty):
https://wiki.ubuntu.com/KubuntuFeistyDefaultSettingsReview

Since we still get new complaints from Edgy users, we have discussed this on Kubuntu meeting on Dec 7 and it was agreed it would make sense to backport this to Edgy. This "bug" may not be seen immediately as complying with requirements set in StableReleaseUpdates, but we think that it is seen as severe regression by our users (even though that workarounds exists) and complicates support.

[Luka Renko (lure)]

This patch changes k-d-s to not install /etc/kubuntu-default-settings/hidden-root anymore and removes /.hidden symbolic link in case it points to hidden-root file.

I have tested this on up-to-date Kubuntu Edgy i386 and have simulated different combinations of /.hidden file:
- /.hidden does not exist
- /.hidden is symbolic link, but points elsewhere
- /.hidden is regular file
- /.hidden points to /etc/kubuntu-default-settings/hidden-root

Only last case removes /.hidden symbolic link and gives user back pre-edgy state.

[Jonathan Riddell (jr)]

I support this.

[Martin Pitt (pitti)]

Please fix this in Feisty first (bug task must be 'fix released' for an SRU request).

About the patch:
- Please fix changelog to say edgy-proposed
- Please also remove the now obsolete comment in the postinst to avoid confusion
- Why is the Makefile change necessary? Having the hidden-root installed in the system certainly does not hurt, and people might still want to use/symlink to it.

[Luka Renko (lure)]

Feisty has this fix from Herd1. Marking Fix Released.

Will update the debdiff this evening.
Makefile change is there to match what is done for Feisty (where this file was also removed).

[Anthony Mercatante (tonio)]

Attached fixed debdiff.
Martin, we let the comment since it is not obsolete, as we continue to hide /media datas.

[Martin Pitt (pitti)]

Patch looks good. Please upload and set to 'in progress'.

[Anthony Mercatante (tonio)]

Uploaded

[Luka Renko (lure)]

Marking Edgy task as In Progress (Feisty is already released)

[Martin Pitt (pitti)]

Accepted into edgy-proposed, please go ahead with QA testing.

[StefanPotyra (sistpoty)]

Maybe you should also delete the snippet from postrm/purge. However this would be just a corner-case (setting the link by hand and then purging the new package).

[Alex (dacpkbeast)]

seems to have worked for me, I had already edited my /etc/kubuntu-default-settings/hidden-root and /etc/kubuntu-default-settings/hidden-media so I could see everything, those were left unchanged but it looks like the links are gone. Also double checked by commenting some of the hidden folders back in and nothing changed so it looks like all is good!

[Tom Shaw (firephoto)]

I updated kubuntu-default-settings, all the root directories are visible now. I hadn't modified any of the .hidden items so all was default in that regard.

Seems ok.

[Scott Kitterman (kitterman)]

Works as advertized for me.

[Michael Vogt (mvo)]

Thanks for your update.

Please include instructions how to reproduce the bug. The policy says:
"Detailled instructions how to reproduce the bug.- These should allow someone who is not familiar with the affected package to reproduce the bug and verify that the updated package fixes the problem."

I will be happy to do the verification once I have those instructions.

Thanks,
 Michael

[Martin Pitt (pitti)]

Three confirmations that the -proposed package works, I think that's sufficient. Copied to edgy-updates.