Dash - Selecting any of the Search Filters in the App Lens should show all matching apps underneath the 'Apps available to download' category header, even if the user has not typed a search term

Bug #745834 reported by John Lea
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ayatana Design
Fix Committed
High
John Lea
unity-lens-applications
Fix Released
High
Unassigned
unity-lens-applications (Ubuntu)
Fix Released
High
Unassigned

Bug Description

Selecting any of the Search Filters in the App Lens should show all matching apps underneath the 'Apps available to download' category header, even if the user has not typed a search term.

Currently if the user has not typed any search term, only a few apps are shown in this category after the user selects one or more search filters and this is wrong. All apps in the software centre that match the selected filtering should be shown.

John Lea (johnlea)
Changed in ayatana-design:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → John Lea (johnlea)
tags: added: udt
David Barth (dbarth)
Changed in unity:
status: New → Triaged
Revision history for this message
David Barth (dbarth) wrote :

This is fixed in the daily build i'm running, but I will let Mikkel or Neil confirm it's properly implemented the way it's defined here.

Changed in unity:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → Low
milestone: none → 3.8.2
tags: added: ffe
Revision history for this message
Florian Boucault (fboucault) wrote :

@David: what was the patch/bzr revision that fixed the issue? Is there any action to be taken in Unity 2D?

Changed in unity-2d:
milestone: none → 3.8.2
John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Fix Released
Changed in unity-2d:
status: New → Invalid
milestone: 3.8.2 → none
Changed in unity (Ubuntu):
status: New → Triaged
John Lea (johnlea)
summary: - Dash File Lens - After selecting a filter category or typing a text
+ Dash App Lens - After selecting a filter category or typing a text
search, the 'Apps available to download' category header should offer
the option to "See XX more results"
description: updated
summary: - Dash App Lens - After selecting a filter category or typing a text
- search, the 'Apps available to download' category header should offer
- the option to "See XX more results"
+ Dash App Lens - After selecting a filter category, the 'Apps available
+ to download' category header should offer the option to "See XX more
+ results"
description: updated
Changed in ayatana-design:
importance: High → Medium
tags: added: udo
Jason Smith (jassmith)
Changed in unity:
milestone: 3.8.2 → ux-backlog-1
assignee: Mikkel Kamstrup Erlandsen (kamstrup) → Neil J. Patel (njpatel)
Jorge Castro (jorge)
Changed in unity:
milestone: ux-backlog-1 → backlog
assignee: Neil J. Patel (njpatel) → Unity Community Hackers (unity-community-hackers)
Jorge Castro (jorge)
tags: added: backlog
John Lea (johnlea)
tags: added: udp
Changed in ayatana-design:
status: Fix Released → Fix Committed
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote : Re: Dash App Lens - After selecting a filter category, the 'Apps available to download' category header should offer the option to "See XX more results"

We need some clarification on this: Does this also apply when the All filter is selected? That is - listing > 3k apps in a grid? Also I wouldn't be surprised if fx. Games or Accessories contains > 500 apps. Is the intention to just list them all?

Revision history for this message
John Lea (johnlea) wrote :

@kamstrup; ideally this would also apply when the All filter is selected, but I understand this might not be doable for performance reasons.

Also yes, the intention is to list all the available apps that match the selected filter(s).

John Lea (johnlea)
Changed in ayatana-design:
status: Fix Committed → Triaged
John Lea (johnlea)
Changed in unity:
assignee: Unity Community Hackers (unity-community-hackers) → nobody
Mirco Müller (macslow)
Changed in unity:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
John Lea (johnlea)
Changed in ayatana-design:
status: Triaged → Fix Committed
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Ok. Let's try this early in the cycle and see what works.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

I pushed up lp:~kamstrup/unity-lens-applications/list-all-avail-apps with the requested feature. It does seem to cause quite some stuttering when searching. I'll try it on my el-cheapo netbook in a sec.

At this point I am not sure where or what causes the stuttering so it needs some profiling.

Oh! I also just remembered why we disabled back in ye olden days...It was because the intel i915 driver ran out of texture memory when showing > 1000 icons. Don't know if this is fixed (or even fixable?) :-/

Changed in unity-lens-applications:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Just checked in Unity2d - it seems it must be doing some sync io or something because the whole screen locks up ~2s as it tries to render the thousands of icons.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

On my Eee 1001 netbook the prospects of getting this running at an acceptable rate are grim I am afraid... In Unity2d going from showing all available apps to showing all available games takes maybe 30s. It takes maybe 10s in Unity3d so also quite bad there...

(note: the actual searching, sorting, and listing takes ~1s for all apps, and ~50ms if it's just the games. the overhead lies somewhere in marshalling the result across dbus to unity and/or the rendering of the results (for u2d the vast portion is obviously the rendering))

Revision history for this message
Michał Sawicz (saviq) wrote :

Just to clarify: QML only renders what's currently on (or near on) screen, and you can see the result with the gwibber lens. Going from 3 to ~1k results takes a fraction of a second here. Loading the lens, on the other hand, takes some 3s, maybe.

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Ok, maybe "rendering" was technically the wrong word - but it appears that we have a ~20s overhead inside Qt somewhere then :-)

I think Kaleo talked about some unfortunate interactions between how DeeModels are updated with how Qt expects models to behave. Maybe that's it... I am certain he filed a bug against Dee back in the day, but I can't dig it out for the life of me!

John Lea (johnlea)
summary: - Dash App Lens - After selecting a filter category, the 'Apps available
- to download' category header should offer the option to "See XX more
- results"
+ Dash - Selecting any of the Search Filters in the App Lens should show
+ all matching apps underneath the 'Apps available to download' category
+ header, even if the user has not typed a search term
description: updated
Changed in unity:
importance: Low → Medium
Changed in ayatana-design:
importance: Medium → High
Changed in unity-lens-applications:
importance: Undecided → High
Changed in unity (Ubuntu):
importance: Undecided → High
Changed in unity-lens-applications (Ubuntu):
importance: Undecided → High
status: New → Triaged
Changed in unity-lens-applications:
status: New → Triaged
assignee: Mikkel Kamstrup Erlandsen (kamstrup) → nobody
Changed in unity:
assignee: Mikkel Kamstrup Erlandsen (kamstrup) → nobody
importance: Medium → High
tags: added: dashm dashs
Will Cooke (willcooke)
tags: added: rls-w-incoming
Changed in unity-lens-applications (Ubuntu):
status: Triaged → Fix Released
Changed in unity (Ubuntu):
status: Triaged → Won't Fix
no longer affects: unity (Ubuntu)
Changed in unity-lens-applications:
status: Triaged → Fix Released
no longer affects: unity-2d
no longer affects: unity
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.