Claims to have succeeded when it failed

Bug #745133 reported by Scott Kitterman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
kubuntu-notification-helper (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: kubuntu-notification-helper

See the attached screenshot. Multiverse was disabled when I did this, so the attempt to install Flash totally failed.

Revision history for this message
Scott Kitterman (kitterman) wrote :
Revision history for this message
Jonathan Thomas (echidnaman) wrote :

I think what this was was that install-package or qapt-batch didn't support returning 1 when they exited with failure, so we had to assume that things worked. Now qapt-batch does return 1 when it exits upon failure, so this won't be too hard of a fix for oneiric.

Changed in kubuntu-notification-helper (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in kubuntu-notification-helper (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package kubuntu-notification-helper - 11.10ubuntu1

---------------
kubuntu-notification-helper (11.10ubuntu1) oneiric; urgency=low

  [ Jonathan Thomas ]
  * Check the result of QApt Batch in InstallEvent before we triumphantly
    declare success. (LP: #745133)
  * Make sure to initialize the KStatusNotifierItem object's pointer with 0,
    otherwise crashes will occur when trying to delete it due to the undefinied
    behavior of accessing an un-initialized pointer. Fixes a crash that occurs
    when k-n-h is configured to show only popup icons. (LP: #780718)
  * Use HIG-compliant labels for radio buttons. (No double negatives)

  [ Harald Sitter ]
  * Properly KProcess DisplayIf hook conditions as shell commands.
    Trying to evaluate a complex expression as program will make the process
    die and return as zombie! OMG! (LP: #515138)
  * If a hook is not valid and a notification is not required schedule the
    hook for deletion via event loop to save memory.
  * Use QLatin1String when useful in HookEvent
  * In unused distupgradevent do not leak KProcess on availability checks.
  * Nice fact about KProcess... when starting detached you can actually
    throw away the KProcess right away (or reuse it). Consequently do not
    heap the KProcess for terminal Hook invocation, but keep it on the stack.
  * Bump standards version to 3.9.2
 -- Harald Sitter <email address hidden> Sun, 25 Sep 2011 20:10:33 +0200

Changed in kubuntu-notification-helper (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.