The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3

[Aaron Z]

The folders in the reporting tool are not sorted.
Found on 1.6.0.8. Also found on 2.0.3 on the acq.open-ils.org server.
On the acq.open-ils.org server I logged in as admin and created the following folders as subfolders of the "Output" folder in the following order: 1Test, 0Test, 3Test, 2Test

When I expanded the "Output" folder, they were there in the order they were created in.
I then renamed the 1Test folder XTest and the 3Test folder _Test and they were moved to have the last edited folder on the bottom.

Per dbs: [16:11] dbs: AaronZ-PLS: Yeah, there's no order by attribute in open-ils.reporter.folder.visible.retrieve method - would make a good bitesize bug

Request: Change the open-ils.reporter.folder.visible.retrieve method to order the folders by the folder name

[Michael Peters (mrpeters)]

AaronZ,

Please give the attached patch for Reporter.pm a try. It's working for me, as best I can tell!

I'm not a Perl expert, but I kind of stole the sort method from another section in the code and told it to sort on 'name" rather than "create_date".

-Mike

[Michael Peters (mrpeters)]

An aside to this...I find that this for whatever reason does not order the "Shared" items alphabetically by name. I'm not sure why.

Maybe someone can give us a hint on that?

[Aaron Z (aaronz)]

So, if a folder is shared, this patch does not cause it to be sorted it by name?

Aaron Z

----- "Michael Peters" <email address hidden> wrote:

> From: "Michael Peters" <email address hidden>
> To: <email address hidden>
> Sent: Wednesday, June 1, 2011 9:55:33 AM GMT -05:00 US/Canada Eastern
> Subject: [Bug 740466] Re: The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3
>
> An aside to this...I find that this for whatever reason does not
> order
> the "Shared" items alphabetically by name. I'm not sure why.
>
> Maybe someone can give us a hint on that?
>
> --
> You received this bug notification because you are a direct
> subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/740466
>
> Title:
> The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> The folders in the reporting tool are not sorted.
> Found on 1.6.0.8. Also found on 2.0.3 on the acq.open-ils.org
> server.
> On the acq.open-ils.org server I logged in as admin and created the
> following folders as subfolders of the "Output" folder in the
> following order: 1Test, 0Test, 3Test, 2Test
>
> When I expanded the "Output" folder, they were there in the order
> they were created in.
> I then renamed the 1Test folder XTest and the 3Test folder _Test and
> they were moved to have the last edited folder on the bottom.
>
> Per dbs: [16:11] dbs: AaronZ-PLS: Yeah, there's no order by
> attribute in open-ils.reporter.folder.visible.retrieve method -
> would
> make a good bitesize bug
>
> Request: Change the open-ils.reporter.folder.visible.retrieve
> method
> to order the folders by the folder name
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/evergreen/+bug/740466/+subscribe

[Michael Peters (mrpeters)]

Aaron,

Folders you own ("top" interface) sort properly.

Folders under "shared" don't seem to.

Sincerely,
Michael Peters
Indiana State Library MIS | Inspire.IN.gov Helpdesk | Evergreen Indiana Helpdesk
office - 317.234.2128
email - <email address hidden>

-----Original Message-----
From: <email address hidden> [mailto:<email address hidden>] On Behalf Of Aaron Z
Sent: Wednesday, June 01, 2011 10:10 AM
To: Peters, Michael
Subject: Re: [Bug 740466] Re: The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3

So, if a folder is shared, this patch does not cause it to be sorted it
by name?

Aaron Z

----- "Michael Peters" <email address hidden> wrote:

> From: "Michael Peters" <email address hidden>
> To: <email address hidden>
> Sent: Wednesday, June 1, 2011 9:55:33 AM GMT -05:00 US/Canada Eastern
> Subject: [Bug 740466] Re: The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3
>
> An aside to this...I find that this for whatever reason does not
> order
> the "Shared" items alphabetically by name. I'm not sure why.
>
> Maybe someone can give us a hint on that?
>
> --
> You received this bug notification because you are a direct
> subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/740466
>
> Title:
> The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3
>
> Status in Evergreen - Open ILS:
> New
>
> Bug description:
> The folders in the reporting tool are not sorted.
> Found on 1.6.0.8. Also found on 2.0.3 on the acq.open-ils.org
> server.
> On the acq.open-ils.org server I logged in as admin and created the
> following folders as subfolders of the "Output" folder in the
> following order: 1Test, 0Test, 3Test, 2Test
>
> When I expanded the "Output" folder, they were there in the order
> they were created in.
> I then renamed the 1Test folder XTest and the 3Test folder _Test and
> they were moved to have the last edited folder on the bottom.
>
> Per dbs: [16:11] dbs: AaronZ-PLS: Yeah, there's no order by
> attribute in open-ils.reporter.folder.visible.retrieve method -
> would
> make a good bitesize bug
>
> Request: Change the open-ils.reporter.folder.visible.retrieve
> method
> to order the folders by the folder name
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/evergreen/+bug/740466/+subscribe

--
You received this bug notification because you are a direct subscriber
of the bug.
https://bugs.launchpad.net/bugs/740466

Title:
  The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3

Status in Evergreen - Open ILS:
  Confirmed

Bug description:
  The folders in the reporting tool are not sorted.
  Found on 1.6.0.8. Also found on 2.0.3 on the acq.open-ils.org server.
  On the acq.open-ils.org server I logged in as admin and created the following folders as subfolders of the "Output" folder in the following order: 1Test, 0Test, 3Test, 2Test

  When I expanded the "Output" folder, they were there in the order they were created in.
  I then renamed the 1Test folder XTest and the 3Test folder _Test and they were moved to have the last edited ...

[Michael Peters (mrpeters)]

I must caution against using this patch, AaronZ. I've found that whatever it is in my code REALLY breaks report sharing badly. For some reason, now any report folder that are shared and have subfolders within them no longer appear in the Shared Folders.

I gave this my best effort but maybe its not so "bitesize" afterall.

-Mike

[Aaron Z (aaronz)]

The code in the patch works properly on our test server (running 1.6.2.4).

Aaron Z

[Aaron Z (aaronz)]

I created some test folders as admin and they were sorted by name when I logged in as another user.
In the attached screenshot I created the admin > AAATest folder, then created the TestAAA, TestBBB, TestXXX and TestDDDDDD subfolders (in that order).
I then logged in as another user and they all appeared sorted by name as they should have.

Aaron Z

----- "Michael Peters" <email address hidden> wrote:

> From: "Michael Peters" <email address hidden>
> To: <email address hidden>
> Sent: Wednesday, June 1, 2011 10:17:11 AM GMT -05:00 US/Canada Eastern
> Subject: RE: [Bug 740466] Re: The folders in the reporting tool are not sorted 1.6.0.8, 2.0.3
>
> Aaron,
>
> Folders you own ("top" interface) sort properly.
>
> Folders under "shared" don't seem to.
>
> Sincerely,
> Michael Peters
> Indiana State Library MIS | Inspire.IN.gov Helpdesk | Evergreen
> Indiana Helpdesk
> office - 317.234.2128
> email - <email address hidden>
>
>
> -----Original Message-----
> From: <email address hidden> [mailto:<email address hidden>] On Behalf
> Of Aaron Z
> Sent: Wednesday, June 01, 2011 10:10 AM
> To: Peters, Michael
> Subject: Re: [Bug 740466] Re: The folders in the reporting tool are
> not sorted 1.6.0.8, 2.0.3
>
> So, if a folder is shared, this patch does not cause it to be sorted
> it
> by name?
>
> Aaron Z

[Michael Peters (mrpeters)]

We had some funky sharing going on on our production server that was breaking the reporter, not this code. So that's a good thing.

Now back to trying to figure out how to sort the Shared Folders subfolders by the sharer's "username" rather than the current sorting (not sure what that is).

[Dan Scott (denials)]

I've committed your patch, Michael, in master through rel_1_6_1. Many thanks!

I would suggest tracking the "Shared Folders" subfolder-by-username as a separate bug and closing this one, as the bug originally reported by the reporter has been fixed.