upgrade/reinstall option overwrites apt-setup generated sources.list (no extras.ubuntu.com)

Bug #739489 reported by Evan
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
apt-clone (Ubuntu)
Fix Released
High
Evan
Natty
Fix Released
High
Evan
ubiquity (Ubuntu)
Invalid
High
Evan
Natty
Invalid
High
Evan

Bug Description

Binary package hint: ubiquity

Installing with either the upgrade or reinstall option results in the attached duplicate sources.list entries.

Tags: patch

Related branches

Revision history for this message
Evan (ev) wrote :
Changed in ubiquity (Ubuntu):
assignee: nobody → Evan Dandrea (ev)
importance: Undecided → High
milestone: none → ubuntu-11.04-beta-1
status: New → Confirmed
Revision history for this message
Michael Vogt (mvo) wrote :

What does the original sources.list file looks like? Is this maybe a issue with apt-clone?

Colin Watson (cjwatson)
Changed in ubiquity (Ubuntu Natty):
milestone: ubuntu-11.04-beta-1 → ubuntu-11.04-beta-2
Revision history for this message
Evan (ev) wrote :
Revision history for this message
Evan (ev) wrote :
Revision history for this message
Evan (ev) wrote :
Revision history for this message
Evan (ev) wrote :

apt-clone does not attempt to merge the sources.list from the saved state into the new sources.list, if one exists (as it does in the installer case). Instead, it copies the sources.list from the saved state over the new sources.list.

Revision history for this message
Evan (ev) wrote :

Here's a work in progress patch. It does not yet work around the problem of referring to cdrom sources that do not exist, nor does it catch the FetchFailedException thrown by update() when not all sources can be updated.

Evan (ev)
summary: - upgrade/reinstall option creates duplicate sources.list entries
+ upgrade/reinstall option overwrites apt-setup generated sources.list (no
+ extras.ubuntu.com)
Revision history for this message
Evan (ev) wrote :

Further progress. All that's left is resolving duplicates, then I'll push it to a branch and propose a merge against trunk.

tags: added: patch
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks a bunch for this patch, looks great!

Changed in apt-clone (Ubuntu Natty):
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apt-clone - 0.1.4

---------------
apt-clone (0.1.4) natty; urgency=low

  * apt_clone.py:
    - add apt::architecture to the state file
  * apt_clone.py:
    - if run in restore-new-distro mode and we are on the new distro
      already (like e.g. ubiquity) then protect the installed packages on
      restore to ensure that conflicts get resolved in favor of the new
      defaults (important for e.g. clean xubuntu clone)
  * merged lp:~ev/apt-clone/739489, many thanks Evan Dandrea
    (LP: #739489)
  * debian/control:
    - depend on lsb-release for the restore-new-distro feature
 -- Michael Vogt <email address hidden> Thu, 07 Apr 2011 15:03:14 +0200

Changed in apt-clone (Ubuntu Natty):
status: In Progress → Fix Released
Evan (ev)
Changed in ubiquity (Ubuntu Natty):
status: Confirmed → Invalid
Colin Watson (cjwatson)
Changed in apt-clone (Ubuntu Natty):
importance: Undecided → High
assignee: nobody → Michael Vogt (mvo)
milestone: none → ubuntu-11.04-beta-2
assignee: Michael Vogt (mvo) → Evan Dandrea (ev)
Revision history for this message
Janusz (yorashtan2) wrote :

Tried to install 11.04 beta and the bug is still there.

Revision history for this message
Evan (ev) wrote :

ajarmoniuk,

Please file a new bug by running `sudo ubuntu-bug ubiquity`. Please also attach the /etc/apt/sources.list from the final system.

Thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.