Pause game while in 'save'-dialog
Bug #738643 reported by
LAZA
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
widelands |
Fix Released
|
Wishlist
|
cghislai |
Bug Description
it would be much comfortable if the game is automatically paused when the player wants to save it.
in the tutorial often messages and dialogs pops up while i'm in the save dialog and this is annoying and confusing (especially for Newbies)
for me normally playing in 2x speed to much happens in this time, - and still forget to pause before i save...
Related branches
lp:~widelands-dev/widelands/ui_improvments
- SirVer: Approve
-
Diff: 1269 lines (+309/-216)36 files modifiedsrc/chat.h (+6/-0)
src/constants.h (+1/-1)
src/debugconsole.cc (+4/-0)
src/gamecontroller.cc (+31/-3)
src/logic/building.cc (+6/-0)
src/logic/building.h (+5/-0)
src/logic/production_program.cc (+2/-2)
src/logic/productionsite.cc (+1/-1)
src/logic/trainingsite.cc (+1/-6)
src/network/internet_gaming.cc (+8/-1)
src/network/internet_gaming.h (+3/-0)
src/network/netclient.cc (+9/-0)
src/network/netclient.h (+1/-0)
src/network/nethost.cc (+7/-0)
src/save_handler.cc (+10/-2)
src/timestring.cc (+15/-0)
src/timestring.h (+5/-0)
src/ui_basic/progressbar.cc (+9/-12)
src/ui_basic/table.cc (+11/-22)
src/ui_fsmenu/loadgame.cc (+3/-8)
src/ui_fsmenu/loadreplay.cc (+3/-8)
src/ui_fsmenu/mapselect.cc (+3/-3)
src/wlapplication.cc (+7/-5)
src/wui/building_ui.cc (+8/-1)
src/wui/buildingwindow.cc (+5/-46)
src/wui/buildingwindow.h (+0/-1)
src/wui/fieldaction.cc (+1/-43)
src/wui/game_main_menu_save_game.cc (+20/-13)
src/wui/game_main_menu_save_game.h (+1/-1)
src/wui/game_message_menu.cc (+5/-13)
src/wui/interactive_base.cc (+64/-0)
src/wui/interactive_base.h (+3/-0)
src/wui/interactive_player.cc (+13/-10)
src/wui/interactive_player.h (+3/-0)
src/wui/productionsitewindow.cc (+34/-13)
src/wui/productionsitewindow.h (+1/-1)
Changed in widelands: | |
importance: | Undecided → Wishlist |
summary: |
- pause game while in 'save'-dialog + message when saving --> wishlist + pause game while in 'save'-dialog + message when saving |
Changed in widelands: | |
status: | New → In Progress |
assignee: | nobody → cghislai (charlyghislain) |
To post a comment you must log in.
I fully agree with providing some feedback during autosaving. I actually noticed this yesterday and planned to report it, but you beat me to it. :)
I thought about using the chat system or something similar to print some feedback, like "Autosaving..." when it starts, and "Saved" when it is finished. That way, the user will know what the game is doing, while today the game only seems to freeze when the autosave happens, especially on large maps.
When it comes to the save game dialog, I'm a bit unsure since no other dialogs will pause the game. Though I guess it could make sense if the game is paused when bringing up the save game dialog, to better provide time to type in a name for the savegame. I also think the game should be unpaused when the dialog is closed, so you can return to the game instantly. It also needs to handle if the user manually paused the game, though.
Final thought: this bug seems to cover two separate issues to me. Should the part with autosave be split out perhaps?