package sl-modem-source 2.9.11~20100718-2 failed to install/upgrade: sl-modem kernel module failed to build

[Nikolaus Filus]

After upgrading to natty I am greeted with an error message during each login to unity.

ProblemType: Package
DistroRelease: Ubuntu 11.04
Package: sl-modem-source 2.9.11~20100718-2
ProcVersionSignature: Ubuntu 2.6.38-7.35-generic 2.6.38
Uname: Linux 2.6.38-7-generic i686
Architecture: i386
DKMSBuildLog:
 DKMS make.log for sl-modem-2.9.11~20100718 for kernel 2.6.38-7-generic (i686)
 Fr 18. Mär 12:34:23 CET 2011
Date: Fri Mar 18 12:34:30 2011
ErrorMessage: sl-modem kernel module failed to build
PackageVersion: 2.9.11~20100718-2
SourcePackage: sl-modem
Title: package sl-modem-source 2.9.11~20100718-2 failed to install/upgrade: sl-modem kernel module failed to build
UpgradeStatus: Upgraded to natty on 2011-03-12 (5 days ago)

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

Please attach the make.log file, anyways, I suspect that this is the same bug as http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613906

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

Hello,

On Fri, Feb 18, 2011 at 08:31:53AM +0100, Harald Jenny wrote:
> make modules -C /lib/modules/2.6.37-1-686/build SUBDIRS=/var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers
> make[2]: Entering directory `/usr/src/linux-headers-2.6.37-1-686'
> CC [M] /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.o
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c: In function 'amrmo_ioctl':
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:450: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c: At top level:
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:517: error: unknown field 'ioctl' specified in initializer
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:517: warning: initialization from incompatible pointer type
> make[5]: *** [/var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.o] Error 1
---end quoted text---

  Could you try the attached patch please.

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[Nikolaus Filus (nfilus)]

Hi,
thank you for the fast response and help. My make.log was empty, but I was able to reproduce the errors from above and the patch makes it work. I can confirm this fix - is there already an integration into ubuntu in progress?

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

On Sat, Mar 19, 2011 at 10:23:02AM -0000, Nikolaus Filus wrote:
> thank you for the fast response and help. My make.log was empty, but I
> was able to reproduce the errors from above and the patch makes it
> work. I can confirm this fix

Thank you too for your fast response. I have a question though, does
"make it work" mean:
1) just that compilation works sucessfully ? or
2) that you indeed tried the modem (for example for faxing or connecting
to internet), and it did work ?

> - is there already an integration into ubuntu in progress?

Yes, if this patch indeed worked (as defined in point #2 above), then I
intend to upload that fix to both Debian & Ubuntu (for natty).

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[Nikolaus Filus (nfilus)]

I'm sorry, but I can only confirm the successfull compilation/installation as I didn't use the modem for years now and the driver was just proposed by the ubuntu installer back then and I didn't remove it. I do not even have anymore a possibility to test the driver's functionality.

[Harald Jenny (harald-a-little-linux-box)]

On Sat, Mar 19, 2011 at 10:08:42AM +0200, ???????? ???????????????? wrote:
> Hello,

Hi

>
> On Fri, Feb 18, 2011 at 08:31:53AM +0100, Harald Jenny wrote:
> > make modules -C /lib/modules/2.6.37-1-686/build SUBDIRS=/var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers
> > make[2]: Entering directory `/usr/src/linux-headers-2.6.37-1-686'
> > CC [M] /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.o
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c: In function 'amrmo_ioctl':
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:450: warning: ignoring return value of 'copy_from_user', declared with attribute warn_unused_result
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c: At top level:
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:517: error: unknown field 'ioctl' specified in initializer
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.c:517: warning: initialization from incompatible pointer type
> > make[5]: *** [/var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/amrmo_init.o] Error 1
> ---end quoted text---
>
> Could you try the attached patch please.

This error went away but there is another one now, please see attached log.

>
> --
> ??????????? ???????????????? (Ahmed El-Mahmoudy)
> Digital design engineer
> GPG KeyID: 0xEDDDA1B7
> GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

> diff --git a/drivers/amrmo_init.c b/drivers/amrmo_init.c
> index 98a74a3..d738f71 100644
> --- a/drivers/amrmo_init.c
> +++ b/drivers/amrmo_init.c
> @@ -514,7 +514,7 @@ static struct file_operations amrmo_fops = {
> .read = amrmo_read,
> .write = amrmo_write,
> .poll = amrmo_poll,
> - .ioctl = amrmo_ioctl,
> + .unlocked_ioctl = amrmo_ioctl,
> .open = amrmo_open,
> .release = amrmo_release,
> };

Thanks for your help and kind regards
Harald Jenny

[Nikolaus Filus (nfilus)]

My fault. I confirm that as I only tried a manual make, but dkms uses:
   make -C drivers USB=1 KERNEL_DIR=/lib/modules/2.6.38-7-generic/build KVERS=2.6.38-7-generic
The USB=1 part is the problem.

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

On Sat, Mar 19, 2011 at 12:06:00PM -0000, Nikolaus Filus wrote:
> My fault. I confirm that as I only tried a manual make, but dkms uses:
> make -C drivers USB=1 KERNEL_DIR=/lib/modules/2.6.38-7-generic/build KVERS=2.6.38-7-generic
> The USB=1 part is the problem.
---end quoted text---

USB=1 does not have to do with amrmo_init.c, so I don't think that USB=1
part is the problem.

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

On Sat, Mar 19, 2011 at 12:36:56PM +0100, Harald Jenny wrote:
> This error went away but there is another one now, please see attached log.
> [...]
> CC [M] /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.o
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:8: warning: type defaults to 'int' in declaration of 'DECLARE_MUTEX'
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:1: warning: parameter names (without types) in function declaration
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_open':
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1001:8: error: 'open_sem' undeclared (first use in this function)
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1001:8: note: each undeclared identifier is reported only once for each function it appears in
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_probe':
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1237:2: error: implicit declaration of function 'init_MUTEX'
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1320:8: error: 'open_sem' undeclared (first use in this function)
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 2 of 'device_create' makes pointer from integer without a cast
> include/linux/device.h:598:23: note: expected 'struct device *' but argument is of type 'int'
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 3 of 'device_create' makes integer from pointer without a cast
> include/linux/device.h:598:23: note: expected 'dev_t' but argument is of type 'void *'
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 5 of 'device_create' makes pointer from integer without a cast
> include/linux/device.h:598:23: note: expected 'const char *' but argument is of type 'int'
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_disconnect':
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1367:8: error: 'open_sem' undeclared (first use in this function)
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: At top level:
> /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:8: warning: 'DECLARE_MUTEX' declared 'static' but never defined
---end quoted text---

  Thanks for your report, please try the attached patch.

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[Harald Jenny (harald-a-little-linux-box)]

On Sat, Mar 19, 2011 at 04:45:28PM +0200, ???????? ???????????????? wrote:
> On Sat, Mar 19, 2011 at 12:36:56PM +0100, Harald Jenny wrote:
> > This error went away but there is another one now, please see attached log.
> > [...]
> > CC [M] /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.o
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:8: warning: type defaults to 'int' in declaration of 'DECLARE_MUTEX'
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:1: warning: parameter names (without types) in function declaration
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_open':
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1001:8: error: 'open_sem' undeclared (first use in this function)
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1001:8: note: each undeclared identifier is reported only once for each function it appears in
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_probe':
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1237:2: error: implicit declaration of function 'init_MUTEX'
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1320:8: error: 'open_sem' undeclared (first use in this function)
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 2 of 'device_create' makes pointer from integer without a cast
> > include/linux/device.h:598:23: note: expected 'struct device *' but argument is of type 'int'
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 3 of 'device_create' makes integer from pointer without a cast
> > include/linux/device.h:598:23: note: expected 'dev_t' but argument is of type 'void *'
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1336:2: warning: passing argument 5 of 'device_create' makes pointer from integer without a cast
> > include/linux/device.h:598:23: note: expected 'const char *' but argument is of type 'int'
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: In function 'st7554_disconnect':
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:1367:8: error: 'open_sem' undeclared (first use in this function)
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c: At top level:
> > /var/lib/dkms/sl-modem/2.9.11~20100718/build/drivers/st7554.c:236:8: warning: 'DECLARE_MUTEX' declared 'static' but never defined
> ---end quoted text---
>
> Thanks for your report, please try the attached patch.

Seems like the arguments have changed, please see attached log.

>
> --
> ??????????? ???????????????? (Ahmed El-Mahmoudy)
> Digital design engineer
> GPG KeyID: 0xEDDDA1B7
> GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

> Description: Fix compilation of slusb with 2.6.37
> *_MUTEX got deprecated since kernel 2.6.37
> Author: ???????? ???????????????? (Ahmed El-Mahmoudy) <email address hidden>
> Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613906
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/737650
> --- a/drivers/s...

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

On Sat, Mar 19, 2011 at 10:01:19PM +0100, Harald Jenny wrote:
> Seems like the arguments have changed, please see attached log.
---end quoted text---

  Thanks, please try the attached patch instead.

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[Harald Jenny (harald-a-little-linux-box)]

Hi

On Sun, Mar 20, 2011 at 08:23:53AM +0200, ???????? ???????????????? wrote:
> On Sat, Mar 19, 2011 at 10:01:19PM +0100, Harald Jenny wrote:
> > Seems like the arguments have changed, please see attached log.
> ---end quoted text---
>
> Thanks, please try the attached patch instead.

Problem with 2.6.37 is fixed by this patch (and module also compiles with
2.6.38).

Thanks for your help and kind regards
Harald Jenny

>
> --
> ??????????? ???????????????? (Ahmed El-Mahmoudy)
> Digital design engineer
> GPG KeyID: 0xEDDDA1B7
> GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

> Description: Fix compilation of slusb with 2.6.37
> *_MUTEX got deprecated since kernel 2.6.37
> Author: ???????? ???????????????? (Ahmed El-Mahmoudy) <email address hidden>
> Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=613906
> Bug-Ubuntu: https://bugs.launchpad.net/bugs/737650
> --- a/drivers/st7554.c
> +++ b/drivers/st7554.c
> @@ -233,7 +233,11 @@
> static struct class *st7554_class;
> #endif
>
> +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,37)
> static DECLARE_MUTEX(open_sem);
> +#else
> +static DEFINE_SEMAPHORE(open_sem);
> +#endif
>
> /* --------------------------------------------------------------------- */
>
> @@ -1234,7 +1238,11 @@
> memset(s, 0, sizeof(*s));
>
> spin_lock_init(&s->lock);
> +#ifdef init_MUTEX
> init_MUTEX (&s->sem);
> +#else
> + sema_init (&s->sem, 1);
> +#endif
> init_waitqueue_head(&s->wait);
>
> s->name = "ST7554 USB Modem";

[أحمد المحمودي (Ahmed El-Mahmoudy) (aelmahmoudy)]

Hello,

On Sun, Mar 20, 2011 at 08:38:01PM +0100, Harald Jenny wrote:
> Problem with 2.6.37 is fixed by this patch (and module also compiles with
> 2.6.38).
---end quoted text---

  Thanks, can you confirm that they actually work, ie. that you are able to
  dialup to internet or send/receive a fax ?

--
 ‎أحمد المحمودي (Ahmed El-Mahmoudy)
  Digital design engineer
 GPG KeyID: 0xEDDDA1B7
 GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

[Launchpad Janitor (janitor)]

This bug was fixed in the package sl-modem - 2.9.11~20100718-4

---------------
sl-modem (2.9.11~20100718-4) unstable; urgency=low

  * Added Indonesian translation (Closes: #608557)
  * Added alsa-utils to sl-modem-daemon Depends (LP: #706236)
  * Added ioctl.diff patch (from Gentoo) to fix compilation of slamr module
    with kernel 2.6.36 and later (Closes: #613906) (LP: #737650)
  * Added semaphore.diff patch to fix compilation of slusb module with kernel
    2.6.37
  * Remove leading ./ from lintian override

sl-modem (2.9.11~20100718-3) unstable; urgency=low

  * Add /usr/sbin:/sbin to PATH before calling execstack (Closes: #608367)
 -- ALEFHAHMEEMDAL ALEFLAMMEEMHAHMEEMWAWDALYEH (Ahmed El-Mahmoudy) <email address hidden> Sat, 19 Mar 2011 17:02:27 +0200

[Harald Jenny (harald-a-little-linux-box)]

On Mon, Mar 21, 2011 at 09:20:43AM +0200, ???????? ???????????????? wrote:
> Hello,

Hi

>
> On Sun, Mar 20, 2011 at 08:38:01PM +0100, Harald Jenny wrote:
> > Problem with 2.6.37 is fixed by this patch (and module also compiles with
> > 2.6.38).
> ---end quoted text---
>
> Thanks, can you confirm that they actually work, ie. that you are able to
> dialup to internet or send/receive a fax ?

This may take some days sorry.

>
> --
> ??????????? ???????????????? (Ahmed El-Mahmoudy)
> Digital design engineer
> GPG KeyID: 0xEDDDA1B7
> GPG Fingerprint: 8206 A196 2084 7E6D 0DF8 B176 BC19 6A94 EDDD A1B7

Kind regards
Harald Jenny