text box as artefact

[Kristina Hoeppner]

result from the discussion at http://mahara.org/interaction/forum/topic.php?id=3080 and previous talk between Richard Mansfield and me

Currently, the text box is only available in one view and it is not re-usable. It would be good to use it in multiple views like other artefacts and to be able to comment on it.

[Don Presant (don-learningagents)]

I think it would be better to keep the ad hoc "single use" Text box, but add a new class of artefact if you want to re-use it or allow comments. Something like My Blurbs or My Chunks.

My users would also use this for embedded media, much like an External Video block.

And what would it take to be able to convert a single use Text Box into a reusable Chunk, for those who only realize later that they want to reuse it? This is only "nice to have", since a user could simply copy the Text box into a Chunk.

[Don Presant (don-learningagents)]

Better term: My Articles

[François Marier (fmarier)]

https://reviews.mahara.org/#q,status:open+project:mahara+branch:master+topic:reusable-textbox,n,z

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/596
Committed: http://gitorious.org/mahara/mahara/commit/0b1f726403154d0afa4cbccf5804b38ce8e8429f
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 0b1f726403154d0afa4cbccf5804b38ce8e8429f
Author: Richard Mansfield <email address hidden>
Date: Mon Aug 8 16:05:35 2011 +1200

    Add an artefactchooser to the textbox config form (bug #736665)

    The configuration form's tinymce field allows the user to edit
    the currently selected html artefact. A new link below the content
    field displays an artefactchooser which, allows the user to select
    from their existing html artefacts. On selecting an artefact, the
    tinymce contents are replaced with the contents of the selected
    artefact. Also displays a message to the user whenever there are
    other blocks containing the same artefact as the one they've
    selected.

    Change-Id: I2ad655714429252ed3877e6589c37c6bbcaad37e
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/597
Committed: http://gitorious.org/mahara/mahara/commit/3cc2fc9988f46cb499284df248ba7580b1647f7d
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 3cc2fc9988f46cb499284df248ba7580b1647f7d
Author: Richard Mansfield <email address hidden>
Date: Mon Aug 15 11:51:51 2011 +1200

    Add comments on html artefacts (bug #736665)

    Let the owner enable comments at the artefact level. If a textbox
    contains an artefact which allows comments, add a comments link at
    the bottom of the block to the artefact page where users can view
    and leave comments.

    Change-Id: I4428db947cbee987d5ce55f8062ce4b7c30b0239
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/589
Committed: http://gitorious.org/mahara/mahara/commit/d0fffec06d15a55cf992ec9f3d646ebdd283b5fb
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit d0fffec06d15a55cf992ec9f3d646ebdd283b5fb
Author: Richard Mansfield <email address hidden>
Date: Fri Aug 5 13:26:40 2011 +1200

    Allow block configration to submit a list of other blocks to redraw

    When a block is saved after configuration, the view editor currently
    only rerenders the newly configured block. This change allows a
    blocktype's instance_config_save function to return a list of other
    blocks on the page that should be rerendered in addition to the newly
    configured block.

    This will provide a mechanism for *all* the textbox blocks on a page
    which contain a particular html artefact to be updated when the text
    of one of those blocks is updated (see bug #736665).

    Change-Id: Ic68f21bb8f46b79c5d9ed8e32504314dcc067429
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/588
Committed: http://gitorious.org/mahara/mahara/commit/4bb17cefc6a18653b069577c3ab529b7d1418b93
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 4bb17cefc6a18653b069577c3ab529b7d1418b93
Author: Richard Mansfield <email address hidden>
Date: Wed Aug 10 12:07:21 2011 +1200

    Add a page to manage html notes (bug #736665)

    Textbox blocks can now create and edit html artefacts, but they
    will never be able to provide an interface to delete them. Because
    fragments of html will become reusable in several blocks, there will
    inevitably be some fragments that disappear from views, but still
    exist in the artefact table. A My Notes area is added under the
    Content menu to manage these fragments.

    Change-Id: I98b410a35109f9945211329671089e45f917f38d
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/586
Committed: http://gitorious.org/mahara/mahara/commit/06f8f06cf4f3580629f44fcefc68e1d37325f058
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 06f8f06cf4f3580629f44fcefc68e1d37325f058
Author: Richard Mansfield <email address hidden>
Date: Tue Jul 12 18:34:46 2011 +1200

    Save textbox content to the artefact table (bug #736665)

    When a text box block is saved, a new html artefact is created,
    or an existing html artefact updated. The 'Block content'
    field from the form is saved into the description field of the
    artefact, and the artefact title is overwritten with the block
    title.

    This patch includes an upgrade to convert the contents of all
    existing textboxes on the site to html artefacts.

    Change-Id: I321735de5c0e4dc5768222f02c8e7e1bc716c237
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/584
Committed: http://gitorious.org/mahara/mahara/commit/239e3ae5f6da321be944b0af27ebc1bb8cb0d50f
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 239e3ae5f6da321be944b0af27ebc1bb8cb0d50f
Author: Richard Mansfield <email address hidden>
Date: Tue Jul 12 18:33:49 2011 +1200

    Move textbox blocktype into the internal artefact plugin (bug #736665)

    Because text boxes will create and display html artefacts, they should
    really live inside the internal artefact plugin.

    Contains a couple of whitespace/coding style fixes to ensure that new
    lines from the copied files pass the minaccept test.

    Change-Id: I9520f1d32eaaa7735b168f35ccc6af37e8c9e2c6
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/583
Committed: http://gitorious.org/mahara/mahara/commit/5a33ddd801f7478b739223307f2e7c5654643ac8
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 5a33ddd801f7478b739223307f2e7c5654643ac8
Author: Richard Mansfield <email address hidden>
Date: Mon Jul 11 17:56:21 2011 +1200

    Add html artefact type to internal artefact plugin (bug #736665)

    An artefact type for html fragments that don't fit into any of the
    existing categories like blog post, introduction, interests, etc.

    Change-Id: I81f6b32219377e55e962deab87a6f36483006693
    Signed-off-by: Richard Mansfield <email address hidden>

[Richard Mansfield (richard-mansfield)]

Reopening this: the upgrade fails to install the html artefact before converting the data.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/608
Committed: http://gitorious.org/mahara/mahara/commit/e68863baa48740bc4387d87bc1c452457f538fa2
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit e68863baa48740bc4387d87bc1c452457f538fa2
Author: Richard Mansfield <email address hidden>
Date: Mon Aug 22 10:27:07 2011 +1200

    Move textbox upgrade from artefact plugin to blocktype (bug #736665)

    The html artefact must be installed before the textbox content is
    upgraded to use html artefacts. Moving the upgrade from the internal
    artefact into the blocktype will make it happen in the correct order.

    Change-Id: I56da7296f39f3a1807ba9b71867ce69fec5cc186
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/636
Committed: http://gitorious.org/mahara/mahara/commit/93faaf207dc3a390310165b860ed23fc3c940b74
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 93faaf207dc3a390310165b860ed23fc3c940b74
Author: Richard Mansfield <email address hidden>
Date: Fri Sep 2 15:44:23 2011 +1200

    Rewrite upgrade of textbox blocks (bug #736665)

    The upgrade was too slow on large databases, because it inserted
    the new textbox artefacts one by one. The rewrite updates the table
    in bigger chunks.

    Change-Id: I3a4159291e477453c21eb90816a02bbee50b5971
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/736
Committed: http://gitorious.org/mahara/mahara/commit/047be2902379cfc0818f13b9aaeebebf7035b068
Submitter: Hugh Davenport (<email address hidden>)
Branch: master

commit 047be2902379cfc0818f13b9aaeebebf7035b068
Author: Richard Mansfield <email address hidden>
Date: Mon Sep 26 16:12:51 2011 +1300

    Don't update html artefact title with textbox title (bug #736665)

    Whenever a textbox block title was changed, the html artefact inside
    it also had its title changed. That was confusing, so instead we're
    going to set the html artefact's title once, when the textbox is first
    created (generating a title for it if the block has no title). Once
    the html artefact has been created, the title can no longer be modified
    from the view editor again. However, the ability to update the artefact
    title from the notes area is added, so that the user can keep the title
    in sync with the block titles if they want to.

    Change-Id: I98e2529e7c81759c9b22130da355e227c8f3d577
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/774
Committed: http://gitorious.org/mahara/mahara/commit/1a029b7b4a4c21c0e5a1213d66603038c3235ad5
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 1a029b7b4a4c21c0e5a1213d66603038c3235ad5
Author: Richard Mansfield <email address hidden>
Date: Wed Oct 5 11:55:52 2011 +1300

    Show artefact owner when selecting html artefacts (bug #736665)

    In the artefact chooser for the textbox configuration form, add the
    name of the artefact owner beside the title of each artefact. This
    makes it easier to distinguish between notes with the same title, and
    more obvious when selecting (for example) group artefacts for inclusion
    in a personal view.

    Change-Id: I21f8636e7d9ee49237c636c2c56949c62ff1612b
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/771
Committed: http://gitorious.org/mahara/mahara/commit/ea22bbf644746b1bc5770c471ec92109ae77b7af
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit ea22bbf644746b1bc5770c471ec92109ae77b7af
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 4 15:58:07 2011 +1300

    Display textbox notes as read-only in config form (bug #736665)

    When configuring a textbox that includes an html artefact owned by
    someone other than the view owner, it must be made clear to the user
    that the textbox cannot be edited within the current view.

    In this case, the sanitised html from the artefactchooser is
    displayed inside a grey box in the config form, and the tinymce editor
    is hidden.

    A help file has been added to explain why the user cannot edit the
    selected artefact.

    (When tinymce includes an toggle for its read-only mode, this can be
    simplified)

    Change-Id: I81b44928b7ac83ffaebba04d4ab34d3964743bf4
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/775
Committed: http://gitorious.org/mahara/mahara/commit/ee14f8f5569f67d2762043b3f1ee7dab5a0ad8a4
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit ee14f8f5569f67d2762043b3f1ee7dab5a0ad8a4
Author: Richard Mansfield <email address hidden>
Date: Wed Oct 5 14:53:22 2011 +1300

    Allow update of group note permissions (bug #736665)

    Previously the only group artefacts were files, and group file permissions
    can be updated within the filebrowser elements. Now that there are group
    notes, the permissions need to be able to be modified. Done as a pieform
    element in case other group artefact types are added in future.

    Change-Id: I308cf44f95d29a4d13722726c9f007e248ee81fe
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/772
Committed: http://gitorious.org/mahara/mahara/commit/7319216579c6c4a73ad992d9937b6805a753ab66
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 7319216579c6c4a73ad992d9937b6805a753ab66
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 4 16:01:31 2011 +1300

    When configuring a read-only textbox, allow copying (bug #736665)

    When configuring a textbox containing a read-only artefact (or one
    which has copies in other blocks), the user will often want to
    create a new copy of the note instead of reusing the note. This
    patch adds a 'copy' link beside the read-only message, which will
    unhide the tinymce box and set a flag to ensure that a new html
    artefact gets created on submission.

    Change-Id: I5214c5b0ae615cd9f32dfc5c71efc942b5961756
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/770
Committed: http://gitorious.org/mahara/mahara/commit/d61a6b459c172e24fb4cfe48e7a90c83f91294b0
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit d61a6b459c172e24fb4cfe48e7a90c83f91294b0
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 4 15:17:42 2011 +1300

    Return sanitised copy of description from artefactchooser (bug #736665)

    When we are going to display an html artefact description outside a
    tinymce window, in 'read-only' mode, we need it to be cleaned up by
    the server in advance. This patch adds returns a safe version of an
    artefact description along with the original description, when
    requested in the artefactchooser configuration.

    Change-Id: I8725e56608214bba0a262de78e6dac8fcf5a4dd8
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/767
Committed: http://gitorious.org/mahara/mahara/commit/9503d300aa85633200a209efcd79a5e938df0e0b
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 9503d300aa85633200a209efcd79a5e938df0e0b
Author: Richard Mansfield <email address hidden>
Date: Mon Oct 3 13:17:02 2011 +1300

    Allow editing of a textbox block when artefact not found (bug #736665)

    When a textbox block references an artefact that has been deleted,
    or has become unpublishable by the current user, clicking the block's
    configure button causes an error and fails to bring up the config
    form. Avoid this by catching the ArtefactNotFound exception, and
    allowing the block to be reconfigured when it contains an invalid
    artefact.

    Change-Id: Ia1611a6abf2328c503655dacf01b2c414a603b0a
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/769
Committed: http://gitorious.org/mahara/mahara/commit/28390994e945790b171e767a022e9ea310472280
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit 28390994e945790b171e767a022e9ea310472280
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 4 15:13:28 2011 +1300

    Get editable status along with artefactchooser artefacts (bug #736665)

    When choosing an artefact for inclusion in a view, add a boolean
    property to indicate whether each returned artefact is editable in
    the context of the view. So, individual artefacts are editable in
    individual views provided the 'owner' is the same, group artefacts
    are editable when the group is the same as the view's group, etc.

    Change-Id: I3ec7d13d5401ddd007916f9382fd0673739dd815
    Signed-off-by: Richard Mansfield <email address hidden>

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/768
Committed: http://gitorious.org/mahara/mahara/commit/a65e40c4cdaed7922a01250682d11a98bd2b966b
Submitter: Richard Mansfield (<email address hidden>)
Branch: master

commit a65e40c4cdaed7922a01250682d11a98bd2b966b
Author: Richard Mansfield <email address hidden>
Date: Tue Oct 4 15:29:50 2011 +1300

    Stop users from editing note text in the wrong context (bug #736665)

    When a user is allowed to put (for example) a group textbox inside
    a personal view, they should not be able to edit the contents of
    that textbox inside their personal view, because it's not clear
    enough that they may be about to modify a note with a different
    owner. This is especially dangerous when a group textbox has been
    added to the individual views of different group members, and any
    one member is able to modify the group textbox through their own
    view.

    When saving an html artefact from a textbox block configuration
    form, this patch adds a check to ensure that the view owner is the
    same as the artefact owner. If not, an error is not thrown, but
    the artefact description is not updated either. A later commit
    will ensure that users are made aware which html artefacts are
    editable, and which are read-only before the configuration form is
    submitted.

    This change also allows users to include html artefacts in a
    textbox even when they only have 'republish' permission on the
    artefact.

    Change-Id: I3ec49f59b04679853ecd57e300e72f23f6ff9c9d
    Signed-off-by: Richard Mansfield <email address hidden>

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjqdlAAoJECXBtiziiXdcxeoH/iQi1ljFCaDUrA07cq6IAZga
p3Tw7VRtZBy6Cl5NwOFg1b4/DsqFIM9fQPb+WpJqUAcTVP6B44QElOCtb0ldeZCw
cgWlkkSj1jk/gpCdKhCZ2MMHkRjMao5ZpUyF4vSO26tIiYcvPIhRoF6uWu0Z40xe
1wee4ZKGEEvO13bujMyuu4nEQSd9TK5VWPn+PbIKFEyJgCY19Zw62fWBXoanPbWj
LDuO9AnaQOPyVEx2qtoH8M5LFra2zq+dZ9Ac7oAiLffcWJAB9MqL8o2zbQHpOuVi
Ynrh6BIyUYaqdt1BhALrJ6/MQ0h7mDKGy8CVg0z4e2VHyxecYwc84kwzrItH7I0=
=mdeb
-----END PGP SIGNATURE-----

[Melissa Draper (melissa)]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 status fixreleased
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJPjrRzAAoJECXBtiziiXdcggYH/39bWTAPjHe9fUi3ve11K6iW
/R7j+mSc51e/47Cx0Z1Xv1HkDY0ymFLyRU/4CgErzWLWtrlSVhDx/r3gf8aHj+A+
ICmHRmTTCRBij5sKZVZbzZDN/t9drPvJ1u1dWcagGR2DiXoxAa9Kd2LUXKScRvS6
DqhQWj42JiOoo1R1FGFLa8dpPwlzwuLKyQQ6gvdDutva0E3RqktUUBy8w6ieMG6E
UM/K4sdgx7AAhfBxg91349DOjKeHE/69Vb1gbJXE9UtY/xwe+3sgBtAM7aN4e5US
PhBcGckRLkgxpwLwDzTNGuDHFp51OjIdqXaoRAxXx3tgOonY2bs/eqg42RJBcR4=
=dLjM
-----END PGP SIGNATURE-----