IndexError while trying to edit program entry

Bug #734267 reported by Krzysztof Sikorski
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Vineyard
Fix Released
Undecided
Unassigned

Bug Description

When I try to edit any entry in Installed Programs, I get an IndexError for almost all entries.
I found only one entry that doesn't raise an error, it's in "Libraries from Registry" section and has empty almost all of the fields, so I guess the error comes from parsing one of the fields.
I attach some console logs, maybe it'll help.

On a probably unrelated note: those stacks of slashes in the logs look suspicious, you may be escaping an already escaped string somewhere...

Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :
Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :

Update: I played a bit with "Add unlisted program" command and I found that the error is raised when the Command field's value is surrounded in apostrophes. The Browse button sets it that way, and there is no error if I remove the quotes before saving the form.

Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Thanks once again Krzysztof :)

The error was the quotes has now been fixed.

You're very fast I must say, the bug was only introduced around 11 hours ago ;)

And yeah, the stack of slashes is annoying, but not a real problem (so far).
I've made a new character escape function that doesn't do that, but haven't found where it should be used yet - I'll check it again.

Changed in vineyard:
status: New → Fix Committed
Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

There, the multiple escapes should be fixed now as well.

Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :

"You're very fast I must say, the bug was only introduced around 11 hours ago ;)"
I just wanted to play some games ;)

Revision history for this message
Krzysztof Sikorski (krzysztof-sikorski) wrote :

I hate to say it, but the last revision is messed up. Any operation in GUI (and even launching it) floods the console with:

Error occured
There was an error running the threaded function: 'str' object is not iterable
/home/rad/vineyard/vineyard/async.py:117
/home/rad/vineyard/vineyard/widgets/widget.py:67
/home/rad/vineyard/vineyard/widgets/widget.py:183
/home/rad/vineyard/python-wine/wine/version.py:102
/home/rad/vineyard/python-wine/wine/registry.py:264
/home/rad/vineyard/python-wine/wine/registry.py:138
/home/rad/vineyard/python-wine/wine/registry.py:28
/home/rad/vineyard/python-wine/wine/util.py:133
/home/rad/vineyard/python-wine/wine/util.py:133
/home/rad/vineyard/python-wine/wine/util.py:133
/home/rad/vineyard/python-wine/wine/util.py:133
/home/rad/vineyard/python-wine/wine/util.py:133
... and so on for 900+ lines...
/home/rad/vineyard/python-wine/wine/util.py:133
/home/rad/vineyard/python-wine/wine/util.py:132
<type 'exceptions.TypeError'>: 'str' object is not iterable
None

Revision history for this message
Christian Dannie Storgaard (cybolic) wrote :

Now that is very weird... a str object should always be iterable...
Anyway it's fixed now and technically it's a bit better than before as well, so hurray!
Thanks again.

Changed in vineyard:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.