Comma at end of enumerator list

Bug #731832 reported by Jean-Philippe Orsini
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Unity
Fix Released
Undecided
Unassigned
dee
Fix Released
Low
Mikkel Kamstrup Erlandsen
dee (Ubuntu)
Fix Released
Low
Unassigned
unity (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The file /usr/include/dee-index.h defines enum type as:
typedef enum
{
  DEE_TERM_MATCH_EXACT = 0,
  DEE_TERM_MATCH_PREFIX = 1 << 1,
} DeeTermMatchFlag;

The , at the end of the declaration prevents to use the .h while compiling with -pedantic option.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: libdee-dev 0.4.2-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.35-27.48-generic 2.6.35.11
Uname: Linux 2.6.35-27-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
CheckboxSubmission: a88788882866cb6790d39323d234ece2
CheckboxSystem: 2a6f54df59af338184485e85cbcf0d32
Date: Wed Mar 9 10:02:50 2011
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha amd64 (20100602.2)
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.utf8
 SHELL=/bin/bash
SourcePackage: dee

Related branches

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :
description: updated
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Note that the fix should just require to remove the extra comma from the file

Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Attached is a debdiff fixing this bug

Changed in dee (Ubuntu):
importance: Undecided → Low
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Trailing ,'s are probably the best thing since sliced bread - but who am I to argue with gcc :-/

Changed in dee:
assignee: nobody → Mikkel Kamstrup Erlandsen (kamstrup)
importance: Undecided → Low
milestone: none → 0.5.14
status: New → Fix Committed
Changed in dee (Ubuntu):
status: New → Fix Committed
Revision history for this message
Jean-Philippe Orsini (jfi) wrote :

Attached new debdiff which adds "(LP: #731832)" in the debian/changelog

tags: added: patch
Changed in unity:
status: New → Fix Committed
Changed in dee:
status: Fix Committed → Fix Released
Changed in unity:
status: Fix Committed → Fix Released
Changed in dee (Ubuntu):
status: Fix Committed → Fix Released
Changed in unity (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.