Support archive.canonical.com and for-pay as origin
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ratings and Reviews server |
Fix Released
|
Medium
|
Michael Nelson | ||
software-center (Ubuntu) |
Fix Released
|
Medium
|
Michael Vogt | ||
Natty |
Fix Released
|
Medium
|
Michael Vogt |
Bug Description
For natty final we want to support archive.
To do that the server needs to be extended to support this, the client already sends along the origin information that it gets from the archive release file (in lowercase) when submitting a review.
E.g.:
- archive.ubuntu.com its "ubuntu" (http://
- archive.
- extras.ubuntu.com its "lp-ppa-
- a PPA its "lp-ppa-mvo" (http://
- a private PPA its e.g. lp-ppa-
The client will use the origin information to get reviews as well. It will have to special case the software-
and add something like:
origin = "lp-ppa-%s" % item.archive_
to get the origin for the agent.
QA Notes:
Currently this is difficult to QA as there are no for-pay apps for natty yet. To trick USC you need to update (1) your sources.list entry for the archive you are testing (either a for-pay private ppa, or archive.
1) Select 'More info' for the for-pay app (or partner app) that you have installed
2) Write a review and verify it submits successfully, and displays in the UI
3) Remember to revert the changes to your sources.list and /etc/lsb-release
Cheated, I had uplink installed on maverick so I use SC trunk and filed a review from there on Uplink.
Related branches
- Danny Tamez (community): Approve
-
Diff: 571 lines (+277/-103)9 files modifieddjango_project/config_dev/config/main.cfg (+8/-0)
django_project/config_dev/schema.py (+1/-0)
src/reviewsapp/api/handlers.py (+3/-1)
src/reviewsapp/forms.py (+45/-38)
src/reviewsapp/models/reviews.py (+6/-0)
src/reviewsapp/tests/test_handlers.py (+42/-3)
src/reviewsapp/tests/test_rnrclient.py (+8/-3)
src/reviewsapp/tests/test_utilities.py (+120/-43)
src/reviewsapp/utilities.py (+44/-15)
- Danny Tamez (community): Approve
-
Diff: 687 lines (+360/-86)10 files modifieddjango_project/config_dev/config/main.cfg (+0/-8)
django_project/config_dev/schema.py (+5/-2)
src/reviewsapp/forms.py (+12/-8)
src/reviewsapp/preflight.py (+6/-1)
src/reviewsapp/tests/factory.py (+5/-0)
src/reviewsapp/tests/test_data/software_center_apps.json (+135/-0)
src/reviewsapp/tests/test_handlers.py (+10/-5)
src/reviewsapp/tests/test_preflight.py (+56/-27)
src/reviewsapp/tests/test_utilities.py (+70/-13)
src/reviewsapp/utilities.py (+61/-22)
Changed in software-center (Ubuntu Natty): | |
status: | New → Fix Committed |
assignee: | nobody → Michael Vogt (mvo) |
importance: | Undecided → Medium |
description: | updated |
description: | updated |
description: | updated |
tags: | added: kb-improvement |
Changed in rnr-server: | |
importance: | Undecided → Medium |
Changed in rnr-server: | |
assignee: | nobody → Michael Nelson (michael.nelson) |
status: | New → In Progress |
Changed in rnr-server: | |
status: | In Progress → Fix Committed |
description: | updated |
description: | updated |
Changed in rnr-server: | |
status: | Fix Committed → Fix Released |
Changed in rnr-server: | |
milestone: | none → 11.03 |
Software-center needs to grow code to get the origin for software- center- agent items