Empathy - 'Contact' menu items dont work in chat window

Bug #729191 reported by Omer Akram
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Empathy
Fix Released
Low
empathy (Ubuntu)
Fix Released
Low
Michael Terry

Bug Description

start empathy and login to gtalk. double click on a contact in the contact list to chat with. click the 'Contact' menu and try to click on any item see nothing happens, now try to open that menu again, its blank.

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: libdbusmenu-gtk3 0.3.100-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.38-5.32-generic 2.6.38-rc6
Uname: Linux 2.6.38-5-generic i686
Architecture: i386
Date: Fri Mar 4 21:43:43 2011
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110226)
ProcEnviron:
 LANGUAGE=en_US:en
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: libdbusmenu
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Omer Akram (om26er) wrote :
summary: - Empathy - Contact menu items dont work in chat window
+ Empathy - 'Contact' menu items dont work in chat window
Robert Roth (evfool)
Changed in libdbusmenu (Ubuntu):
status: New → Confirmed
Changed in libdbusmenu (Ubuntu):
importance: Undecided → Low
Changed in dbusmenu:
importance: Undecided → Low
Changed in libdbusmenu (Ubuntu):
assignee: nobody → Michael Terry (mterry)
Revision history for this message
Michael Terry (mterry) wrote :

A bit of info on this one. The menu coming back appears to be fixed with trunk versions of dbusmenu. But the "nothing happening" bug is still there.

As best as I can tell, this is because the menu dismisses upon being clicked and sends a dbus message to empathy telling it which item got clicked. But at the same time, empathy is receiving a focus-in event, which causes it to recreate its contact menu. By the time it processes the dbus message, the item which got clicked no longer exists, so it is ignored. In other words, a race condition.

Thinking about how to fix it...

Revision history for this message
Michael Terry (mterry) wrote :

Fixed this in empathy:

empathy (2.33.3-0ubuntu3) natty; urgency=low

  * debian/patches/42_dont_change_menu_on_focus.patch:
    - Don't change Contact menu when receiving a focus-in event. This makes
      it difficult for global menu implementations like indicator-appmenu.
      LP: #729191
 -- Michael Terry <email address hidden> Wed, 16 Mar 2011 09:06:02 -0400

affects: libdbusmenu (Ubuntu) → empathy (Ubuntu)
Changed in empathy (Ubuntu):
status: Confirmed → Fix Released
affects: dbusmenu → empathy
Changed in empathy:
importance: Low → Unknown
status: New → Unknown
tags: added: patch-forwarded-upstream
Changed in empathy:
importance: Unknown → Low
status: Unknown → New
Changed in empathy:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.