Failure in Assembly level Action attribute causes crash

[Charlie Poole]

If an assembly-level action attribute causes an error or failure in it's start phase, a null reference occurs in TestSuite.MarkTestFailed when attempting to acess this.FixtureType.Name.

Before the introduction of action attributes it was not possible to have a failure in setup unless there was a fixture, so no test for FixtureType being null was made. We need to test for a non-null fixtureType before trying to access it. This will also apply to marking child tests as invalid or ignored - essentially, all references to FixtureType on the test suite must be guarded now.

[Jordan Terrell (jterrell)]

Interesting - I can't reproduce this error using the NUnit GUI runner - only through Nant.

[Charlie Poole (charlie.poole)]

I suggest you temporarily put an action attribute on an assembly and
throw an exception in the before method. What it should do is mark
all the tests as failures. Instead, it crashes in MarkTestFailed.

Charlie

On Sun, Feb 27, 2011 at 6:38 PM, Jordan Terrell
<email address hidden> wrote:
> Interesting - I can't reproduce this error using the NUnit GUI runner -
> only through Nant.
>
> --
> You received this bug notification because you are a member of NUnit
> Developers, which is subscribed to NUnit V2.
> https://bugs.launchpad.net/bugs/726313
>
> Title:
>  Failure in Assembly level Action attribute causes crash
>