Make buttons in Account tab be regular buttons
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu One Control Panel |
Fix Released
|
Medium
|
Natalia Bidart | ||
ubuntuone-control-panel (Ubuntu) |
Fix Released
|
Medium
|
Natalia Bidart | ||
Natty |
Fix Released
|
Medium
|
Natalia Bidart |
Bug Description
In bug #718629, Daniel said:
I think we really need those links to be displayed as buttons. Especially since the strings are not the same length, the current display seems like text is just scattered across the page without any sort of alignment. Having homogeneous buttons gives more structure to the page and makes it not only more visually appealing, but easier to group objects and find what you're looking for in those groups. I would avoid using links unless there is a strong space saving concern or it is embedded within other text. Also remember that (especially in the case of help) users will expect a button that does in fact lead away from the window they are currently using :)
Of course, this is going to make it apparent that the two help buttons are not properly aligned to the window ;) That is, as per HIG they should be 12px away from the button of the window.
Also that string "Edit" under the "Personal Details" frame is not very explanatory. In the mockup I had it as "Edit Account Details" This (like the string for "Buy more..") is very explicit in its purpose. This should also help with the buttons appearing too wide ;)
Related branches
- Martin Albisetti (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 315 lines (+86/-73)3 files modifieddata/dashboard.ui (+73/-71)
data/services.ui (+12/-1)
ubuntuone/controlpanel/gtk/gui.py (+1/-1)
Changed in ubuntuone-control-panel: | |
status: | Incomplete → Triaged |
importance: | Undecided → Medium |
Changed in ubuntuone-control-panel (Ubuntu): | |
status: | New → Triaged |
tags: | added: desktop+ u1-gui u1-natty |
Changed in ubuntuone-control-panel (Ubuntu): | |
assignee: | nobody → Naty Bidart (nataliabidart) |
importance: | Undecided → Medium |
Changed in ubuntuone-control-panel: | |
status: | Triaged → In Progress |
Changed in ubuntuone-control-panel: | |
status: | In Progress → Fix Committed |
Changed in ubuntuone-control-panel (Ubuntu): | |
milestone: | none → ubuntu-11.04-beta-1 |
Changed in ubuntuone-control-panel: | |
status: | Fix Committed → Fix Released |
Hey Daniel,
I'm a bit lost. So, you still want the 'Official Support' and 'Community Support' to be regular buttons, right? What about 'Edit' and 'Buy more storage...'?
I still think that the buttons that take the user to a browser should be LinkButtons, that's the goal of a LinkButton within the GTK widget set. Anyways, I will investigate if I can make a LinkButton to look like a regular button.
Regarding the 12px, I didn't understand what you mean.
Cheers, Naty.