Fixes for bug 723298 inadvertently broke flatdhcp

[Vish Ishaya]

The changes for bug 723398 forgot that FlatDHCPNetwork inherited from FlatNetwork, and it is therefore broken.

[Salvatore Orlando (salvatore-orlando)]

My apologies Vish.
I tested the bug fix only with Flat and Vlan manager.
A reminder for me for future fixes, and a point for adding integration testing into Hudson!

[Jay Pipes (jaypipes)]

On Thu, Feb 24, 2011 at 4:58 AM, Salvatore Orlando
<email address hidden> wrote:
> ... a point for adding integration testing into Hudson!

Yet another reason that integration/smoketests need to be the #1
priority right now, IMHO.

-jay

[Vish Ishaya (vishvananda)]

No worries. I suggested the fix after all. And I approved it, so i think most of the fault belongs to me.

Vish

On Feb 24, 2011, at 1:58 AM, Salvatore Orlando wrote:

> My apologies Vish.
> I tested the bug fix only with Flat and Vlan manager.
> A reminder for me for future fixes, and a point for adding integration testing into Hudson!
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/724159
>
> Title:
> Fixes for bug 723298 inadvertently broke flatdhcp
>
> Status in OpenStack Compute (Nova):
> In Progress
>
> Bug description:
> The changes for bug 723398 forgot that FlatDHCPNetwork inherited from
> FlatNetwork, and it is therefore broken.
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/nova/+bug/724159/+subscribe