PulseAudio package still uses -mimplicit-it=thumb in debian/rules

Bug #721498 reported by Kurt Taylor
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Linaro
Fix Released
Undecided
Kurt Taylor
PulseAudio
Fix Released
Unknown
pulseaudio (Ubuntu)
Fix Released
Medium
Unassigned

Bug Description

I am seeing the following when trying to build PulseAudio on Beagleboard (OMAP3):

  CC libpulsecore_1.0_la-svolume_arm.lo
{standard input}: Assembler messages:
{standard input}:82: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
{standard input}:83: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
{standard input}:98: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
{standard input}:99: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
{standard input}:119: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
{standard input}:120: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'

I am using the normal build (bootstrap.sh, configure, make) on Linaro ALIP on the Beagleboard. Ubuntu build process works because of the rule specifying "-Wa, -mimplicit-it=thumb" which suppresses the error.

Revision history for this message
Kurt Taylor (krtaylor) wrote :

Here is a patch that added IT blocks to fix the thumb conditional instruction build error messages. Built and tested on Beagleboard using Linaro ALIP dail7 20110215.

Changed in linaro:
assignee: nobody → Kurt Taylor (kurt-r-taylor)
Kurt Taylor (krtaylor)
Changed in linaro:
status: New → In Progress
Changed in pulseaudio:
status: Unknown → Confirmed
Changed in pulseaudio:
status: Confirmed → Fix Released
Revision history for this message
Kurt Taylor (krtaylor) wrote :

Patch tweaked to use "itt cs" is now upstream. Patch posed here works, but isn't as clean.

Changed in linaro:
status: In Progress → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote :

Kurt, do you have a link for the upstream commit which fixes this (that you say implements it a different way)? We should be cherry-picking this into the Ubuntu package for natty if necessary.

tags: added: arm-porting-queue
removed: beagleboard
Changed in pulseaudio (Ubuntu):
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Kurt Taylor (krtaylor) wrote : Re: [Bug 721498] Re: PulseAudio assembler build errors on Beagleboard

Hi Steve, it was checked in as rb7779ec this morning from the
maintainers repository where it was tweaked.

I have never used cherry-pick (still learning git) but will try it an
post a patch in the launchpad defect.

Kurt Taylor (irc krtaylor)

On Tue, Feb 22, 2011 at 11:57 AM, Steve Langasek
<email address hidden> wrote:
> Kurt, do you have a link for the upstream commit which fixes this (that
> you say implements it a different way)?  We should be cherry-picking
> this into the Ubuntu package for natty if necessary.
>
> ** Also affects: pulseaudio (Ubuntu)
>   Importance: Undecided
>       Status: New
>
> ** Tags added: arm-porting-queue
> ** Tags removed: beagleboard
>
> ** Changed in: pulseaudio (Ubuntu)
>   Importance: Undecided => Medium
>
> ** Changed in: pulseaudio (Ubuntu)
>       Status: New => Triaged
>
> --
> You received this bug notification because you are a member of Ubuntu
> Audio Team, which is subscribed to pulseaudio in ubuntu.
> https://bugs.launchpad.net/bugs/721498
>
> Title:
>  PulseAudio assembler build errors on Beagleboard
>
> Status in Linaro:
>  Fix Released
> Status in PulseAudio sound server:
>  Fix Released
> Status in “pulseaudio” package in Ubuntu:
>  Triaged
>
> Bug description:
>  I am seeing the following when trying to build PulseAudio on
>  Beagleboard (OMAP3):
>
>    CC     libpulsecore_1.0_la-svolume_arm.lo
>  {standard input}: Assembler messages:
>  {standard input}:82: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:83: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>  {standard input}:98: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:99: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>  {standard input}:119: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:120: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>
>  I am using the normal build (bootstrap.sh, configure, make) on Linaro
>  ALIP on the Beagleboard. Ubuntu build process works because of the
>  rule specifying  "-Wa, -mimplicit-it=thumb" which suppresses the
>  error.
>

Revision history for this message
Steve Langasek (vorlon) wrote :

On Tue, Feb 22, 2011 at 09:37:20PM -0000, Kurt Taylor wrote:
> Hi Steve, it was checked in as rb7779ec this morning from the
> maintainers repository where it was tweaked.

> I have never used cherry-pick (still learning git) but will try it an
> post a patch in the launchpad defect.

Sorry, I mean cherry-pick in a generic sense, not as a git command. A 'git
show' or 'git format-patch' of the relevant upstream commit, attached as a
patch to the launchpad bug, is sufficient.

--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
<email address hidden> <email address hidden>

Revision history for this message
Luke Yelavich (themuso) wrote :

I did a quick check, and the above mentioned commit cherry-picks cleanly into stable-queue. If I make a source package available for testing, could someone with the affected hardware do a build test to make sure nothing else breaks?

If successful, I'll bd glad to upload the patch.

Luke

Revision history for this message
Kurt Taylor (krtaylor) wrote :

Sure, no problem, I can test it on the board I found it on.

On Tue, Feb 22, 2011 at 4:09 PM, Luke Yelavich
<email address hidden> wrote:
> I did a quick check, and the above mentioned commit cherry-picks cleanly
> into stable-queue. If I make a source package available for testing,
> could someone with the affected hardware do a build test to make sure
> nothing else breaks?
>
> If successful, I'll bd glad to upload the patch.
>
> Luke
>
> --
> You received this bug notification because you are a member of Ubuntu
> Audio Team, which is subscribed to pulseaudio in ubuntu.
> https://bugs.launchpad.net/bugs/721498
>
> Title:
>  PulseAudio assembler build errors on Beagleboard
>
> Status in Linaro:
>  Fix Released
> Status in PulseAudio sound server:
>  Fix Released
> Status in “pulseaudio” package in Ubuntu:
>  Triaged
>
> Bug description:
>  I am seeing the following when trying to build PulseAudio on
>  Beagleboard (OMAP3):
>
>    CC     libpulsecore_1.0_la-svolume_arm.lo
>  {standard input}: Assembler messages:
>  {standard input}:82: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:83: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>  {standard input}:98: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:99: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>  {standard input}:119: Error: thumb conditional instruction should be in IT block -- `addcs r0,r8'
>  {standard input}:120: Error: thumb conditional instruction should be in IT block -- `movcs r6,r0'
>
>  I am using the normal build (bootstrap.sh, configure, make) on Linaro
>  ALIP on the Beagleboard. Ubuntu build process works because of the
>  rule specifying  "-Wa, -mimplicit-it=thumb" which suppresses the
>  error.
>

Revision history for this message
Luke Yelavich (themuso) wrote :

Ok, you will be able to grab a pulseaudio source package from my PPA shortly: http://launchpad.net/~themuso/+archive.

Revision history for this message
Kurt Taylor (krtaylor) wrote : Re: PulseAudio assembler build errors on Beagleboard

After verifying the patch was there, I built/installed the ppa (0.9.22-24-g67d18) on the beagleboard c4. I only did limited testing but it built and ran fine.

Revision history for this message
Kurt Taylor (krtaylor) wrote :

 I just checked the debian/rules and the common-configure-arch CFLAGS with implicit-it was still there. This was not a problem for suppressing the build error in this test environment (BBc4), but it is worth mentioning for testing other arm environments.

Revision history for this message
Jani Monoses (jani) wrote :

The implicit-it arg passing should be taken out of the rules file once the above asm patch is applied.

Jani Monoses (jani)
summary: - PulseAudio assembler build errors on Beagleboard
+ PulseAudio package still uses -mimplicit-it=thumb in debian/rules
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pulseaudio - 1:0.9.22+stable-queue-24-g67d18-0ubuntu2

---------------
pulseaudio (1:0.9.22+stable-queue-24-g67d18-0ubuntu2) natty; urgency=low

  * Update to latest stable queue patches:
    - 09770e5 (module-loopback: Add adjust_time to valid args
    - 90c5520 (Limit rate adjustments to small, inaudible jumps
    - 4620039 (module-rtp-recv: Use new algorithm for adjusting sample rate
    - 2bfc032 (module-rtp-recv: Average the estimated real sample rate
    - 2ee4ec5 (module-rtp-recv: Remove smoother from write index (LP: #569378)
    - a8cd9d2 (conf: Make system.pa use udev-detect and not hal-detect.
    - b872254 (volume: Add a PA_VOLUME_UI_MAX define for the recommended max
               volume to show in UIs)
  * 0210-PulseAudio-added-IT-block-to-fix-thumb-conditional-i.patch:
    - added IT block to fix thumb conditional instruction build error messages
  * debian/rules: Remove CFLAGS that are specific to arm, the above patch
    makes those redundant (LP: #721498)
  * debian/control: Add a dependency on pulseaudio-module-raop
 -- Luke Yelavich <email address hidden> Thu, 10 Mar 2011 07:15:02 +1100

Changed in pulseaudio (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.