Call to fwts_passed is missing in some tests
Bug #715755 reported by
Sylvain Pineau
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
fwts (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: fwts
I've launched fwts with the following command : sudo fwts --results-
Looking at the summary, I found that acpicinstance, biosinfo, smbios and wmi test cases didn't returned a "Passed" status.
It seems that a call to fwts_passed() is needed to register the status in the framework.
Tested with fwts, Version V0.21.07, Wed Feb 9 11:08:04 GMT 2011
To post a comment you must log in.
Thanks Sylvain for spotting these mistakes.
I've address this issue in several ways:
1. Some tests didn't report any pass/fail since they were just collecting data - this is useful to allow one to identify a machine or sanity check the firmware. In this case, these tests returned a "information" state, rather that a pass/fail/ aborted/ skipped state.
2. Other tests, such as apicinstance were definitely missing the fwts_passed() state setting call, so I've added that.
3. Some tests (not those listed in comment #1) were not reporting pass/failed because they could not proceed with the test, e.g. no virtualisation support, missing tables, so these tests I've marked as "skipped" tests because we cannot run them.
The updated version is in the fwts devel ppa: ppa:firmware- testing- team/ppa- fwts-devel
please let me know if this resolves the issue. Then I can get this uploaded into universe. Thanks.