QUERY_RESPONSE_TIME useless names of columns

Bug #712390 reported by Oleg Tsarev
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Won't Fix
Wishlist
Stewart Smith

Bug Description

Peter letter:
mysql> select * from information_schema.QUERY_RESPONSE_TIME;
+----------------+-------+----------------+
| time | count | total |
+----------------+-------+----------------+
| 0.000001 | 0 | 0.000000 |
| 0.000010 | 1 | 0.000004 |
| 0.000100 | 7 | 0.000578 |
| 0.001000 | 5 | 0.000850 |
| 0.010000 | 0 | 0.000000 |
| 0.100000 | 0 | 0.000000 |
| 1.000000 | 0 | 0.000000 |
| 10.000000 | 1 | 2.893884 |
| 100.000000 | 0 | 0.000000 |
| 1000.000000 | 0 | 0.000000 |
| 10000.000000 | 0 | 0.000000 |
| 100000.000000 | 0 | 0.000000 |
| 1000000.00000 | 0 | 0.000000 |
| TOO LONG | 0 | TOO LONG |
+----------------+-------+----------------+
14 rows in set (0.00 sec)

Who could come up with name "total" which is absolutely descriptive. total_time or something would be a lot nicer assuming it is time in seconds. Otherwise it is total what

Revision history for this message
Oleg Tsarev (tsarev) wrote :

This is usability bug.
Think about comfortable usage feature "response time distribution" and about backward-compatible too please

Changed in percona-server:
assignee: nobody → Valentine Gostev (core-longbow)
Revision history for this message
Peter Zaitsev (pz-percona) wrote : Re: [Bug 712390] [NEW] QUERY_RESPONSE_TIME useless names of columns
Download full text (3.3 KiB)

Oleg,

I suggest We rename "TOO LONG" values too which kind of look lame :)

I would suggest to use "inf" Which stands for infinum/infinity and I think
it is actually what string representation
of too long value will show. Or we might use the full work infinity :)

On Thu, Feb 3, 2011 at 3:36 AM, Oleg Tsarev <email address hidden> wrote:

> Public bug reported:
>
> Peter letter:
> mysql> select * from information_schema.QUERY_RESPONSE_TIME;
> +----------------+-------+----------------+
> | time | count | total |
> +----------------+-------+----------------+
> | 0.000001 | 0 | 0.000000 |
> | 0.000010 | 1 | 0.000004 |
> | 0.000100 | 7 | 0.000578 |
> | 0.001000 | 5 | 0.000850 |
> | 0.010000 | 0 | 0.000000 |
> | 0.100000 | 0 | 0.000000 |
> | 1.000000 | 0 | 0.000000 |
> | 10.000000 | 1 | 2.893884 |
> | 100.000000 | 0 | 0.000000 |
> | 1000.000000 | 0 | 0.000000 |
> | 10000.000000 | 0 | 0.000000 |
> | 100000.000000 | 0 | 0.000000 |
> | 1000000.00000 | 0 | 0.000000 |
> | TOO LONG | 0 | TOO LONG |
> +----------------+-------+----------------+
> 14 rows in set (0.00 sec)
>
> Who could come up with name "total" which is absolutely descriptive.
> total_time or something would be a lot nicer assuming it is time in
> seconds. Otherwise it is total what
>
> ** Affects: percona-server
> Importance: Undecided
> Assignee: Valentine Gostev (core-longbow)
> Status: New
>
> ** Changed in: percona-server
> Assignee: (unassigned) => Valentine Gostev (core-longbow)
>
> --
> You received this bug notification because you are a member of Percona
> developers, which is the registrant for Percona Server.
> https://bugs.launchpad.net/bugs/712390
>
> Title:
> QUERY_RESPONSE_TIME useless names of columns
>
> Status in Percona Server with XtraDB:
> New
>
> Bug description:
> Peter letter:
> mysql> select * from information_schema.QUERY_RESPONSE_TIME;
> +----------------+-------+----------------+
> | time | count | total |
> +----------------+-------+----------------+
> | 0.000001 | 0 | 0.000000 |
> | 0.000010 | 1 | 0.000004 |
> | 0.000100 | 7 | 0.000578 |
> | 0.001000 | 5 | 0.000850 |
> | 0.010000 | 0 | 0.000000 |
> | 0.100000 | 0 | 0.000000 |
> | 1.000000 | 0 | 0.000000 |
> | 10.000000 | 1 | 2.893884 |
> | 100.000000 | 0 | 0.000000 |
> | 1000.000000 | 0 | 0.000000 |
> | 10000.000000 | 0 | 0.000000 |
> | 100000.000000 | 0 | 0.000000 |
> | 1000000.00000 | 0 | 0.000000 |
> | TOO LONG | 0 | TOO LONG |
> +----------------+-------+----------------+
> 14 rows in set (0.00 sec)
>
> Who could come up with name "total" which is absolutely descriptive.
> total_time or something would be a lot nicer assuming it is time in
> seconds. Otherwise it is total what
>
>
>

--
Peter Zaitsev, CEO, Per...

Read more...

Revision history for this message
Baron Schwartz (baron-xaprb) wrote :

Renaming TOO_LONG is okay. Renaming the column headers is really
something that I think needs to be considered only if there is a
severe problem and an excellent solution. Right now the proposals
I've seen have only been "make a vague column name only slightly less
vague." This does not justify breaking things that depend on the
column names. For example, anyone who has installed the Cacti
templates I based on these columns will be impacted: the graphs will
stop collecting data if they upgrade their server.

Revision history for this message
Stewart Smith (stewart) wrote :

The fact that the column name sucks, does indeed suck.

However, not willing to break things for people for something this small, so setting as Won't Fix.

We can change if patch is more widely adopted and column name changes there to conform with rest of world.

Changed in percona-server:
assignee: Valentine Gostev (core-longbow) → Stewart Smith (stewart)
importance: Undecided → Wishlist
status: New → Won't Fix
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2343

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.