delegate patch

Bug #705872 reported by Igor A Tarasov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rp-pppoe (Debian)
New
Unknown
rp-pppoe (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

pppoe-server starts pppd with local and remote IP addresses specified in command line even if this is not configured.
But if pppd using it's own configuration for endpoint addresses, then command line options, added by pppoe-server interfer with pppd configuration and precent from normal working. The are no any way to turn off this behaviour of pppoe-server and it adds it's own IP addresses to every spawned pppd.

I'm using radius plugin in pppd for authentication and address assigment, but when pppd starts from pppoe-server with addresses specified in command line, then pppd using this addresses instead of those, configured by radius server.

By analogy, pptpd daemon have configuration option "delegate", which turn off this behavior and delegate address assigment to pppd.

I created a patch for pppoe-server, which add new command line option "-D", which cause pppoe-server to skip adding local and remote addresses to pppd command line and delegate address assigment to pppd configuration.

This is working fine for me many years and I think it may be very usefull for other ISP like me. Please consider to include this patch to distribution.

Revision history for this message
Igor A Tarasov (dicr) wrote :
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

** This is an automated message **
Looking at the attachments in this bug report, I noticed that an attachment was not flagged as a patch. A patch contains changes to an Ubuntu package that will resolve a bug and this attachment is one! Subsequently, I've checked the patch flag for it. In the future when submitting patches please use the patch checkbox as there are some Launchpad searches that use this feature. You can learn more about the patch workflow at https://wiki.ubuntu.com/Bugs/Patches.

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rp-pppoe - 3.8-3ubuntu1

---------------
rp-pppoe (3.8-3ubuntu1) oneiric; urgency=low

  * Tweak and apply patch by Igor A Tarasov to resolve pppoe-server not
    honoring pppd's configured IP addresses. This patch adds a '-D'
    (delegate) option, similar to pptpd's, that causes pppoe-server to
    skip adding its own local and remote IP addresses to the pppd
    command line, thereby allowing pppd to perform address assignment
    properly. Thanks, Igor! (LP: #705872)
 -- Daniel T Chen <email address hidden> Fri, 22 Jul 2011 12:34:27 -0400

Changed in rp-pppoe (Ubuntu):
status: New → Fix Released
Daniel T Chen (crimsun)
tags: added: patch-forwarded-debian
removed: patch
Changed in rp-pppoe (Debian):
status: Unknown → New
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.