dhcp_filter applied in FirewallDriver for FlatManager

[Nachi Ueno]

The dhcp_filter applied in FirewallDriver for FlatManager which do not use DHCP server.

I think NetworkManager and FirewallDriver are mutually related, so some refactoring may be needed.

[Thierry Carrez (ttx)]

Trying to set Importance: what is the effect of the bug ? Does it break anything ? Or is it just superfluous ?

[Nachi Ueno (nati-ueno)]

I think it is it just superfluous, so this is not serious bug.
Unnecessary port ( This is for DHCP ) is opened.

[Thierry Carrez (ttx)]

OK, thanks !

[Mark McLoughlin (markmc)]

I think this is as simple as doing:

Fix for this is quite simple, I think. In setup_basic_filtering(), do:

   allow_dhcp = 'dhcp_server' in network_info

and pass that to ensure_static_filters() and only add the allow-dhcp-server rule if that's true

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/6569

[Hua Zhang (zhhuabj)]

someone can help me review the code, I have updated a new patch, many thanks.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/6569
Committed: http://github.com/openstack/nova/commit/763a3678407b244b680fd0bf2c6bcee60e8352c2
Submitter: Jenkins
Branch: master

commit 763a3678407b244b680fd0bf2c6bcee60e8352c2
Author: hua zhang <email address hidden>
Date: Wed May 9 14:11:00 2012 +0800

    Avoid setting up DHCP firewall rules with FlatManager

    Fixes bug #704737

    With FlatManager, ensure that the network info's dhcp_server value is not set
    and use that key to decide in the compute service whether DHCP firewall rules should be added.

    Change-Id: I8183a6fa3881adea1a09f3f1a29442e6b7a919ce

[Vish Ishaya (vishvananda)]

Tom, we use fix Committed until it is part of a milestone, at which point it is converted to fix released.