PPL

Merge details does not show which accounts are being merged.

Bug #701565 reported by Christopher Adams
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PPL
Fix Released
Critical
Bassel Safadi

Bug Description

The Merge Contacts button has a Details link, but it only displays the person's name in red. It should show exactly which accounts from which service are being merged.

Changed in ppl:
importance: Undecided → High
milestone: none → 0.2
Changed in ppl:
importance: High → Critical
rejon (rejon)
Changed in ppl:
status: New → Confirmed
assignee: nobody → Bassel Safadi (bassel)
Revision history for this message
Bassel Safadi (bassel) wrote :

Added that next to the email address where it shows from which service this contact duplicate is coming

Revision history for this message
Bassel Safadi (bassel) wrote :

please note the attached screen shot

Changed in ppl:
status: Confirmed → Fix Released
Revision history for this message
rejon (rejon) wrote : Re: [Bug 701565] Re: Merge details does not show which accounts are being merged.

that rocks.. great work

On Fri, Jan 21, 2011 at 8:50 AM, Bassel Safadi <email address hidden> wrote:
> please note the attached screen shot
>
> ** Changed in: ppl
>       Status: Confirmed => Fix Released
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/701565
>
> Title:
>  Merge details does not show which accounts are being merged.
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)
+852.9647,9389 (hongkong)
+65.8330.5807 (singapore)

Revision history for this message
Christopher Adams (christopheradams) wrote :

Why are both accounts in the screen shot attached to email addresses?

On Jan 21, 2011 9:35 AM, "rejon" <email address hidden> wrote:

that rocks.. great work

On Fri, Jan 21, 2011 at 8:50 AM, Bassel Safadi <email address hidden> wrote:
> please note the attached screen...
--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)
+852.9647,9389 (hongkong)
+65.8330.5807 (singapore)

--
You received this bug notification because you are a member of PPL
Developers, which is subscri...

Revision history for this message
Bassel Safadi (bassel) wrote :

because both accounts have the same email address. if there are two people with same name will make it easier to recognize them by email address if the emails are not the same

Revision history for this message
Christopher Adams (christopheradams) wrote :

But how does an email address get associated with a Twitter account before
the merge takes place? I must be missing something....

On Mon, Jan 24, 2011 at 1:07 PM, Bassel Safadi <email address hidden> wrote:

> because both accounts have the same email address. if there are two
> people with same name will make it easier to recognize them by email
> address if the emails are not the same
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/701565
>
> Title:
> Merge details does not show which accounts are being merged.
>
> Status in PPL:
> Fix Released
>
> Bug description:
> The Merge Contacts button has a Details link, but it only displays the
> person's name in red. It should show exactly which accounts from which
> service are being merged.
>
>
>

Revision history for this message
Bassel Safadi (bassel) wrote :

dude, in this example I duplicated the record manullay. that's why you see the email

Revision history for this message
Christopher Adams (christopheradams) wrote :

Bassel, this needs a more info about which contacts are being merged, including the actual username or email address, before I can consider this fixed.

Here is an example what it should look like:

Bassel Safadi - (2 contacts) - details

Bassel Safadi
  Twitter http://twitter.com/basselsafadi
  Flickr http://www.flickr.com/photos/bassel_safadi/

Notes:
The Twitter and Flickr can be replaced by the blue service icon.
The URLs should be clickable links.
Each details section should be styled as a real list. The design of the details is really weak. Do I need to be more specific about this?

Changed in ppl:
status: Fix Released → In Progress
Revision history for this message
rejon (rejon) wrote :

christopher took this over.

On Wed, Jan 26, 2011 at 8:02 PM, Christopher Adams <email address hidden> wrote:
> Bassel, this needs a more info about which contacts are being merged,
> including the actual username or email address, before I can consider
> this fixed.
>
> Here is an example  what it should look like:
>
> Bassel Safadi - (2 contacts) - details
>
> Bassel Safadi
>  Twitter     http://twitter.com/basselsafadi
>  Flickr       http://www.flickr.com/photos/bassel_safadi/
>
> Notes:
> The Twitter and Flickr can be replaced by the blue service icon.
> The URLs should be clickable links.
> Each details section should be styled as a real list. The design of the details is really weak. Do I need to be more specific about this?
>
> ** Changed in: ppl
>       Status: Fix Released => In Progress
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/701565
>
> Title:
>  Merge details does not show which accounts are being merged.
>

--
Jon Phillips
http://rejon.org/ | http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global) | +4915155318427 (berlin)

Changed in ppl:
assignee: Bassel Safadi (bassel) → Christopher Adams (christopher-w-adams)
assignee: Christopher Adams (christopher-w-adams) → Christopher Adams (christopheradams)
Revision history for this message
Christopher Adams (christopher-w-adams) wrote :

To whom it may concern --

I don't know how I got on the Launchpad list as a bug fixer. The only
thing I can think of is that someone else with my name signed up for
this, and I am getting his mail by mistake. I have been trying to get
off the list for some time, but couldn't find any option to
unsubscribe at the website. I don't even know what program is being
referred to here, let alone how to fix it. Please remove me from this
list.

Chris Adams.

On Thu, Feb 3, 2011 at 11:10 AM, rejon <email address hidden> wrote:
> ** Changed in: ppl
>     Assignee: Bassel Safadi (bassel) => Christopher Adams (christopher-w-adams)
>
> ** Changed in: ppl
>     Assignee: Christopher Adams (christopher-w-adams) => Christopher Adams (christopheradams)
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/701565
>
> Title:
>  Merge details does not show which accounts are being merged.
>
> Status in PPL:
>  In Progress
>
> Bug description:
>  The Merge Contacts button has a Details link, but it only displays the
>  person's name in red. It should show exactly which accounts from which
>  service are being merged.
>
>
>

Revision history for this message
rejon (rejon) wrote :

weird, i tried to remove you, lets see if that works

On Sun, Feb 6, 2011 at 4:56 PM, Christopher Adams
<email address hidden> wrote:
> To whom it may concern --
>
> I don't know how I got on the Launchpad list as a bug fixer. The only
> thing I can think of is that someone else with my name signed up for
> this, and I am getting his mail by mistake. I have been trying to get
> off the list for some time, but couldn't find any option to
> unsubscribe at the website. I don't even know what program is being
> referred to here, let alone how to fix it. Please remove me from this
> list.
>
> Chris Adams.
>
>
> On Thu, Feb 3, 2011 at 11:10 AM, rejon <email address hidden> wrote:
>> ** Changed in: ppl
>>     Assignee: Bassel Safadi (bassel) => Christopher Adams (christopher-w-adams)
>>
>> ** Changed in: ppl
>>     Assignee: Christopher Adams (christopher-w-adams) => Christopher Adams (christopheradams)
>>
>> --
>> You received this bug notification because you are a bug assignee.
>> https://bugs.launchpad.net/bugs/701565
>>
>> Title:
>>  Merge details does not show which accounts are being merged.
>>
>> Status in PPL:
>>  In Progress
>>
>> Bug description:
>>  The Merge Contacts button has a Details link, but it only displays the
>>  person's name in red. It should show exactly which accounts from which
>>  service are being merged.
>>
>>
>>
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/701565
>
> Title:
>  Merge details does not show which accounts are being merged.
>

--
Jon Phillips
http://rejon.org/ | http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global) | +4915155318427 (berlin)

Revision history for this message
Christopher Adams (christopheradams) wrote :

This is looking better, but needs all the info.

Now it reads:

[icon] http://twitter.com/ - twitter

To improve it:
  Remove the "- twitter"
  Change the URL to the user's ppl_service_users.user_profile

Revision history for this message
Christopher Adams (christopheradams) wrote :

Move the checkbox to the right of the User's name.

Revision history for this message
Christopher Adams (christopheradams) wrote :

The checkbox has just replaced the » symbol next to the user's name.

Revision history for this message
Bassel Safadi (bassel) wrote :

yeah true, I replaced it. is that ok?

Revision history for this message
Bassel Safadi (bassel) wrote :

ok only one email is stored, the other emails are lost. need to add this

Revision history for this message
Bassel Safadi (bassel) wrote :

ok reported another bug here https://bugs.launchpad.net/ppl/+bug/716795 and closing this one, since the merge is now showing which services are being merged and it works!

Changed in ppl:
assignee: Christopher Adams (christopheradams) → Bassel Safadi (bassel)
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.