Sony F series "assist" and "vaio" buttons not recognized by sony-laptop

[Alex Lowe]

The "assist" and "vaio" buttons on Sony Vaio F series laptops are not recognized (although ACPI events are still sent).

In checking dmesg, I receive the following errors:

For the assist button:
[84044.545156] sony-laptop: Unknown event: 0x100 0xa6
[84044.946497] sony-laptop: Unknown event: 0x100 0x26

For the Vaio button:
[84119.820688] sony-laptop: Unknown event: 0x100 0xa5
[84119.940642] sony-laptop: Unknown event: 0x100 0x25

These are consistent with a keypress and a key release.

I have included a patch to sony-laptop.c (contained in drivers/platform/x86 in the Linux source). This patch was written for 2.6.35, but works on 2.6.37 (downloaded tonight from http://packages.ubuntu.com/natty/linux-source-2.6.37).

[Andy Whitcroft (apw)]

That patch looks promising. It probabally should be sent upstream for review. The maintainers for the sony-laptop driver can be found here:

M: Mattia Dongili <email address hidden>
L: <email address hidden>

[Alex Lowe (lengau)]

There is already an upstream patch for this and other buttons. I
believe it's scheduled for release in 2.6.38.

On 19 January 2011 05:32, Andy Whitcroft <email address hidden> wrote:
> That patch looks promising.  It probabally should be sent upstream for
> review.  The maintainers for the sony-laptop driver can be found here:
>
> M:      Mattia Dongili <email address hidden>
> L:      <email address hidden>
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/695919
>
> Title:
>  Sony F series "assist" and "vaio" buttons not recognized by sony-
>  laptop
>
> Status in “linux” package in Ubuntu:
>  New
>
> Bug description:
>  The "assist" and "vaio" buttons on Sony Vaio F series laptops are not
>  recognized (although ACPI events are still sent).
>
>  In checking dmesg, I receive the following errors:
>
>  For the assist button:
>  [84044.545156] sony-laptop: Unknown event: 0x100 0xa6
>  [84044.946497] sony-laptop: Unknown event: 0x100 0x26
>
>  For the Vaio button:
>  [84119.820688] sony-laptop: Unknown event: 0x100 0xa5
>  [84119.940642] sony-laptop: Unknown event: 0x100 0x25
>
>  These are consistent with a keypress and a key release.
>
>  I have included a patch to sony-laptop.c (contained in
>  drivers/platform/x86 in the Linux source). This patch was written for
>  2.6.35, but works on 2.6.37 (downloaded tonight from
>  http://packages.ubuntu.com/natty/linux-source-2.6.37).
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/695919/+subscribe
>

[Andy Whitcroft (apw)]

@Alex -- I don't see the equivalent of your change there upstream as yet. Can you point me to the discussion on the patch please.

[Alex Lowe (lengau)]

I'm sorry - the discussion where I was told this took place over
e-mail with the maintainer after sending in this patch.

On 25 January 2011 07:43, Andy Whitcroft <email address hidden> wrote:
> @Alex -- I don't see the equivalent of your change there upstream as
> yet.  Can you point me to the discussion on the patch please.
>
> ** Changed in: linux (Ubuntu)
>       Status: New => Incomplete
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/695919
>
> Title:
>  Sony F series "assist" and "vaio" buttons not recognized by sony-
>  laptop
>
> Status in “linux” package in Ubuntu:
>  Incomplete
>
> Bug description:
>  The "assist" and "vaio" buttons on Sony Vaio F series laptops are not
>  recognized (although ACPI events are still sent).
>
>  In checking dmesg, I receive the following errors:
>
>  For the assist button:
>  [84044.545156] sony-laptop: Unknown event: 0x100 0xa6
>  [84044.946497] sony-laptop: Unknown event: 0x100 0x26
>
>  For the Vaio button:
>  [84119.820688] sony-laptop: Unknown event: 0x100 0xa5
>  [84119.940642] sony-laptop: Unknown event: 0x100 0x25
>
>  These are consistent with a keypress and a key release.
>
>  I have included a patch to sony-laptop.c (contained in
>  drivers/platform/x86 in the Linux source). This patch was written for
>  2.6.35, but works on 2.6.37 (downloaded tonight from
>  http://packages.ubuntu.com/natty/linux-source-2.6.37).
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/695919/+subscribe
>

[Julian Wiedmann (jwiedmann)]

Andy:
Seems like this change landed upstream (and in Natty) as part of:

1a7d946993aaf2a79e9c65abbe169a108e351bcb
sony-laptop: support new hotkeys on the P, Z and EC series

Add new mappings for assist, VAIO, zoom and eject buttons present on
refurbished P, Z and EC models.