[RC1]Two same fields creating problem in web-client

[Ravindra Mekhiya(OpenERP)]

Hello,

Step to re-produce :

1. Install hr_holoday and hr_payroll in new databse with demo data.
2. Go to : Human Resources/Configuration/Holidays/Leave Type.
3. Edit Leave Type.

Here is the tracback at web-client side :

------------------------------
 malformed view for: hr.holidays.status
 duplicate field: active
------------------------------
[30/Dec/2010:15:42:30] HTTP Traceback (most recent call last):
  File "/usr/lib/pymodules/python2.6/cherrypy/_cprequest.py", line 606, in respond
    cherrypy.response.body = self.handler()
  File "/usr/lib/pymodules/python2.6/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/rme/workspace/trunk/web_trunk/openobject/tools/_expose.py", line 191, in func_wrapper
    res = func(*args, **kw)
  File "/home/rme/workspace/trunk/web_trunk/openobject/controllers/_root.py", line 85, in default
    return request.handler()
  File "/usr/lib/pymodules/python2.6/cherrypy/_cpdispatch.py", line 25, in __call__
    return self.callable(*self.args, **self.kwargs)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/controllers/utils.py", line 120, in wrapper
    return fn(*args, **kw)
  File "/home/rme/workspace/trunk/web_trunk/openobject/tools/_expose.py", line 191, in func_wrapper
    res = func(*args, **kw)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/controllers/form.py", line 338, in edit
    return self.create(params)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/controllers/utils.py", line 120, in wrapper
    return fn(*args, **kw)
  File "/home/rme/workspace/trunk/web_trunk/openobject/tools/_expose.py", line 191, in func_wrapper
    res = func(*args, **kw)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/controllers/form.py", line 204, in create
    form = self.create_form(params, tg_errors)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/controllers/form.py", line 195, in create_form
    return tw.form_view.ViewForm(params, name="view_form", action="/openerp/form/save")
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form_view.py", line 93, in __init__
    selectable=params.selectable or 2)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/screen.py", line 111, in __init__
    self.add_view_id(self.view_id, self.view_type)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/screen.py", line 125, in add_view_id
    self.add_view(view, view_type)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/screen.py", line 133, in add_view
    self.widget = get_view_widget(view_type, self)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/_views.py", line 137, in get_view_widget
    return view(screen)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/_views.py", line 66, in __call__
    nodefault=screen.nodefault, nolinks=screen.link)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 812, in __init__
    self.frame = self.parse(prefix, dom, fields, values)[0]
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 872, in parse
    n = self.parse(prefix=prefix, root=node, fields=fields, values=values)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 876, in parse
    n = self.parse(prefix=prefix, root=node, fields=fields, values=values)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 883, in parse
    n = self.parse(prefix=prefix, root=node, fields=fields, values=values)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 887, in parse
    n = self.parse(prefix=prefix, root=node, fields=fields, values=values)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/widgets/form/_form.py", line 911, in parse
    raise common.error(_('Application Error'), _('Invalid view, duplicate field: %s') % name)
  File "/home/rme/workspace/trunk/web_trunk/addons/openerp/utils/common.py", line 74, in error
    raise TinyError(message=msg, title=title or _("Error"))
TinyError: Invalid view, duplicate field: active

The view 'edit_holiday_status_form' is having field name 'active' and same field is appearing in the inherited view of 'view_holiday_status_form1'.

Thanks.

[Ferdinand (office-chricar)]

IMHO duplicate fields should be checked and reported as it can happen easily - especially using inherited views and someone adds the field to the source later.

[Meera Trambadia (OpenERP) (mtr-openerp)]

Hello RME,

I have fixed the bug in https://code.launchpad.net/~openerp-commiter/openobject-addons/trunk-dev-addons3-mtr1 branch.
Revision ID: mtr@mtr-20110103061953-jx80offy0hkd8cin
Revision no: 4671

Thanks
mtr