Failing to store a token in the keyring results in a verification email
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu Single Sign On Client |
Fix Released
|
High
|
Natalia Bidart |
Bug Description
Under certain circumstances, when you sign in using your standard SSO creds ubuntu-sso-client will say it has sent you a verification email, even though your email is already verified. What's worse, this verification email is then never sent/received.
nessita pointed at the following lines of code:
main.py:197:
if is_validated:
# pylint: disable=E1101
d = Keyring(
That say the real problem is that the app is failing to store the newly created token in the keyring, and is then emitting UserNotValidated (instead of LoginError), that triggers the message saying a verification email has been sent. This email is then not sent at all, as the email is actually already verified.
The other (underlying) question is why the keyring is refusing to store the credentials at all.
Related branches
- Manuel de la Peña (community): Approve
- Roberto Alsina (community): Approve
-
Diff: 79 lines (+41/-3)2 files modifiedubuntu_sso/main.py (+3/-1)
ubuntu_sso/tests/test_main.py (+38/-2)
Changed in ubuntu-sso-client: | |
status: | New → Confirmed |
importance: | Undecided → High |
Changed in ubuntu-sso-client: | |
status: | Confirmed → In Progress |
assignee: | nobody → Naty Bidart (nataliabidart) |
Changed in ubuntu-sso-client: | |
status: | In Progress → Fix Committed |
Changed in ubuntu-sso-client: | |
status: | Fix Committed → Fix Released |