ltspfs_entry uses nonexistent blkid variable ID_FS_LABEL_SAFE to generate mountpoint
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
LTSP5 |
Fix Released
|
Undecided
|
Unassigned | ||
ltspfs (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: ltspfs
If I plug in a USB disk to an LTSP terminal, it always gets a name like "usbdisk-sdb1".
It seems that this part of ltspfs_entry tries to generate a human-readable label in add_device():
[ -z "${LABEL}" ] && LABEL=$
However this environment variable is not set by udev/blkid. Example output:
manager@
ID_FS_LABEL=
ID_FS_LABEL_
ID_FS_UUID=
ID_FS_UUID_
ID_FS_SEC_TYPE=ext2
ID_FS_TYPE=ext3
It seems that ID_FS_LABEL is now "safe", see util-linux/
} else if (!strcmp(name, "UUID") ||
So I think the following patch is appropriate:
manager@
--- lib/udev/
+++ lib/udev/
@@ -247,7 +247,7 @@
;;
esac
- [ -z "${LABEL}" ] && LABEL=$
+ [ -z "${LABEL}" ] && LABEL="
[ -z "${LABEL}" ] && LABEL="
# Check for existing label with same name
Changed in ltspfs (Ubuntu): | |
status: | New → Triaged |
Changed in ltsp: | |
status: | New → Fix Committed |
Changed in ltsp: | |
status: | Fix Committed → Fix Released |
This bug was fixed in the package ltspfs - 0.9-0ubuntu1
---------------
ltspfs (0.9-0ubuntu1) oneiric; urgency=low
* New upstream release (0.9)
- ID_FS_LABEL is now usually 'safe'. Patch from gcc (LP: #690969)
- cdpinger: add support for UDF formatted CDs and DVDs.
-- Stephane Graber <email address hidden> Thu, 11 Aug 2011 12:09:58 -0400