[SRU] typo in completion for openssl x509

[Marian Sigler]

Binary package hint: bash-completion

TEST CASE:

If you write openssl x509 and press TAB there is `-subject-hash` but must be `-subject_hash`.

Regression:

I think there is no options for regression, I only modify specific files in contrib/ dir.

[Benjamin Drung (bdrung)]

Angel, the patch author is wrong. Marian wrote the patch, you applied the patch and added the DEP3 header.

[Angel Abad (angelabad)]

Opps! Sorry, you're right, I will upload new debdiff with this issue solved.

Thanks!

[Angel Abad (angelabad)]

Re-upload debdiff with patch author fixed.

[Artur Rona (ari-tczew)]

In debian/changelog rather use:

  [ Marian Sigler ]
  * debian/patches/fix_typo_in_openssl_completion:
    - Fix typo in openssl completion. (LP: #690644)

In patch please use tag 'Author' for Marian and 'From' for you, Angel.

What about forwarding upstream?

[Artur Rona (ari-tczew)]

OK, David Paleino uploaded it to git upstream. Please add tag:
Origin: upstream, http://git.debian.org/?p=bash-completion/bash-completion.git;a=commit;h=5f04a30f7ab561dc99054445a7f635f3df3a0747

[Benjamin Drung (bdrung)]

Where is the debdiff? The original debian/changelog was ok.

[Angel Abad (angelabad)]

Re-upload debdiff with all issues fixed.

Thanks!

[Angel Abad (angelabad)]

@Benjamin: The debdiff is uploaded, I applied the Artur's suggested change in debian/changelog, should I revert this change?

Thanks for your advices!

[Launchpad Janitor (janitor)]

This bug was fixed in the package bash-completion - 1:1.2-3ubuntu3

---------------
bash-completion (1:1.2-3ubuntu3) natty; urgency=low

  [ Marian Sigler ]
  * debian/patches/fix_typo_in_openssl_completion.patch:
    - Fix typo in openssl completion (LP: #690644)
 -- Angel Abad <email address hidden> Mon, 10 Jan 2011 20:57:38 +0100

[Benjamin Drung (bdrung)]

@Angel: You can keep it. Both are ok.

I uploaded it with one small change: I added ".patch" to the patch filename.

[Marian Sigler (maix42)]

Woah what a lot of mails ... Thanks :-) (Seeing the debdiff I must say I could have done that myself ;-) )

[Angel Abad (angelabad)]

Debdiff for maverick-proposed.

[Kees Cook (kees)]

Thanks for the maverick patch! This looks good; I'll get it uploaded for testing in -proposed.

[Kees Cook (kees)]

This has been uploaded to -proposed. Once it has built, please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Thank you in advance!

[Martin Pitt (pitti)]

Accepted bash-completion into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Angel Abad (angelabad)]

maverick-proposed package works well for me.

[Fabri Velas (fabrivelas)]

The maverick-proposed package now gives the right `-subject_hash` when tab completion is used. Thanks.

[Launchpad Janitor (janitor)]

This bug was fixed in the package bash-completion - 1:1.2-2ubuntu1.1

---------------
bash-completion (1:1.2-2ubuntu1.1) maverick-proposed; urgency=low

  * debian/patches/fix_typo_in_openssl_completion:
    - Fix typo in openssl completion (LP: #690644)
  * debian/patches/fix_p4_completion.patch:
    - Fix p4 completion (LP: #652104)
 -- Angel Abad <email address hidden> Mon, 10 Jan 2011 18:07:59 +0100