Ticker feed with a negative timezone in pubDatefails
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Xibo |
Fix Released
|
Low
|
Dan Garner | ||
1.2 |
Fix Released
|
Medium
|
Dan Garner | ||
1.3 |
Fix Released
|
Low
|
Dan Garner |
Bug Description
When the pubDate in a feed has a timezone appended to the end of pubDate, the [date] field fails with a result of
01/01/0001 12:00:00 AM
As an example to reproduce add any feed from Yahoo Pipes, e.g.
http://
Notice in the feed the dates:
<pubDate>Thu, 09 Dec 2010 02:21:18 -0800</pubDate>
These get shown as 01/01/0001 12:00:00 AM
If the cached xml is manually tweaked to remove the negative: e.g.:
<pubDate>Thu, 09 Dec 2010 02:21:18 0800</pubDate>
<pubDate>Thu, 09 Dec 2010 02:21:18 +0800</pubDate>
<pubDate>Thu, 09 Dec 2010 02:21:18</pubDate>
All the above display as 09/12/2010 02:21:18 AM
I would like to suggest a two step fix:
1) Bug: fix the code to ignore the -
2) Enhancement(?): Add code to support feeds with non UTC times.
Related branches
- Xibo Maintainters: Pending requested
-
Diff: 468 lines (+88/-69)12 files modifiedclient/dotNET/FileCollector.cs (+9/-1)
client/dotNET/MainForm.cs (+43/-40)
client/dotNET/Properties/Settings.Designer.cs (+1/-1)
client/dotNET/Properties/Settings.settings (+1/-1)
client/dotNET/Region.cs (+8/-0)
client/dotNET/RssReader.cs (+1/-1)
client/dotNET/Web References/xmds/Reference.cs (+19/-19)
client/dotNET/Web References/xmds/Reference.map (+1/-1)
client/dotNET/Web References/xmds/xmds.wsdl (+1/-1)
client/dotNET/XiboClient.csproj (+2/-2)
client/dotNET/app.config (+1/-1)
server/lib/service/xmdssoap.class.php (+1/-1)
- Xibo Maintainters: Pending requested
-
Diff: 499 lines (+93/-73)13 files modifiedclient/dotNET/FileCollector.cs (+9/-1)
client/dotNET/MainForm.cs (+43/-40)
client/dotNET/Properties/Resources.Designer.cs (+1/-1)
client/dotNET/Properties/Settings.Designer.cs (+1/-1)
client/dotNET/Properties/Settings.settings (+1/-1)
client/dotNET/Region.cs (+8/-0)
client/dotNET/RssReader.cs (+1/-1)
client/dotNET/Web References/xmds/Reference.cs (+19/-19)
client/dotNET/Web References/xmds/Reference.map (+1/-1)
client/dotNET/Web References/xmds/xmds.wsdl (+1/-1)
client/dotNET/XiboClient.csproj (+6/-5)
client/dotNET/app.config (+1/-1)
server/lib/service/xmdssoap.class.php (+1/-1)
- Xibo Maintainters: Pending requested
-
Diff: 966 lines (+292/-373)8 files modifiedclient/dotNET/Media.cs (+3/-0)
client/dotNET/Properties/AssemblyInfo.cs (+1/-1)
client/dotNET/Region.cs (+6/-0)
client/dotNET/Rss.cs (+188/-160)
client/dotNET/RssReader.cs (+0/-207)
client/dotNET/XiboClient.csproj (+8/-1)
server/lib/include.php (+1/-1)
server/modules/ticker.module.php (+85/-3)
Changed in xibo: | |
status: | New → Opinion |
This came up before. I'll see if I can find what the fix was.