Ticker feed with a negative timezone in pubDatefails

Bug #690587 reported by Jay Munro
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Low
Dan Garner
1.2
Fix Released
Medium
Dan Garner
1.3
Fix Released
Low
Dan Garner

Bug Description

When the pubDate in a feed has a timezone appended to the end of pubDate, the [date] field fails with a result of
01/01/0001 12:00:00 AM

As an example to reproduce add any feed from Yahoo Pipes, e.g.
http://pipes.yahoo.com/pipes/pipe.run?_id=417bc9bf8f2542d12974dfcffeb3a61a&_render=rss

Notice in the feed the dates:
<pubDate>Thu, 09 Dec 2010 02:21:18 -0800</pubDate>

These get shown as 01/01/0001 12:00:00 AM

If the cached xml is manually tweaked to remove the negative: e.g.:
<pubDate>Thu, 09 Dec 2010 02:21:18 0800</pubDate>
<pubDate>Thu, 09 Dec 2010 02:21:18 +0800</pubDate>
<pubDate>Thu, 09 Dec 2010 02:21:18</pubDate>

All the above display as 09/12/2010 02:21:18 AM

I would like to suggest a two step fix:
1) Bug: fix the code to ignore the -
2) Enhancement(?): Add code to support feeds with non UTC times.

Related branches

Revision history for this message
Alex Harrington (alexharrington) wrote : Re: [Bug 690587] [NEW] Ticker feed with a negative timezone inpubDatefails

This came up before. I'll see if I can find what the fix was.

Revision history for this message
Alex Harrington (alexharrington) wrote :

What version version are you running?

There's an identical bug that was fixed for 1.2.0

https://bugs.launchpad.net/xibo/+bug/645307

Alex

Revision history for this message
Jay Munro (munro-dsty) wrote : Re: [Bug 690587] Re: Ticker feed with a negative timezone in pubDatefails

We are running 1.2.0 Windows client.

If this was already fixed then there must be some special conditions that we have that are causing this. It could be the client or the feed. Can you try running the Yahoo Pipes feed?
http:// pipes.yahoo. com/pipes/ pipe.run? _id=417bc9bf8f2 542d12974dfcffe b3a61a& _render= rss

John

----- Original Message -----
From: "Alex Harrington" <email address hidden>
To: <email address hidden>
Sent: Wednesday, 15 December, 2010 8:46:47 PM
Subject: [Bug 690587] Re: Ticker feed with a negative timezone in pubDatefails

What version version are you running?

There's an identical bug that was fixed for 1.2.0

https://bugs.launchpad.net/xibo/+bug/645307

Alex

--
You received this bug notification because you are a direct subscriber
of the bug.
https://bugs.launchpad.net/bugs/690587

Title:
Ticker feed with a negative timezone in pubDatefails

Changed in xibo:
status: New → Opinion
Revision history for this message
Alex Harrington (alexharrington) wrote :

I've not tested this still, but looking at the patch from the previous version of this bug I think I can see why it's still happening.

I think the code that removes the timezone from the string needs a little adjustment.

Changed in xibo:
status: Opinion → Confirmed
Revision history for this message
Alex Harrington (alexharrington) wrote :

A fix for this should drop out from this blueprint:
https://blueprints.launchpad.net/xibo/+spec/improve-net-rss-handling

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.