Allow owners to merge contacts

[Brad Phillips]

As an owner, I want a to be able to identify and merge contacts.

[Bassel Safadi (bassel)]

partly implemented on http://pple.aikilab.com/users/merge

so current merge, merges emails based on full names, because I just found out that the services are moved outside aiki_users to separate table which broke the merge. I'll try to: 1- understand how the new system work, 2- update the merge function to handle information in ppl_service_users

are there any other tables that store user data beside aiki_users and ppl_service_users?

[rejon (rejon)]

Ok, just to make sure, merge should not delete old data, and, it should also
allow for history on this and also if there is a conflict, require the owner
to review.

These should all emit notifications to the owner as well.

Jon

On Tue, Dec 14, 2010 at 12:37 PM, Bassel Safadi <email address hidden> wrote:

> partly implemented on http://pple.aikilab.com/users/merge
>
> so current merge, merges emails based on full names, because I just
> found out that the services are moved outside aiki_users to separate
> table which broke the merge. I'll try to: 1- understand how the new
> system work, 2- update the merge function to handle information in
> ppl_service_users
>
> are there any other tables that store user data beside aiki_users and
> ppl_service_users?
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688357
>
> Title:
> Allow owners to merge contacts
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)

+65.8330.5807 (singapore)

[Christopher Adams (christopheradams)]

Yes just those two tables contain the main user data. Each record in
ppl_services_users is owned by a user in aiki_users who is in turn owned by
an Owner. In the table ppl_portraits the field subject_id is also a pointer
to a user id in aiki_portraits.

On Dec 15, 2010 4:45 AM, "Bassel Safadi" <email address hidden> wrote:

partly implemented on http://pple.aikilab.com/users/merge

so current merge, merges emails based on full names, because I just
found out that the services are moved outside aiki_users to separate
table which broke the merge. I'll try to: 1- understand how the new
system work, 2- update the merge function to handle information in
ppl_service_users

are there any other tables that store user data beside aiki_users and
ppl_service_users?

--
You received this bug notification because you are a member of PPL
Developers, which is subscri...
 In Progress

Bug description:
As an owner, I want a to be able to identify and merge contacts.

[rejon (rejon)]

bassel, did you fix this yet?

[Christopher Adams (christopheradams)]

Yes, still waiting on this. Let me know Bassel if you have any questions
about the database design and how the user info is stored (for users,
services and photos). But it's really all there if you look at the tables.

On Tue, Dec 14, 2010 at 11:55 PM, Christopher Adams <email address hidden>wrote:

> Yes just those two tables contain the main user data. Each record in
> ppl_services_users is owned by a user in aiki_users who is in turn owned by
> an Owner. In the table ppl_portraits the field subject_id is also a pointer
> to a user id in aiki_portraits.
>
> On Dec 15, 2010 4:45 AM, "Bassel Safadi" <email address hidden> wrote:
>
> partly implemented on http://pple.aikilab.com/users/merge
>
> so current merge, merges emails based on full names, because I just
> found out that the services are moved outside aiki_users to separate
> table which broke the merge. I'll try to: 1- understand how the new
> system work, 2- update the merge function to handle information in
> ppl_service_users
>
> are there any other tables that store user data beside aiki_users and
> ppl_service_users?
>
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscri...
>
> In Progress
>
>
> Bug description:
> As an owner, I want a to be able to identify and merge contacts.
>
>

[Christopher Adams (christopheradams)]

I tested this. I merged about a dozen contacts. It doesn't work for me.

For example, after I import all my contacts, I have two Bassel Safadis.

One Bassel has a link to a Twitter account, the other has a link to a Flickr account.

After I merge, I should see one Bassel Safadi with both a Flickr account and Twitter account.

In fact, after I click Merge and see a success message, I can only find one Bassel Safadi with a Flickr account.

I can't find the other Bassel with a Twitter account. I do not see the Merge working.

[Brad Phillips (brad-bradphillips)]

I also experienced some issue with the merge. In my case, a contact had a Gmail & Twitter account. After merge (which did succeed in eliminated the same contact displaying twice in my people list), I only see an icon that links to their twitter page. The e-mail icon for the gmail contact is gone.

[rejon (rejon)]

same. same. same. I tested on <email address hidden> account, on the rejon account if you want to test....ugh....please next time this is fixed, test the fix.

[Christopher Adams (christopheradams)]

Starting to sketch out what this should look like: http://pple.aikilab.com/users/merge_next

[Christopher Adams (christopheradams)]

There are some additional cases that have to be considered in the Merge:

If the Owner has completed the Find Portraits task before the Merge, then each of the to-be-merged contacts will have the same pictures in ppl_portraits.

So, when a contact is Merged, it will be necessary to delete the duplicate entries in ppl_portaits.

If a record in aiki_users is deleted because it was merged, then all records in ppl_portraits should be deleted where subject_id = the deleted aiki_user.userid.

Likewise, any existing stories with that belong to the merged contacts must have their userid changed to the one Merged contact.

[Bassel Safadi (bassel)]

working on it right now

[Bassel Safadi (bassel)]

ok made some progress on implementing your design, where is a good place to have the check box for each contact?

http://pple.aikilab.com/users/merge_next doesn't have check boxs

[Christopher Adams (christopheradams)]

I think each service item should have a check box on the right side. If the
merged user has three services, the owner should be able to select none,
one, two, or three.

On Feb 8, 2011 2:01 AM, "Bassel Safadi" <email address hidden> wrote:

ok made some progress on implementing your design, where is a good place
to have the check box for each contact?

http://pple.aikilab.com/users/merge_next doesn't have check boxs

--
You received this bug notification because you are a member of PPL
Developers, which is subscri...
 In Progress

Bug description:
As an owner, I want a to be able to identify and merge contacts.

[Bassel Safadi (bassel)]

ok I finished styling the merge page as in Christopher design..
now working on the functionality of merging stories, photos and services

[Bassel Safadi (bassel)]

update: still working on this. it's more complicated than it looks.
update: added an index to full_name

[Bassel Safadi (bassel)]

ok update is working now when there are two services. it's still deleting the third service.. working to fix

[rejon (rejon)]

cool

On Thu, Feb 10, 2011 at 6:34 PM, Bassel Safadi <email address hidden> wrote:
> ok update is working now when there are two services. it's still
> deleting the third service.. working to fix
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688357
>
> Title:
>  Allow owners to merge contacts
>

--
Jon Phillips
http://rejon.org/ | http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (global) | [phone] (sf)

[Bassel Safadi (bassel)]

ok this works now, still have to add stories and photos merge

[Bassel Safadi (bassel)]

Merge works now!