Fix Settings page value checking

[Brad Phillips]

The settings page does not check for valid values before updating.

[Bassel Safadi (bassel)]

ha?
where is the settings page?
Christopher: could you please provide the link

[Christopher Adams (christopheradams)]

The settings form is handled by Widget 77, available at the URL
[root]/users/settings.

There is a link to that page in the header widget (31), but I commented that
out until the settings page is fixed.

On Sat, Dec 11, 2010 at 8:56 PM, Bassel Safadi <email address hidden> wrote:

> ha?
> where is the settings page?
> Christopher: could you please provide the link
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688356
>
> Title:
> Fix Settings page value checking
>
> Status in PPL:
> Triaged
>
> Bug description:
> The settings page does not check for valid values before updating.
>
>
>

[rejon (rejon)]

Can you just put up on that page what should go there? Brad, can you help on
that one.

jon

On Sat, Dec 11, 2010 at 5:20 AM, Christopher Adams <email address hidden>wrote:

> The settings form is handled by Widget 77, available at the URL
> [root]/users/settings.
>
> There is a link to that page in the header widget (31), but I commented
> that
> out until the settings page is fixed.
>
> On Sat, Dec 11, 2010 at 8:56 PM, Bassel Safadi <email address hidden> wrote:
>
> > ha?
> > where is the settings page?
> > Christopher: could you please provide the link
> >
> > --
> > You received this bug notification because you are a member of PPL
> > Developers, which is subscribed to PPL.
> > https://bugs.launchpad.net/bugs/688356
> >
> > Title:
> > Fix Settings page value checking
> >
> > Status in PPL:
> > Triaged
> >
> > Bug description:
> > The settings page does not check for valid values before updating.
> >
> >
> >
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688356
>
> Title:
> Fix Settings page value checking
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)

+65.8330.5807 (singapore)

[Christopher Adams (christopheradams)]

I removed the username from the settings form, since we agreed we won't let users change it for now.

Here is the current behavior

1) If the password is blank, the page outputs:

   Please enter a password

   Edited record 6309 in aiki_users successfully

2) If the email is blank, then the form will insert your email as being NULL!

3) There is a weird Save/Insert as new row pull-down menu that needs to be completely removed.

4) The user is supposed to receive an email saying that the settings have been updated, but this email never arrives. It should be sent to the old address if the address is the same or blank, or the new address if there is a new address entered.

Who can I assign this to? This is a mission-critical bug.

[Bassel Safadi (bassel)]

now both email and password verify before editing, and if left blank for password or email is not valid will not update

[Bassel Safadi (bassel)]

I'm closing this bug and moving the rest to two separate bugs in aiki:

https://bugs.launchpad.net/aikiframework/+bug/690245
https://bugs.launchpad.net/aikiframework/+bug/690246

[Bassel Safadi (bassel)]

removed the:
 weird Save/Insert as new row pull-down menu
by adding to the form a new field type: edit_type, value on right hand: save

[Bassel Safadi (bassel)]

number 4 added to blueprint:
https://blueprints.launchpad.net/aikiframework/+spec/send-email-on-edit

in progress now