PPL

People can't add stories

Bug #688355 reported by Brad Phillips
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PPL
Fix Released
Critical
Bassel Safadi

Bug Description

I've attempted adding stories to my synced gmail contacts on an iMac running Snow Leopard. After selecting the "Tell a Story.." link, the page hangs after the 'loading' bar & never finishes. Confirmed on latest FF, Chrome, and Safari.

Changed in ppl:
importance: Undecided → Critical
milestone: 0.2 → 0.1
status: New → Triaged
Revision history for this message
rejon (rejon) wrote : Re: [Bug 688355] Re: Owners can't add stories

Where is this at? Is it ready? creason?

On Fri, Dec 10, 2010 at 12:51 AM, Christopher Adams <email address hidden>wrote:

> ** Changed in: ppl
> Importance: Undecided => Critical
>
> ** Changed in: ppl
> Status: New => Triaged
>
> ** Changed in: ppl
> Milestone: 0.2 => 0.1
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688355
>
> Title:
> Owners can't add stories
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)

+65.8330.5807 (singapore)

Revision history for this message
Christopher Adams (christopheradams) wrote :

This is totally broken. The form is no longer displaying when the user
clicks "Add a story..."

Revision history for this message
rejon (rejon) wrote :

creason!

On Fri, Dec 10, 2010 at 1:50 AM, Christopher Adams <email address hidden>wrote:

> This is totally broken. The form is no longer displaying when the user
> clicks "Add a story..."
>
> --
> You received this bug notification because you are a member of PPL
> Developers, which is subscribed to PPL.
> https://bugs.launchpad.net/bugs/688355
>
> Title:
> Owners can't add stories
>

--
Jon Phillips
http://rejon.org/
http://fabricatorz.com/
chat/skype: kidproto | irc: rejon
+1.415.830.3884 (sf/global)
+86.187.1003.9974 (china)

+65.8330.5807 (singapore)

Revision history for this message
Christopher Adams (christopheradams) wrote : Re: Owners can't add stories

This bug is only reproducible so far me on Chrome on Ubuntu: both Chrome and Chromium are affected (even the nightly build), even with extensions off. Tested on both Lucid and Maverick.

Firefox however works.

Can anyone else confirm?

Revision history for this message
Christopher Adams (christopheradams) wrote :

Ok, so I'm pretty much convinced now it's not a browser issue. That was a red herring because Creason said it was working on his computer. It's definitely a permissions issue. I can add stories from my admin account but not from new owner accounts. Creason did you check the permissions?

Revision history for this message
Christopher Adams (christopheradams) wrote :

I can confirm that changing a user from usergroup 5 (People) to 1 (Owners) allows that user to add stories.

So somewhere the permission for viewing that widget is not getting set correctly.

An aside:

New users signing up to the site and importing their contacts are People. They should be able to add stories.

Keep in mind that Wwners are really more of a super-user position, although we have not really defined any corners of the site where Owners have more permissions than People.

The Owner will likely just be the one person who is actually running the site. They may have the power to, for example, delete other People.

But not view their content.

Revision history for this message
Christopher Adams (christopheradams) wrote :

Changed bug title to "People can't add Stories" from "Owner..."

summary: - Owners can't add stories
+ People can't add stories
Revision history for this message
Christopher Adams (christopheradams) wrote :

Do forms have concept of permissions?

Here is the output of two different users visiting the /story/add/((id)) page.

This is the output from an Owner:

<div id="form_container"><form action="http://pple.aikilab.com/index.php?pretty=story/add/6238" method="post" enctype="multipart/form-data" id="new_record_form" name="new_record_form">
  <div class='ppl_stories'></div><div class='id'></div><div class='updated_at'></div><div class='story_title'><h2>Title</h2><input type="text" id="story_title" name="story_title" dir="" value=""></div><div class='story_body'><h2>Story</h2><div id="story_body_container"><textarea rows="7" dir="" cols="50" id="story_body" name="story_body"></textarea></div></div><div class='owner'></div><div class='userid'></div><div class='created_at'></div><p class="form-buttons"><input type="hidden" value="25" name="form_id"><input type="submit" class="submit_button" value="Submit" name="add_to_form"></p></form></div>

Here is the output from a user with People permissions

<div id="form_container"><form action="http://pple.aikilab.com/index.php?pretty=story/add/6306" method="post" enctype="multipart/form-data" id="new_record_form" name="new_record_form">
  <div class='ppl_stories'></div><div class='id'></div><div class='updated_at'></div><div class='story_title'></div><div class='story_body'></div><div class='owner'></div><div class='userid'></div><div class='created_at'></div><p class="form-buttons"><input type="hidden" value="25" name="form_id"><input type="submit" class="submit_button" value="Submit" name="add_to_form"></p></form></div>

Note that the later is missing the input form.

Changed in ppl:
assignee: nobody → Bassel Safadi (bassel)
Revision history for this message
Bassel Safadi (bassel) wrote :

each field is defined as field|permissionsGroup, all fields in form 25 ppl_stories were SystemGOD

changed the fileds permissions to People, should work now, can you test please?

Changed in ppl:
status: Triaged → In Progress
Bassel Safadi (bassel)
Changed in ppl:
status: In Progress → Fix Released
Revision history for this message
Christopher Adams (christopheradams) wrote :

Yes, I can confirm the fix works.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.