Trash not emptied with folders from other partitions
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cairo-Dock Plug-ins |
Fix Released
|
High
|
Fabounet |
Bug Description
When a folder from a partition other than the home partition is put into the trash, the trash can't be emptied with middle-clicking on the dustbin applet. I get an error like this:
------------------
vfs.c:cairo_
gnome_integration : Error removing file: Directory not empty
GError set over the top of a previous GError or uninitialized memory.
This indicates a bug in someone's code. You must ensure an error is NULL before it's set.
The overwriting error message was: Error removing file: No such file or directory
------------------
The GError part can be fixed by using "g_file_delete (file, NULL, NULL)" in that section of the function "cairo_
To fix "Error removing file: Directory not empty", in the same function, I added "G_FILE_
if (iFileType == G_FILE_
{
cairo_
}
I've attached a patch.
Related branches
- Daniel Holbach (community): Approve
-
Diff: 89895 lines (+33127/-36388)106 files modifiedCMakeLists.txt (+3/-1)
Clipper/src/applet-config.c (+2/-1)
Clipper/src/applet-notifications.c (+2/-2)
GMenu/src/applet-notifications.c (+39/-12)
Global-Menu/src/applet-app.c (+9/-9)
Indicator-applet/indicator-applet.c (+9/-9)
Messaging-Menu/src/CMakeLists.txt (+1/-0)
Messaging-Menu/src/applet-menu.c (+91/-35)
Messaging-Menu/src/dbus-data.h (+3/-0)
Remote-Control/src/applet-icon-finder.c (+4/-4)
Remote-Control/src/applet-notifications.c (+5/-5)
Status-Notifier/src/applet-item.c (+1/-1)
Status-Notifier/src/applet-notifications.c (+3/-3)
Status-Notifier/watcher/status-notifier-watcher.py.in (+11/-11)
alsaMixer/data/AlsaMixer.conf.in (+1/-1)
alsaMixer/data/CMakeLists.txt (+1/-0)
alsaMixer/data/gauges/CMakeLists.txt (+2/-0)
alsaMixer/data/gauges/Sound-Mono/0.svg (+29/-0)
alsaMixer/data/gauges/Sound-Mono/1.svg (+27/-0)
alsaMixer/data/gauges/Sound-Mono/2.svg (+25/-0)
alsaMixer/data/gauges/Sound-Mono/3.svg (+19/-0)
alsaMixer/data/gauges/Sound-Mono/CMakeLists.txt (+15/-0)
alsaMixer/data/gauges/Sound-Mono/readme (+1/-0)
alsaMixer/data/gauges/Sound-Mono/theme.xml (+12/-0)
alsaMixer/data/gauges/Sound-Mono/undef.svg (+15/-0)
alsaMixer/data/gauges/Sound-Mono/version (+1/-0)
alsaMixer/src/applet-backend-sound-menu.c (+6/-6)
alsaMixer/src/applet-draw.c (+1/-1)
clock/src/applet-draw.c (+27/-35)
clock/src/applet-init.c (+5/-1)
clock/src/applet-struct.h (+1/-0)
debian/cairo-dock-plug-ins.install (+1/-1)
debian/changelog (+68/-0)
debian/control (+4/-4)
debian/rules (+0/-1)
dnd2share/src/applet-backend-imagebin.c (+1/-1)
dnd2share/src/applet-backend-imageshack.c (+1/-1)
dnd2share/src/applet-backend-uppix.c (+1/-1)
dnd2share/src/applet-backend-videobin.c (+1/-1)
dock-rendering/src/rendering-panel.c (+5/-5)
drop-indicator/src/applet-notifications.c (+1/-1)
gvfs-integration/cairo-dock-gio-vfs.c (+1/-1)
keyboard-indicator/src/applet-draw.c (+3/-3)
mail/src/cd-mail-applet-accounts.c (+2/-2)
musicPlayer/src/applet-cover.c (+3/-3)
musicPlayer/src/applet-draw.c (+2/-2)
musicPlayer/src/applet-musicplayer.c (+5/-5)
po/ar.po (+1192/-1359)
po/cairo-dock.pot (+1148/-1323)
po/cs.po (+1145/-1344)
po/de.po (+1230/-1427)
po/el.po (+1171/-1383)
po/en_GB.po (+1159/-1372)
po/es.po (+1175/-1383)
po/et.po (+1142/-1329)
po/eu.po (+1190/-1358)
po/fr.po (+1328/-1476)
po/hu.po (+1148/-1347)
po/id.po (+1190/-1357)
po/it.po (+1175/-1383)
po/ja.po (+1272/-1649)
po/nl.po (+1417/-1562)
po/pl.po (+1222/-1374)
po/pt.po (+1139/-1338)
po/pt_BR.po (+1227/-1428)
po/ru.po (+1186/-1396)
po/sk.po (+1158/-1368)
po/sr.po (+1142/-1333)
po/sv.po (+1239/-1387)
po/tr.po (+1198/-1375)
po/uk.po (+1157/-1369)
po/zh_CN.po (+1149/-1343)
po/zh_TW.po (+1176/-1436)
powermanager/data/CMakeLists.txt (+1/-0)
powermanager/data/gauges/Battery-Mono/0.svg (+16/-0)
powermanager/data/gauges/Battery-Mono/1.svg (+18/-0)
powermanager/data/gauges/Battery-Mono/2.svg (+18/-0)
powermanager/data/gauges/Battery-Mono/3.svg (+18/-0)
powermanager/data/gauges/Battery-Mono/4.svg (+18/-0)
powermanager/data/gauges/Battery-Mono/5.svg (+18/-0)
powermanager/data/gauges/Battery-Mono/CMakeLists.txt (+16/-0)
powermanager/data/gauges/Battery-Mono/readme (+1/-0)
powermanager/data/gauges/Battery-Mono/theme.xml (+41/-0)
powermanager/data/gauges/Battery-Mono/version (+1/-0)
powermanager/data/gauges/Battery/CMakeLists.txt (+18/-0)
powermanager/data/gauges/Battery/background.svg (+322/-0)
powermanager/data/gauges/Battery/battery0.svg (+61/-0)
powermanager/data/gauges/Battery/battery1.svg (+104/-0)
powermanager/data/gauges/Battery/battery2.svg (+104/-0)
powermanager/data/gauges/Battery/battery3.svg (+104/-0)
powermanager/data/gauges/Battery/battery4.svg (+109/-0)
powermanager/data/gauges/Battery/battery5.svg (+104/-0)
powermanager/data/gauges/Battery/battery6.svg (+104/-0)
powermanager/data/gauges/Battery/battery7.svg (+66/-0)
powermanager/data/gauges/Battery/foreground.svg (+229/-0)
powermanager/data/gauges/Battery/readme (+1/-0)
powermanager/data/gauges/Battery/theme.xml (+37/-0)
powermanager/data/gauges/CMakeLists.txt (+3/-0)
powermanager/src/powermanager-draw.c (+13/-11)
quick-browser/data/quick-browser.conf.in (+2/-2)
shortcuts/src/applet-bookmarks.c (+7/-1)
shortcuts/src/applet-disk-usage.c (+1/-1)
shortcuts/src/applet-drives.c (+8/-0)
showDesktop/src/applet-notifications.c (+14/-2)
switcher/src/applet-draw.c (+4/-2)
switcher/src/applet-load-icons.c (+1/-1)
Changed in cairo-dock-plug-ins: | |
status: | Fix Committed → Fix Released |
Thanks a lot for this clear patch !
I apply it immediately on my branch :-)
2010/12/7 Tsu Jan <email address hidden>
> dock-gio- vfs.c.diff" /bugs.launchpad .net/bugs/ 686564/ +attachment/ 1758453/ +files/ cairo-dock- gio-vfs. c.diff /bugs.launchpad .net/bugs/ 686564 dock_gio_ vfs_empty_ trash:1624) [0m dock_gio_ vfs_empty_ trash", which is ATTRIBUTE_ STANDARD_ TYPE" to "cAttributes" and set the TYPE_DIRECTORY) gio_vfs_ empty_dir (sFileUri->str); _______ _______ _______ _______ _______ _____ /launchpad. net/~cairo- dock-team<https:/ /launchpad. net/%7Ecairo- dock-team> /launchpad. net/~cairo- dock-team<https:/ /launchpad. net/%7Ecairo- dock-team> /help.launchpad .net/ListHelp
> ** Patch added: "cairo-
>
> https:/
>
> --
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is subscribed to Cairo-Dock Plug-ins.
> https:/
>
> Title:
> Trash not emptied with folders from other partitions
>
> Status in Cairo-Dock : Plug-ins:
> New
>
> Bug description:
> When a folder from a partition other than the home partition is put into
> the trash, the trash can't be emptied with middle-clicking on the dustbin
> applet. I get an error like this:
>
> ------------------
> vfs.c:cairo_
> gnome_integration : Error removing file: Directory not empty
> GError set over the top of a previous GError or uninitialized memory.
> This indicates a bug in someone's code. You must ensure an error is NULL
> before it's set.
> The overwriting error message was: Error removing file: No such file or
> directory
> ------------------
>
> The GError part can be fixed by using "g_file_delete (file, NULL, NULL)" in
> that section of the function "cairo_
> related to the deletion of info files.
>
> To fix "Error removing file: Directory not empty", in the same function, I
> added "G_FILE_
> following condition in a proper place:
>
> if (iFileType == G_FILE_
>
> {
>
> cairo_dock_
>
> }
>
> I've attached a patch.
>
>
>
> _______
> Mailing list: https:/
> Post to : <email address hidden>
> Unsubscribe : https:/
> More help : https:/
>