qlog: Crashes when trying to revert a file to revision 1

[David Elrom]

In qlog, if you try revert to rev 1, it crashes:

bzr: ERROR: exceptions.KeyError: 'null:'

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/logwidget.py", line 479, in revert_to_revision
    self.sub_process_action(selected_branch_info, get_dialog)
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/logwidget.py", line 433, in sub_process_action
    old_revno_str = gp.revid_rev[old_revid].revno_str
KeyError: 'null:'

[Alexander Belchenko (bialix)]

So what?

[David Elrom (elromulous)]

And the application crashed. What do you mean so what?
On Nov 25, 2010 3:55 AM, "Alexander Belchenko" <email address hidden> wrote:
> So what?
>
> ** Changed in: bzr-explorer
> Status: New => Incomplete
>
> --
> I was attempting to revert to a previous version of a file
> https://bugs.launchpad.net/bugs/680787
> You received this bug notification because you are a direct subscriber
> of the bug.

[David Elrom (elromulous)]

In fact, on every project, it seems that reverting to revision 1 causes it
to crash.
On Nov 25, 2010 11:35 AM, "David Elrom" <email address hidden> wrote:
> And the application crashed. What do you mean so what?
> On Nov 25, 2010 3:55 AM, "Alexander Belchenko" <email address hidden> wrote:
>> So what?
>>
>> ** Changed in: bzr-explorer
>> Status: New => Incomplete
>>
>> --
>> I was attempting to revert to a previous version of a file
>> https://bugs.launchpad.net/bugs/680787
>> You received this bug notification because you are a direct subscriber
>> of the bug.

[Martin Pool (mbp)]

On 26 November 2010 03:35, Dave <email address hidden> wrote:
> And the application crashed. What do you mean so what?

Dave, Alexander asked "so what" because you didn't actually say in the
bug report that it crashed. People file bugs about a bunch of
different things, including just being confused. It's not obvious to
us that it crashed unless you say so or attach a crash file.

Did you get an error message or a crash file? Or did it just disappear?
--
Martin

[David Elrom (elromulous)]

My apologies for the confusion. I had clicked the bug submission link the tool shows with the error message, and assumed that it would be attaching the crash data. (i.e. that it was embedded into the link)

It seems to only happen when reverting to revision 1 (on any project I try it) and so far never otherwise.

This is what it dumped out:

bzr: ERROR: exceptions.KeyError: 'null:'

Traceback (most recent call last):
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/logwidget.py", line 479, in revert_to_revision
    self.sub_process_action(selected_branch_info, get_dialog)
  File "/usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr/lib/logwidget.py", line 433, in sub_process_action
    old_revno_str = gp.revid_rev[old_revid].revno_str
KeyError: 'null:'

bzr 2.2.1 on python 2.6.6 (linux2)
arguments: ['/usr/bin/bzr', 'explorer']
encoding: 'UTF-8', fsenc: 'UTF-8', lang: 'en_US.utf8'
plugins:
  bash_completion /usr/lib/python2.6/dist-packages/bzrlib/plugins/bash_completion [2.2.1]
  bzrtools /usr/lib/python2.6/dist-packages/bzrlib/plugins/bzrtools [2.2.0]
  explorer /usr/lib/python2.6/dist-packages/bzrlib/plugins/explorer [1.1.0]
  launchpad /usr/lib/python2.6/dist-packages/bzrlib/plugins/launchpad [2.2.1]
  netrc_credential_store /usr/lib/python2.6/dist-packages/bzrlib/plugins/netrc_credential_store [2.2.1]
  news_merge /usr/lib/python2.6/dist-packages/bzrlib/plugins/news_merge [2.2.1]
  qbzr /usr/lib/python2.6/dist-packages/bzrlib/plugins/qbzr [0.19.1]
  xmloutput /usr/lib/python2.6/dist-packages/bzrlib/plugins/xmloutput [0.8.6]

If there is a way to make it dump out more verbose debug info, please let me know and I'll run it again.

Thanks,
-Dave

[David Elrom (elromulous)]

Also perhaps worth noting, this is running on a fairly virgin (installed a day or two ago), yet up-to-date install of maverick

[Gary van der Merwe (garyvdm)]

Hi Dave.

Thanks for the bug report.

I had recently fixed this in trunk (rev 1336.) I should probably backport it to 0.19.

[David Elrom (elromulous)]

nice. thanks.

-dave

[Alexander Belchenko (bialix)]

Dave пишет:
> My apologies for the confusion. I had clicked the bug submission link
> the tool shows with the error message, and assumed that it would be
> attaching the crash data. (i.e. that it was embedded into the link)
>
> It seems to only happen when reverting to revision 1 (on any project I
> try it) and so far never otherwise.

Please, explain the steps you did so I can try to reproduce your
problem. I'm not quite understand how you revert to revision 1.
In Bazaar Explorer there is Bazaar > Work > Revert Working Tree menu but
it does not allow you to specify a revision. What you did exactly? What
command you ran?