time rate set in scripts resets at end of script
Bug #677874 reported by
Matthew Gates
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Stellarium |
Fix Released
|
High
|
Matthew Gates | ||
Bug Description
When the time rate is set using core.setTimeRat
This breaks existing scripts, and is not the desired behavior.
Related branches
| Changed in stellarium: | |
| importance: | Undecided → Medium |
| milestone: | none → 0.10.6 |
| importance: | Medium → High |
| assignee: | nobody → Matthew Gates (matthew-porpoisehead) |
Revision history for this message
| Matthew Gates (matthew-porpoisehead) wrote | #1 |
| Changed in stellarium: | |
| status: | New → Fix Committed |
| Changed in stellarium: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
specifically it breaks the lunar_eclipse scripts. Since recent changes, something new was implemented which means the pre-script time rate is restored when a script terminates.
I don't think this is what we want. For example, maybe we want to use the startup script to set the time rate to move fast(ish),
Also, this is inconsistent with other settings which a script might alter, which all persist after a script terminates. This is a good thing - it allows a script to be used to "set up" stellarium.
I plan to remove this "restore pre-script time rate" feature.