Pattern spam when adjusting a pattern in text.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Medium
|
Adonis Papaderos |
Bug Description
When a pattern is adjusted in a text object, multiple patterns are created in a chain, each containing only a transformation and a reference to the previous pattern.
PatternKnotHold
sp_item_
sp_
This routine looks at the hrefcount for the pattern.
If it is greater than 1 then a new pattern is created.
For shapes hrefcount is always 1 but for text it is 3
or more. For each <tspan>, hrefcount is incremented
by 2.
One problem I found here is that if a new pattern is needed, sp_repr_
The same thing happens with gradients but as the code structure is completely different for gradients they don't suffer from the same problem (there is no equivalent to sp_pattern_
tags: | added: pattern text |
Changed in inkscape: | |
status: | Fix Committed → In Progress |
Changed in inkscape: | |
status: | In Progress → Fix Committed |
Changed in inkscape: | |
assignee: | nobody → Adonis Papaderos (ado-papas) |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
Reproduced with Inkscape 0.46, 0.47, 0.48 and 0.48+devel r9888 on OS X 10.5.8.
Same pattern spam happens when assigning a pattern as fill to a group (e.g of shapes) and adjusting it using the node tool.