Mixxx doesn't get fullscreen correctly

[Irwin J. Céspedes B]

When Mixxx is in fullscreen mode the image is not well centered, and also the background is white. This happens in Trunk on Ubuntu Linux 10.10

[hiend (hippako)]

Same on 1280 x 800. No full screen

[William Good (bkgood)]

Fixed in lp:mixxx/1.9 r2657

Something happened to outline that caused the bgcolor setting to be weird, I changed it back to #ffffff as it was in 1.8. Other skins may need similar checking/changing of the background color.

Thanks to RJ for steering me in the right direction on this one.

[William Good (bkgood)]

Still screwed up on Windows.

[William Good (bkgood)]

Okay, this should be working on all platforms. I changed the GUI positioning from manual "put it in the middle of the screen" to using a QHBoxLayout, which does the same thing automatically. This made the fullscreen code ridiculously simple. I was dragging the window size around (this has been possible since uglyduckling was merged) and realized I could now maximize mixxx and have it very much like fullscreen (skin-matching background, centered GUI) but with still having access to other windows and the taskbar. I decided I liked this enough that I coded a bit around it and now the whole operation works quite nicely. The only real problem that I've found is that on x11, we can't seem to know when we're maximized so we can't re-maximize the GUI after a skin change but that's hardly a deal breaker.

If I need extra justification for this mini-feature. it also solves a problem I have with fullscreen where, when compositing is enabled in kwin, the whole GUI flashes whenever I open a menu or a tooltip appears. Super annoying, but doesn't happen when maximized, so it gives me (and surely someone else out there using mixxx with compositing on linux with whatever highly popular Intel GPU I have) something very much like fullscreen.

I am going to leave this "in progress" till I boot over to Windows and make sure I haven't broken anything. Unfortunately, I don't have a Mac to test on so that platform has gone utterly neglected with this bugfix.

[William Good (bkgood)]

Works on Windows, marking fix committed (finally) (hopefully for the last time)

[Albert Santoni (gamegod)]

Great work, thanks Bill!

I'll let you know if this fix doesn't work on OS X, but OS X hasn't
tended to have problems with fullscreen in the past so it's probably
fine.

Thanks again!
albert

On Mon, Jan 3, 2011 at 1:08 AM, Bill Good <email address hidden> wrote:
> Works on Windows, marking fix committed (finally) (hopefully for the
> last time)
>
> ** Changed in: mixxx
>       Status: In Progress => Fix Committed
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/669628
>
> Title:
>  Mixxx doesn't get fullscreen correctly
>

[jus (jus)]

Thanks for the fix, works fine here.
Fullscreen was broken in 1.9 until for Mac OS 10.5 & 10.6.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5627