linaro-media-create: stray quote means images don't boot on beagle

[Peter Maydell]

SRU justification:

The linaro-image-tools 0.2 package included in the maverick release isn't usable with any of the images Linaro is releasing for 10.11. Unfortunately there has been a lot of development going on on these tools over the past few months that was never uploaded to the archive, only to ppa. This means the linaro-image-tools package that has been uploaded to maverick-proposed falls well outside the normal rules for SRUs; but on the other hand, the package currently in maverick is useless for all practical purposes, so the risk of regression here is minimal.

Test case:
http://wiki.linaro.org/Releases/DailyBuilds

As an SRU this will be subjected to holistic testing by the Linaro release itself. Our release notes will direct users to the linaro-image-tools package in the linaro-maintainers ppa, which is identical to this SRU except for version number. These release notes could be amended to direct users to maverick-proposed if and when this SRU is accepted.

There seems to be a spurious single quote character in the boot_args_options settings for the beagle|igep devices in linaro-media-create. The effect of this is that created images fail to boot with the unhelpful error message from u-boot:

Running bootscript from mmc ...
## Executing script at 82000000
syntax error
Unknown command '>' - try 'help'

(Image generated with linaro-media-create r156 and the following command line:
 sudo /home/petmay01/bin/linaro-media-create --rootfs ext3 --image_file 1027.img --dev beagle --binary linaro-m-headless-tar-20101027-0.tar.gz --hwpack hwpack_linaro-omap3_20101022-59_armel_supported.tar.gz
and tested with qemu:
 qemu-maemo-system-arm -M beagle -sd 1027.img -serial stdio
)

Here's a trivial patch which fixes this for me:

--- linaro-media-create 2010-10-27 13:39:38.720196000 -0400
+++ /home/petmay01/bin/linaro-media-create 2010-10-27 14:08:12.335613817 -0400
@@ -374,7 +374,7 @@
   # set board specific options
   case "$DEVIMAGE" in
     beagle|igep)
- boot_args_options="$boot_args_options earlyprintk fixrtc nocompcache vram=12M omapfb.debug=y omapfb.mode=dvi:1280x720MR-16@60'"
+ boot_args_options="$boot_args_options earlyprintk fixrtc nocompcache vram=12M omapfb.debug=y omapfb.mode=dvi:1280x720MR-16@60"
     ;;

     panda)

[Loïc Minier (lool)]

Fixed in bzr; thanks!

[Martin Pitt (pitti)]

Accepted linaro-image-tools into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package linaro-image-tools - 0.3

---------------
linaro-image-tools (0.3) maverick-proposed; urgency=low

  [ Steve Langasek ]
  * no longer using the 'omap' uboot flavor support in live-helper; instead,
    run the mkimage commands directly for omap.
  * fix the paths used for looking up x-loader and u-boot binaries in the
    tarball; these don't belong in /boot at all, pull them from /usr/lib.
  * only enforce the presence of commands we're actually using; this lets
    us automatically pull in btrfs-tools when btrfs is specified.
  * add sudo to a couple more commands in linaro-media-create, so the script
    itself can run as non-root as intended.

  [ James Westby ]
  * Add a linaro-hwpack-create script for the creation of hardware packs.

  [ Steve Langasek ]
  * Fix lookup of linaro-hwpack-install to work correctly when l-m-c is on
    the path. Closes: #652669.

  [ Loïc Minier ]
  * Drop spurious single quote character in boot_args_options for beagle|igep;
    thanks Peter Maydell; LP: #667400.
  * Set LC_ALL=C when entering the chroot as it has no locales. LP: #651905.

  [ Tom Gall ]
  * Use --numeric-owner argument to tar when unpacking, so that files get
    the right owner on boot of the image. LP: #652121.

  [ Dave Martin ]
  * Implement proper cleanup handling on signal / exit, so that we don't
    leave clutter behind on error. This also fixes the message at the end of
    a successful install about being unable to unmount proc. LP: #616385,
    #660196, #667394, #643601, #627383.
 -- Steve Langasek <email address hidden> Tue, 09 Nov 2010 12:50:26 -0800