ethernet module has a control flow bug
Bug #662924 reported by
Faustus
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
laptop-mode-tools (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
Binary package hint: laptop-mode-tools
First,
/usr/share/
/usr/share/
are confusing without the quotes around the variable given to -z (but it still works in Bash).
Second, in the ETHERNET devices loop, if $path is empty, previous value for $dev_path will be used (redundantly operating on the device).
Related branches
To post a comment you must log in.
On Tuesday 19 Oct 2010 01:56:38 Faustus wrote: laptop- mode-tools/ modules/ ethernet: if ! [ -z laptop- mode-tools/ modules/ ethernet: if ! [ -z
> First,
>
> /usr/share/
> $path ]; then
> /usr/share/
> $dev_path ] && [ -f $dev_path/enable ]; then
>
> are confusing without the quotes around the variable given to -z (but it
> still works in Bash).
>
So does it not work with dash ?
laptop-mode-tools uses dash and I haven't seen this bug report. In case you
see problems when run with dash, please report.
> Second, in the ETHERNET devices loop, if $path is empty, previous value
> for $dev_path will be used (redundantly operating on the device).
Thank you. I have fixed this in the upstream branch. Will be part of the next
(1.56) release.
Ritesh
-- www.researchut. com
Ritesh Raj Sarraf
RESEARCHUT - http://
"Necessity is the mother of invention."