Application Review Request: SIR 2.1

[Rafael Sachetto]

Application Review For SIR 2.1

== About You ==

 * NAME: Rafael Sachetto
 * EMAIL ADDRESS: <email address hidden>

The Application:

 * APPLICATION NAME: SIR Simple Image Resizer
 * LICENSE: GPL v3
 * PPA URL: https://edge.launchpad.net/~rsachetto/+archive/ppa/
 * SUPPORT RESOURCE: http://code.google.com/p/sir/issues/list

[Allison Randal (allison)]

A quick update: we're delaying applications in the Application Review Board queue to have a more detailed conversation about review standards at the Ubuntu Developer Summit this week.

[Allison Randal (allison)]

The App Review Board did an initial review of SIR in the most recent meeting, and hope to approve it in the next meeting on Tuesday Dec 21st. The only obstacle is a small technical one, we need to modify the package to install in /opt instead of the regular /usr/... paths. To test it out, I made a modified version of your SIR package. I've attached a diff of my changes here, let's talk about the best way to integrate these into your package.

Most of the changes are simple path updates for the /opt install location. This includes changes to the files sir.pro, sir.desktop, and sir_service.desktop. Since you probably don't want to modify your basic tarball to install in these unusual paths, these could be handled by a quilt patch in the debian packaging directory (I can help you set that up).

The other changes I added to correct errors or warnings detected by the lintian utility. In your debian/rules file, the command 'dh_clean -k' has been deprecated, replaced by 'dh_prep' (see http://lintian.debian.org/tags/dh-clean-k-is-deprecated.html). In your debian/control file, I updated the standards version to what's expected for Maverick (3.9.1), and fixed the build dependency version for debhelper so it matched the version in the debian/compat file. The entry in debian/changelog is mostly just a notice of my changes, but the important alteration is in the format of the first line of the changelog entry to the Ubuntu standard "sir (2.1-0ubuntu2) maverick; urgency=low", especially in the package version "2.1-0ubuntu2", which indicates that this package hasn't been shipped on debian (the first "0"), and which revision of the Ubuntu package it is (I set it to "2", since mine was a revision of your package).

There's one remaining lintian warning, about installing in /opt. We're currently discussing the best way to handle this as a standard across all packages that go through the ARB process, I'll let you know the conclusion.

Should be a quick fix, so hopefully we can get SIR approved and into the Maverick Software Center next week.

[Rafael Sachetto (rsachetto)]

@Allison Randal Can you help me to set up the quilt patch? I have never done this before.

Will the /opt install location be in the system path??

[Allison Randal (allison)]

I've attached a patch that makes the changes necessary for quilt (as well as the other changes I made previously). This adds three files: debian/patches/install_in_opt.patch (the patch file), debian/patches/series (tells quilt which patches to apply), and debian/README.source (a standard notice included when you're using quilt to apply patches to a package). It also modifies 2 files: debian/control (to make quilt a build dependency for the package), and debian/rules (to actually run quilt during the package build).

If you make a new release of SIR with these changes applied, plus fixing the first line of the debian/changelog file as I did in the previous patch, you should be all set.

[Allison Randal (allison)]

Hi Rafael, do you have an update? Feel free to ask any questions or catch me on IRC ('wendar' on irc.freenode.net). The next Application Review Board meeting is a week away, and it would be great to be able to vote on (and hopefully approve) SIR for release then.

[Rafael Sachetto (rsachetto)]

On Tue, Jan 25, 2011 at 22:04, Allison Randal <email address hidden> wrote:
> Hi Rafael, do you have an update? Feel free to ask any questions or
> catch me on IRC ('wendar' on irc.freenode.net). The next Application
> Review Board meeting is a week away, and it would be great to be able to
> vote on (and hopefully approve) SIR for release then.
>

Hi Aliison, thank you very much for your attention.
I applied the patches and uploaded the new version to my PPA.

Best Regards,
--
Rafael Sachetto Oliveira

[Allison Randal (allison)]

Thanks, Rafael. This looks good, I'll submit it for vote in the meeting tomorrow.

[Allison Randal (allison)]

The app was approved! The next step will be creating a final version of the package and getting it into the system for distribution. This will involve releasing a version of the package with the official numbering scheme (that's now 2.1-0extras10.10.1), and setting up a screenshot and thumbnail image for the package (see https://wiki.ubuntu.com/PostReleaseApps/Metadata for more details). Let me know if you have any questions or need any help (especially with the images, that process isn't as straightforward as it needs to be yet).

[Rafael Sachetto (rsachetto)]

On Fri, Feb 4, 2011 at 22:14, Allison Randal <email address hidden> wrote:
> The app was approved!

Great news, thank you very much!

>The next step will be creating a final version of
> the package and getting it into the system for distribution. This will
> involve releasing a version of the package with the official numbering
> scheme (that's now 2.1-0extras10.10.1)

No Problem.

, and setting up a screenshot and
> thumbnail image for the package (see
> https://wiki.ubuntu.com/PostReleaseApps/Metadata for more details). Let
> me know if you have any questions or need any help (especially with the
> images, that process isn't as straightforward as it needs to be yet).

I would like some help to set up the images. A can take I screenshot and sir
has a program Icon alread.

> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/644066
>
> Title:
>  Application Review Request: SIR 2.1
>

--
Rafael Sachetto Oliveira

[Allison Randal (allison)]

I can do the mechanical steps of submitting the screenshot images for upload, if you create the images. We'll need two PNG files of the screenshot: a full-sized one and a thumbnail. The recommended size for these is 800 x 600 and 160 x 120, though there's room for variation.

The icon for the application is already handled in the .desktop file, so you don't need to do anything there.

[Rafael Sachetto (rsachetto)]

Allison, thank you very much for helping me with this. The screenshots
are attached.

Another question: Do I need to add the Custom Metadata Fields to my
debian/control file?

[Allison Randal (allison)]

Hi Rafael. Sorry to take so long to get back to you, I should have followed up on this months ago. We've been a bit hung up on the tools, but with the launch of the new developer.ubuntu.com and the new app submission web interface, we're kicking things back up to speed. If you resubmit your app through the new website, it'll let you upload your screenshots directly, cutting out the whole complicated process we had before. You'll still need to add the Custom Metadata Fields to debian/control, I can help you get the right image URLs for that.

The Oneiric release of Ubuntu is coming up on Oct 13th, so all existing submissions to the ARB will need to update their submission. This involves retargeting your app to Oneiric, rather than Natty or Maverick. Particularly, in your PPA, you'll need to explicitly submit your package for Oneiric, with a changelog entry such as:

myapp (myapp_0.3.9-0extras11.11.1~oneiric1) oneiric; urgency=low

If we don't hear back from you by the next ARB meeting on Oct 25th, we'll assume you're no longer interested, or have taken one of the other avenues for getting your app into Ubuntu (like submission upstream through Debian), and will close this ticket. If you miss the deadline but still want to apply, you can always resubmit later through:

http://developer.ubuntu.com/publish/

Thanks for your patience, and for your interest in getting your app into Ubuntu!

[Stéphane Graber (stgraber)]

Closing as the entry hasn't been updated since 2011-09-28.