navigation menu in collections should stay open

[Dirk Meyer]

MySQL, 1.3.0, Linux

When the navigation menu of a collection reaches a certain width, a 'read-more' type tab appears (this tab contains three dots). Clicking that tab displays the menu for all views of the collection.

After clicking any of the tabs, (after the menu has expanded), the menu will 'shrink' again to its original state, displaying the 'read-more' tab again. Perhaps there could be a rule that, after clicking the 'read-more' tab once, the menu will remain fully open?

[Eugene (eugenev)]

Here's a patch that will keep the extended tabs (that results from clicking the 'read more' tab) open if one of them is currently selected/viewed ;)

[François Marier (fmarier)]

Patch needs to be reviewed and tested.

[Hugh Davenport (hugh-davenport)]

Added patch to gerrit
https://reviews.mahara.org/#change,105

Tested, and tabs stay open only if one of the hidden views is selected. If one of the first few views are selected, then the extra views are hidden still.

[Ruslan Kabalin (rkabalin)]

There is a room for improvement here. We probably should move '...' tab to the end when menu is expanded and replace its content to '<<'. The menu should not be closed when first few tabs are selected.

[Hugh Davenport (hugh-davenport)]

Working on this now.

Just a thought, what should happen if a view is selected that is in the "hidden" zone, and then the hide '<<' button is clicked.
Should it just hide it so you can't see the selected view (easiest), or refuse to hide, or hide up to that view?

Cheers,

Hugh

[Hugh Davenport (hugh-davenport)]

Right new patch uploaded for review.

https://reviews.mahara.org/105

The only problem I see now is that if you refresh the page after the button has been expanded or reduced in size, then it is reset to the original position.

Cheers,

Hugh

[Dirk Meyer (dirkmeyer)]

Thank you for working on this.
Although I don't quite follow the comments, the following makes sense to me;

At first, some buttons can be seen, some not-there is a '...' button. Hiding
some buttons at first makes sense to me.
Upon clicking the '...' button, the hidden buttons will be visible.
All buttons should remain visible after clicking on any of the buttons. A
user probably wants to click on all the buttons anyways.
Having the option to hide buttons could be useful, especially when
collections get big but I don't think its critical

If the '...' appears after a refresh of a page, that's ok with me.

On Thu, May 5, 2011 at 6:27 PM, Hugh Davenport <email address hidden>wrote:

> Right new patch uploaded for review.
>
> https://reviews.mahara.org/105
>
> The only problem I see now is that if you refresh the page after the
> button has been expanded or reduced in size, then it is reset to the
> original position.
>
> Cheers,
>
> Hugh
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/640937
>
> Title:
> navigation menu in collections should stay open
>
> Status in Mahara ePortfolio:
> In Progress
>
> Bug description:
> MySQL, 1.3.0, Linux
>
> When the navigation menu of a collection reaches a certain width, a
> 'read-more' type tab appears (this tab contains three dots). Clicking
> that tab displays the menu for all views of the collection.
>
> After clicking any of the tabs, (after the menu has expanded), the
> menu will 'shrink' again to its original state, displaying the 'read-
> more' tab again. Perhaps there could be a rule that, after clicking
> the 'read-more' tab once, the menu will remain fully open?
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/mahara/+bug/640937/+subscribe
>

--
Dirk Meyer
phone: [phone] ext. 5344

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/198
Committed: http://gitorious.org/mahara/mahara/commit/997b8e5df5695b2d85764cbe335a0568d319968e
Submitter: Francois Marier (<email address hidden>)
Branch: master

commit 997b8e5df5695b2d85764cbe335a0568d319968e
Author: Hugh Davenport <email address hidden>
Date: Wed May 18 15:06:55 2011 +1200

    Fix issue with collections when page is outside shown range

    When you go directly to a page in a collection and
    the page is outside the shown range, the expanding
    tab doesn't start in the expanded state.

    Bug #640937

    Change-Id: I3a85908d9709719f115adafbf89e0c705482201d
    Signed-off-by: Hugh Davenport <email address hidden>