Unfocused selected item in software list is white on light grey

Bug #635208 reported by Matthew Paul Thomas
16
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Fix Released
Low
Andrea Cimitan
Maverick
Fix Released
Undecided
Unassigned
Natty
Fix Released
Low
Andrea Cimitan

Bug Description

Binary package hint: software-center

Ubuntu Software Center 2.1.18, light-themes 0.1.7, Ubuntu Maverick

0. Switch to the Ambiance theme if you're not using it.
1. Navigate to any software list (e.g. "Get Software" > "Office").
2. Select an item in the list.
3. Focus the search field.

What happens: The text in the selected item becomes almost unreadable, because it's white on pale grey.
What should happen: The text should be black on pale grey, like the selected item is in the unfocused navigation pane.

Changed in software-center (Ubuntu):
importance: Undecided → Low
Changed in software-center (Ubuntu):
status: New → In Progress
assignee: nobody → Mohamed Amine IL Idrissi (ilidrissi.amine)
Revision history for this message
Mohamed Amine Ilidrissi (ilidrissi.amine) wrote :

I think this should be handled by light-themes, though I'm not sure, so not closing the USC task.

Changed in software-center (Ubuntu):
status: In Progress → Incomplete
assignee: Mohamed Amine IL Idrissi (ilidrissi.amine) → nobody
Changed in light-themes (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Matthew Paul Thomas (mpt) wrote :

<Cimi> the treeview is using text[SELECTED] instead text[ACTIVE]

Changed in software-center (Ubuntu):
status: Incomplete → Triaged
Changed in light-themes (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Andrea Cimitan (cimi) wrote :

It's a guess it's using text[SELECTED] instead text[ACTIVE], because judging from the color used for the grey box, the grey box is using base[ACTIVE] (text[ACTIVE] is nearly black in light-themes, see rhythmbox for example)

Revision history for this message
Andrea Cimitan (cimi) wrote :

Here it is :)

in file: softwarecenter/view/appview.py
at lines: 1071-1072
---
if (flags & gtk.CELL_RENDERER_SELECTED) != 0:
            state = gtk.STATE_SELECTED
---
This explicitly sets all states to SELECTED, even if they are ACTIVE. Of course this behaviour doesn't seem correct to me.

Regards, Cimi

Revision history for this message
Andrea Cimitan (cimi) wrote :

Bug FIXED.
Created a new branch and proposed it for merging:
https://code.launchpad.net/~cimi/software-center/fix-lp-bug-635208/+merge/37234

Ciao!

Changed in software-center (Ubuntu):
assignee: nobody → Andrea Cimitan (cimi)
status: Triaged → Fix Committed
status: Fix Committed → In Progress
Michael Vogt (mvo)
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted software-center into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in software-center (Ubuntu Maverick):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Vadim Peretokin (vperetokin) wrote :

Looks better.

Omer Akram (om26er)
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 3.0.5

---------------
software-center (3.0.5) maverick-proposed; urgency=low

  [ Andrea Cimitan ]
  * fix rendering with Ambiance theme (LP: #635208)

  [ Kiwinote ]
  * softwarecenter/app.py:
    - support launching apturls via alt+F2 in gnome (LP: #653889)
  * softwarecenter/db/update.py:
    - use 'X-GNOME-FullName' rather than 'Name', when available (LP: #651260)
      (test case: software-center cheese empathy evolution gwibber)
  * softwarecenter/view/appview.py:
    - unblock pkg if transaction is cancelled (LP: #652903)
      (test case: launch s-c with a list view, choose a pkg, click install,
       cancel auth, click install again, install should work as normal)
  * softwarecenter/view/availablepane.py:
    - don't show 'hide 1 technical item' in featured category (LP: #651236)
      (test case: browse to featured category (by clicking 'all'))
    - don't show 'hide technical items' in system category, as we don't
      have any apps to show (LP: #636854)
      (test case: browse to 'System' category)
  * softwarecenter/view/historypane.py:
    - correctly split pkgnames for pkg transactions dated before 28-ish July
      (LP: #651241)
      (test case: view transaction in history pane dated pre 28 July)
  * softwarecenter/view/viewswitcher.py:
    - emit 'transactions-changed' signal after connecting to the backend so
      that we display any pending transactions (LP: #652927)
      (see bug report for test case)

  [ Michael Vogt ]
  * softwarecenter/backend/aptd.py:
    - use keyserver.ubuntu.com on port 80 by default to avoid problems
      on machines that filter the port 11371
  * softwarecenter/backend/restfulclient.py, softwarecenter/enums.py:
    - use plain http for the "what-is-available" API call
  * send user default language for "/apps" and "/subscription" requests
    now that the server is ready for this
 -- Michael Vogt <email address hidden> Wed, 13 Oct 2010 16:13:10 +0200

Changed in software-center (Ubuntu Maverick):
status: Fix Committed → Fix Released
Kiwinote (kiwinote)
Changed in software-center (Ubuntu Natty):
status: Fix Committed → Fix Released
no longer affects: light-themes (Ubuntu)
no longer affects: light-themes (Ubuntu Maverick)
no longer affects: light-themes (Ubuntu Natty)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.