Loop control doesn't work with midi interface

[Guy Martin]

The loop control is broken like the cue control was for midi interface (bug 630995).

Here is a similar patch which makes it work when value is != 1.

[Albert Santoni (gamegod)]

Do we still need this fix, or did <button/> solve the issue for you?

On Tue, Sep 7, 2010 at 9:59 AM, Guy Martin <email address hidden> wrote:
>
> ** Patch added: "Mixx loop midi control fix"
>   https://bugs.launchpad.net/bugs/632533/+attachment/1554151/+files/mixx-loop-midi.patch
>
> --
> Loop control doesn't work with midi interface
> https://bugs.launchpad.net/bugs/632533
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[Guy Martin (gmsoft)]

Erm actually the <button/> thingy works.
Not sure why I wasn't able to get that to work initially. I'll submit new updated BCD 3000 bindings later for bugs 632590.

However I still think that this patch is a good idea as it will probably avoid a lot of headaches for ppl trying to come up with some bindings. Also, I don't think it will do any harm but if you think otherwise, just drop it :)

[RJ Skerry-Ryan (rryan)]

I think we should keep the explicit requirement that to indicate 'button down' you set a control to 1.0, and to signify 'button up' you set it to 0.0 unless there are devices that refuse to emit those values. There are tons of parts of Mixxx that rely on that so if we start allowing it some places without changing all of them things wont be consistent.

[Albert Santoni (gamegod)]

Patch is in 1.8 r2561, thanks Guy!

(Talked it over with RJ and we agreed that it'd be better to be
consistent with the other controls inside Mixxx for now...)

On Fri, Sep 10, 2010 at 10:32 PM, RJ Ryan <email address hidden> wrote:
> I think we should keep the explicit requirement that to indicate 'button
> down' you set a control to 1.0, and to signify 'button up' you set it to
> 0.0 unless there are devices that refuse to emit those values. There are
> tons of parts of Mixxx that rely on that so if we start allowing it some
> places without changing all of them things wont be consistent.
>
> --
> Loop control doesn't work with midi interface
> https://bugs.launchpad.net/bugs/632533
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
>

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/5504