[SRU] gnome-keyring doesn't unlock ssh key

[Joe Barker]

Binary package hint: gnome-keyring

Description: Ubuntu maverick (development branch)
Release: 10.10

gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu1
  Candidate: 2.92.92.is.2.31.91-0ubuntu1
  Version table:
 *** 2.92.92.is.2.31.91-0ubuntu1 0
        500 http://gb.archive.ubuntu.com/ubuntu/ maverick/main amd64 Packages
        100 /var/lib/dpkg/status

Upon logging in, the SSH key should automatically be unlocked if the option was set.

Upon logging in, however, the key doesn't get unlocked, nor is there an option when I enter the passphrase to permanently unlock the key, as evidenced in the attached file.

This worked as expected in all previous versions I've used.

== Regression details ==
Discovered in version: maverick 2.92.92.is.2.31.91-0ubuntu1
Last known good version: lucid 2.92.92.is.2.30.0-0ubuntu3

[Tobias Wolf (towolf)]

I don't think that bug was really fixed. I tried the mentioned commit and it still asks.
This is really annoying me on a daily basis.

[Marc Deslauriers (mdeslaur)]

@seb128: where has this fix been committed to?

[stlsaint (stlsaint)]

Yes i don't see the fixed commit!

[Rico Tzschichholz (ricotz)]

The following patch fixes the problem

https://code.edge.launchpad.net/~ricotz/gnome-keyring/ubuntu/+merge/37173

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-keyring - 2.92.92.is.2.31.91-0ubuntu4

---------------
gnome-keyring (2.92.92.is.2.31.91-0ubuntu4) maverick; urgency=low

  * 10_git_fix_cka_trusted_collections.patch: Add patch cherry-picked from
    upstream commit d9ef94455d115d8fed29a3071b5b19ca632fb932 to fix a
    broken boolean check. Fixes bug with keyring not being unlocked at
    session login. (LP: #631980)
    References: https://bugzilla.gnome.org/show_bug.cgi?id=627815
 -- Iain Lane <email address hidden> Thu, 30 Sep 2010 18:30:56 +0100

[Tobias Wolf (towolf)]

Didn't work for me. It's still asking for the passphrase of the SSH key.

Do I need to do anything?

[Alexey Ten (Lynn) (alexeyten)]

Still no option to permanently store passphrase

[Joe Barker (joeb454)]

I've just installed the latest updates on my 10.10 install, and 'apt-cache show gnome-keyring' tells me that the latest version of gnome-keyring as this:

Version: 2.92.92.is.2.30.0-0ubuntu3

Do we know if/when 2.92.92.is.2.31.91-0ubuntu4 will be pushed into the repo's?

[Eugene Crosser (crosser)]

The problem fixed for me by a recent update.

gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4

[Tobias Wolf (towolf)]

On Thu, Oct 7, 2010 at 8:58 PM, Eugene Crosser
<email address hidden> wrote:
> The problem fixed for me by a recent update.
>
> gnome-keyring:
>  Installed: 2.92.92.is.2.31.91-0ubuntu4

I have that version too and it's still asking for the SSH key
passphrase when I log in.

ssh-add -l shows the key before that, but it still asks.

[Joe Barker (joeb454)]

Eugene, how did you get this package installed? It isn't showing in the repositories for me, I'm unsure why that would be.

[Tobias Wolf (towolf)]

Joe,

perhaps your sources.list is subscribed to UK mirror and that lags behind?

Please report if it works for you because it doesn't for me.

$ apt-cache policy gnome-keyring
gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4
  Candidate: 2.92.92.is.2.31.91-0ubuntu4
  Version table:
 *** 2.92.92.is.2.31.91-0ubuntu4 0
        500 http://archive.ubuntu.com/ubuntu/ maverick/main i386 Packages
        100 /var/lib/dpkg/status
     2.92.92.is.2.31.91-0ubuntu1ppa2 0
        500 http://ppa.launchpad.net/towolf/crack/ubuntu/ maverick/main i386 Packages

[Joe Barker (joeb454)]

Just checked for any new versions, of which there was nothing. Ran the same command as Tobias and got the same result for gnome-keyring, so I ran apt-get clean, then aptitude reinstall.

The issue is definitely still present on my system.

[Mike Barker (msb-msbarker)]

I just want to comment that I have the same problem. This is a fresh install of 10.10 RC and it does not unlock my ssh-key on login. Typing in my >40 character ssh-key password is getting a bit old, especially when pre-10.10 systems did not have this issue!

I am running the putatively patched version of gnome-keyring:

gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4
  Candidate: 2.92.92.is.2.31.91-0ubuntu4
  Version table:
 *** 2.92.92.is.2.31.91-0ubuntu4 0

[bitu-derr (biturica)]

This is still affecting me and my system is up to date.

This is my version output, if it helps:

~$ apt-cache policy gnome-keyring
gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4
  Candidate: 2.92.92.is.2.31.91-0ubuntu4
  Version table:
 *** 2.92.92.is.2.31.91-0ubuntu4 0
        500 http://us.archive.ubuntu.com/ubuntu/ maverick/main amd64 Packages
        100 /var/lib/dpkg/status

[CutControl (soulsimple-deactivatedaccount)]

gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4

Did not work here. Still prompt twice on login.

[Milan Bouchet-Valat (nalimilan)]

Reopening as per recent comments.

[Tobias Wolf (towolf)]

I made PPA and put version 2.32.1 of gnome-keyring in it: ppa:towolf/g-k-r-2.32
SSH unlocking works.

Apparently the reason for keeping the pre-release 2.31.91 was that the delay for forgetting passphrase wasn’t carried over from Gconf. (But it’s converted in 2.32.1 to GSettings AFAICT):

> Not sure we will get 2.31.92 as there is no migration from gconf -> gsetting.
> We will maybe keep 2.31.91.
> Built and tested here.

 — https://bugs.edge.launchpad.net/ubuntu/+source/gnome-keyring/+bug/645561/comments/4

[Joe Barker (joeb454)]

Tobias, that works perfectly, I've just tested it, thanks!

Will this make it into maverick-backports at all?

[Anquietas (e-admin-infosky-ro)]

Please resolve this A.S.A.P. !

It's very annoying to do this on 30 computers at my work place.

I have the private keys, I have the Seahorse Daemon running, seahorse can see the private key, but I cannot "remeber for good" or permanently the password for that private key in it's default keyring.

Please make the fix (I don't know what happened in the first place, why someone tampered with that code that worked OK), nevermind, and please make an update soon so I may update the package to be able to Remember SSH Private Key Passwords Permanently (or simply put: store private key password in gnome keyring and unlock it at every session startup).

Tobias Wolf: until someone decides to update this (I hope really soon !!) can you tell me please how to access your modified version of the package that fixes this problem ?

[Marc Deslauriers (mdeslaur)]

This was fixed in Maverick. If you still get this issue, it's a different bug.

When you're logged in, what process is managing the SSH keyring? To find out, open a terminal, and type: lsof $SSH_AUTH_SOCK and paste the results here.

[Tobias Wolf (towolf)]

Marc, that’s odd. Why do you say this bug was fixed when it wasn’t for the original reporter or anybody else in this thread?

Anqi look here: https://launchpad.net/~towolf/+archive/g-k-r-2.32

[Marc Deslauriers (mdeslaur)]

My apologies, I was sure this was resolved, but I just tested in a fresh VM, and the problem still exists in an up to date maverick. Please disregard my comment #22.

[stlsaint (stlsaint)]

Tobias i tried the patch you linked some time ago and it worked for about a day then it went away. The option to remember is still there but its all blacked out and i cannot select it. Thus im back to square one. Thanks for working holding up the branch though, it shows promise that the issue can be fixed.

[Anquietas (e-admin-infosky-ro)]

When can I expect a quick resolve to this bug ?... or who is fixing this bug ?...
To whoever is fixing bugs, Please, I want this bug resolved a.s.a.p !

When it gets resolved, will there be an Update trough the Update Manager ? or how can I apply the update ?

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-keyring - 2.92.92.is.2.31.91-0ubuntu5

---------------
gnome-keyring (2.92.92.is.2.31.91-0ubuntu5) natty; urgency=low

  * debian/patches/91_fix_ssh_unlock.patch: fix automatic unlock of ssh
    keys. (LP: #631980)
 -- Marc Deslauriers <email address hidden> Sun, 07 Nov 2010 18:41:21 -0500

[Marc Deslauriers (mdeslaur)]

SRU request for Maverick:

Impact: Gnome-keyring contains a regression from lucid that doesn't allow users to unlock ssh keys upon login.

Bug has been addressed by adding a minimal patch containing two upstream commits that fix this issue. See included debdiff.

How to test:

1- Create ssh key
2- Use ssh key to log into a remote machine, upon first use, password dialog should contain a checkbox to enable automatic key unlocking upon login. Check the checkbox.
3- Log out, log back in.
4- Attempt to ssh into a remote machine again. Gnome-keyring should not prompt for ssh key.

[Anquietas (e-admin-infosky-ro)]

OK, it is a debdiff that fixes this... but how about an update included in the repos ?... It's painfull to put that diff on an USB stick and do all those tasks on 30 computers.

Why don't you just simply include the update in the Update Manager ?

[Marc Deslauriers (mdeslaur)]

@Anquietas: This is the proper procedure to get a package into the official updates. First a member of the ubuntu-sru team will push it to the -proposed updates repository. After getting positive feedback in this bug it will get pushed to the -updates repository and you will see it appear in Update Manager.

[Anquietas (e-admin-infosky-ro)]

ok, Thank you :) I didn't know the exact procedure :)

I've installed the patch, it works great ! Thank you. I really hope it gets in the repos soon.

[Martin Pitt (pitti)]

Accepted gnome-keyring into maverick-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Marc Deslauriers (mdeslaur)]

I have tested the package in -proposed on maverick, and it works as expected.

[Launchpad Janitor (janitor)]

This bug was fixed in the package gnome-keyring - 2.92.92.is.2.31.91-0ubuntu4.1

---------------
gnome-keyring (2.92.92.is.2.31.91-0ubuntu4.1) maverick-proposed; urgency=low

  * debian/patches/91_fix_ssh_unlock.patch: fix automatic unlock of ssh
    keys. (LP: #631980)
 -- Marc Deslauriers <email address hidden> Sun, 07 Nov 2010 17:41:34 -0500

[NoOp (glgxg)]

Just updated a lucid system to maverick (gnome) and am getting prompted to unlock the keyring on every boot:

$ apt-cache policy gnome-keyring
gnome-keyring:
  Installed: 2.92.92.is.2.31.91-0ubuntu4.1
  Candidate: 2.92.92.is.2.31.91-0ubuntu4.1
  Version table:
 *** 2.92.92.is.2.31.91-0ubuntu4.1 0
        500 http://us.archive.ubuntu.com/ubuntu/ maverick-updates/main i386 Packages
        100 /var/lib/dpkg/status
     2.92.92.is.2.31.91-0ubuntu4 0
        500 http://us.archive.ubuntu.com/ubuntu/ maverick/main i386 Packages

[Marc Deslauriers (mdeslaur)]

@NoOp: this bug is closed. Please open a new bug for your issue.